| Bawolff | |
| Sep 14 2015, 5:49 PM |
| F2604329: Screen Shot 2015-09-14 at 1.45.40 PM.png | |
| Sep 14 2015, 10:08 PM |
| F2604326: Screen Shot 2015-09-14 at 23.31.55.png | |
| Sep 14 2015, 9:52 PM |
| F2602552: echo messed up on firefox 3.5 | |
| Sep 14 2015, 5:49 PM |
The interface looks pretty messed up on firefox 3.5 right now on commons. See screenie
I appreciate that this isn't really a supported browser, but I think the interface should look "presentable" on pretty much anything.
Based on timing (It wasn't like this, this morning), I'd guess it might be related to https://gerrit.wikimedia.org/r/#/c/238160/ which was swatted today.
| Subject | Repo | Branch | Lines +/- | |
|---|---|---|---|---|
| Fallback for browsers that don't support Object.defineProperty | mediawiki/extensions/CentralNotice | master | +32 -5 | |
| Revert Echo to 1.26wmf21 version | mediawiki/core | wmf/1.26wmf22 | +1 -1 |
Note, I just noticed it doesn't appear on enwiki or enwikinews. It might be a local script or even a gadget...
Based on timing (It wasn't like this, this morning), I'd guess it might be related to https://gerrit.wikimedia.org/r/#/c/238160/ which was swatted today.
That seems unlikely, because we're still loading those styles (you can check with mw.loader.inspect()), they're just no longer in the top queue.
even with all my gadgets disabled (including default enabled gadgets), and user:Bawolff/common.js commented out, issue is still present.
Oh, I do have a bunch of errors (not sure why that isn't the first thing I looked at). Also, the top bar looks fine initially. Seems to get messed up after onready. Also, error does not happen when you do ?debug=true.
Exception in module-execute in module ext.centralNotice.display:
TypeError: Object.defineProperty is not a function TypeError: Object.defineProperty is not a function message=Object.defineProperty is not a function
Exception in store-localstorage-update:
[Exception... "Persistent storage maximum size reached" code: "1014" nsresult: "0x805303f6 (NS_ERROR_DOM_QUOTA_REACHED)" location: "https://commons.wikimedia.org/w/load.php?debug=false&lang=en&modules=jquery%2Cmediawiki&only=scripts&skin=vector&version=T5zOVd1J Line: 175"] [Exception... "Persistent storage maximum size reached" code: "1014" nsresult: "0x805303f6 (NS_ERROR_DOM_QUOTA_REACHED)" location: "https://commons.wikimedia.org/w/load.php?debug=false&lang=en&modules=jquery%2Cmediawiki&only=scripts&skin=vector&version=T5zOVd1J Line: 175"] code=1014 INDEX_SIZE_ERR=1 DOMSTRING_SIZE_ERR=2
https://kangax.github.io/compat-table/es5/#Object.defineProperty I guess they're not loading the es5-shim? Dunno if that would cause other things to stop loading...
Exception in store-localstorage-update:
[Exception... "Persistent storage maximum size reached" code: "1014" nsresult: "0x805303f6 (NS_ERROR_DOM_QUOTA_REACHED)" location: "https://commons.wikimedia.org/w/load.php?debug=false&lang=en&modules=jquery%2Cmediawiki&only=scripts&skin=vector&version=T5zOVd1J Line: 175"] [Exception... "Persistent storage maximum size reached" code: "1014" nsresult: "0x805303f6 (NS_ERROR_DOM_QUOTA_REACHED)" location: "https://commons.wikimedia.org/w/load.php?debug=false&lang=en&modules=jquery%2Cmediawiki&only=scripts&skin=vector&version=T5zOVd1J Line: 175"] code=1014 INDEX_SIZE_ERR=1 DOMSTRING_SIZE_ERR=2
T66721: mw.loader.store should not occupy all of localStorage.
I think the central notice thing is not related to causing this issue, as that error is on all sites, but things are only blowing up for me on commons.
@TheDJ and some other users are also seeing this: https://commons.wikimedia.org/wiki/Commons:Village_pump#HTML_rendering_issues_with_notifications_in_toolbar
Note that I and others are seeing rendering issues with the the notification icons on Commons in Safari which does support Object.defineProperty.
Change 238326 had a related patch set uploaded (by AndyRussG):
Fallback for browsers that don't support Object.defineProperty
Change 238371 had a related patch set uploaded (by Legoktm):
Revert Echo to 1.26wmf21 version
We reverted for now, but this is likely still an issue. Roan is looking into it now.
An issue that I think is related: simplesearch also doesn't display suggestions in Safari. Just like the Echo bug, this only happens in Commons, when logged in, in non-debug mode. The issue goes away if you log out or enable debug mode. Just like with Echo, it happens because the .suggestions { position: absolute; } rule isn't applied, so the list of suggestions is rendered off-screen.
<s>So far all I have to go on is that RL is creating many many more <style> tags in Safari than in Chrome.</s> Never mind, that's not actually true.
This was caused by bad CSS in MediaWiki:Vector.css. Should be fixed with https://commons.wikimedia.org/w/index.php?title=MediaWiki%3AVector.css&type=revision&diff=172090985&oldid=171972596
> document.styleSheets[2].ownerNode.textContent.substr(21600,300)
"px}.mw-special-Userlogin #mw-content-text #signupend{margin-left:50%}#siteSub{display:inline;font-size:92%}@media screen #siteSub{display:none} body.page-Main_Page.action-view #siteSub{display:none !important}body.page-Commons_Mobile_app_Download.action-view #siteSub,body.page-Commons_Mobile_app_Dow"
Note #siteSub { display:inline; font-size:92% } @media screen #siteSub{ display:none }. This is not valid CSS.
In Chrome, this only causes the first rule after @media screen to be ignored (which is still bad!):
> document.styleSheets[2].cssRules[257].cssText
"#siteSub { display: inline; font-size: 92%; }"
> document.styleSheets[2].cssRules[258].cssText
"@media not all {
}"
> document.styleSheets[2].cssRules[259].cssText
"body.page-Main_Page.action-view #siteSub { display: none !important; }"
Whereas in Safari, the CSS parser stopped completely:
> document.styleSheets[2].cssRules[257].cssText
"#siteSub { display: inline; font-size: 92%; }"
> document.styleSheets[2].cssRules[258].cssText
"@media {
}"
> document.styleSheets[2].cssRules[259].cssText
TypeError: undefined is not an object
Change 238326 merged by XenoRyet:
Fallback for browsers that don't support Object.defineProperty
Marking as resolved as Vector.css has been fixed on commons and upstream bugs have been filed with Safari.