Page MenuHomePhabricator
Create Task
Maniphest T143527

nds-nl is not consistently lowercased in compact language links
Closed, ResolvedPublic
Actions

Description

Dutch Low Saxon (nds-nl) is lowercased as a workaround for T139795.

However, the fix for T70071 introduced an inconsistency in this lowercasing, so if the link to nds-nl has a badge such as "featured", and this language is added to the compact list, it may produce a JS error in compactlinks.js line 85.

Details

Subject Repo Branch Lines +/-
Apply toLowerCase when reading featured articles mediawiki/extensions/UniversalLanguageSelector wmf/1.28.0-wmf.15 +1 -1
Apply toLowerCase when reading featured articles mediawiki/extensions/UniversalLanguageSelector master +1 -1
Customize query in gerrit

Related Objects

Event Timeline

Amire80 created this task.Aug 21 2016, 7:45 PM
Restricted Application added a project: UniversalLanguageSelector. · View Herald TranscriptAug 21 2016, 7:45 PM
Restricted Application added a subscriber: Aklapper. · View Herald Transcript
Amire80 claimed this task.Aug 21 2016, 7:46 PM
Amire80 triaged this task as High priority.
Amire80 added projects: Language-Q1-2016-17 Sprint 4, Unplanned-Sprint-Work.
Restricted Application added a project: Language-Engineering July-September 2016. · View Herald TranscriptAug 21 2016, 7:46 PM
gerritbot subscribed.Aug 21 2016, 7:47 PM

Change 305860 had a related patch set uploaded (by Amire80):
Apply toLowerCase when reading featured articles

https://gerrit.wikimedia.org/r/305860
gerritbot added a project: Patch-For-Review.Aug 21 2016, 7:47 PM
Amire80 moved this task from Backlog to In Review on the Language-Q1-2016-17 Sprint 4 board.Aug 21 2016, 7:48 PM
Amire80 moved this task from Backlog to ULS on the Language-Engineering July-September 2016 board.
gerritbot added a comment.Aug 22 2016, 5:09 AM

Change 305860 merged by jenkins-bot:
Apply toLowerCase when reading featured articles

https://gerrit.wikimedia.org/r/305860
gerritbot added a comment.Aug 22 2016, 5:25 AM

Change 305948 had a related patch set uploaded (by Amire80):
Apply toLowerCase when reading featured articles

https://gerrit.wikimedia.org/r/305948
ReleaseTaggerBot added a project: MW-1.28-release (WMF-deploy-2016-08-23_(1.28.0-wmf.16)).Aug 22 2016, 6:00 AM
Arrbee moved this task from In Review to Done on the Language-Q1-2016-17 Sprint 4 board.Aug 22 2016, 7:10 AM
gerritbot added a comment.Aug 22 2016, 12:44 PM

Change 305948 merged by jenkins-bot:
Apply toLowerCase when reading featured articles

https://gerrit.wikimedia.org/r/305948
ReleaseTaggerBot added a project: MW-1.28-release (WMF-deploy-2016-08-16_(1.28.0-wmf.15)).Aug 22 2016, 1:00 PM
Nikerabbit subscribed.Aug 22 2016, 1:11 PM

Example pages with the issue:
Stashbot subscribed.Aug 22 2016, 1:41 PM

Mentioned in SAL [2016-08-22T13:41:02Z] <dereckson@tin> Started scap: php-1.28.0-wmf.15/extensions/UniversalLanguageSelector / resources/js/ext.uls.compactlinks.js Apply toLowerCase when reading featured articles (T143527)
Stashbot added a comment.Aug 22 2016, 1:41 PM

Mentioned in SAL [2016-08-22T13:41:06Z] <dereckson@tin> scap aborted: php-1.28.0-wmf.15/extensions/UniversalLanguageSelector / resources/js/ext.uls.compactlinks.js Apply toLowerCase when reading featured articles (T143527) (duration: 00m 04s)
Stashbot added a comment.Aug 22 2016, 1:42 PM

Mentioned in SAL [2016-08-22T13:42:15Z] <dereckson@tin> Synchronized php-1.28.0-wmf.15/extensions/UniversalLanguageSelector/resources/js/ext.uls.compactlinks.js: Apply toLowerCase when reading featured articles (T143527) (duration: 00m 50s)
Nikerabbit closed this task as Resolved.Aug 22 2016, 1:55 PM
Amire80 added a comment.Aug 22 2016, 2:06 PM

Deployed, verified in production.
Nikerabbit mentioned this in T143867: Compact language links broken in https://es.wikipedia.org/wiki/Luna.Aug 25 2016, 8:23 AM
Nikerabbit removed a project: Patch-For-Review.Aug 30 2016, 7:05 AM
Amire80 moved this task from Backlog to Language codes issues on the UniversalLanguageSelector board.Nov 1 2017, 2:54 PM
Amire80 moved this task from Backlog to Missing languages on the ULS-CompactLinks board.Nov 3 2017, 8:24 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL