Page MenuHomePhabricator
Create Task
Maniphest T165112

Kill of most/all the WikiEditor RL modules
Closed, ResolvedPublic1 Estimated Story Points
Actions

Description

Almost all of them are loaded by default; "ext.wikiEditor" should just be it, I'd have thought?

jquery.wikiEditor.core
jquery.wikiEditor.dialogs
jquery.wikiEditor.dialogs.config
jquery.wikiEditor.toolbar
jquery.wikiEditor.toolbar.config
jquery.wikiEditor.toolbar.i18n
ext.wikiEditor
ext.wikiEditor.core
ext.wikiEditor.dialogs
ext.wikiEditor.styles
ext.wikiEditor.toolbar

Details

Subject Repo Branch Lines +/-
Remove deprecated ext.wikiEditor module aliases mediawiki/extensions/WikiEditor master +0 -40
Merge all the non-styles-only ResourceLoader modules into one mediawiki/extensions/WikiEditor master +60 -123
Follow-up I51745e8: Make all old modules aliases of 'ext.wikiEditor' mediawiki/extensions/WikiEditor master +30 -9
Customize query in gerrit

Related Objects
Search...

Event Timeline

Jdforrester-WMF created this task.May 11 2017, 11:47 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMay 11 2017, 11:47 PM
Paladox subscribed.May 12 2017, 12:04 AM
Jdforrester-WMF moved this task from To Triage to TR1: Releases on the VisualEditor board.May 15 2017, 10:36 AM
TheDJ subscribed.May 15 2017, 10:56 AM

note that CodeEditor does not load all of them.
Jdforrester-WMF added a comment.May 15 2017, 11:04 AM
In T165112#3262499, @TheDJ wrote:

note that CodeEditor does not load all of them.

CodeEditor shouldn't load any of them, but that's a different task. :-(
gerritbot subscribed.Nov 22 2017, 8:18 PM

Change 392902 had a related patch set uploaded (by Jforrester; owner: Jforrester):
[mediawiki/extensions/WikiEditor@master] Merge all the non-styles-only ResourceLoader modules into one

https://gerrit.wikimedia.org/r/392902
gerritbot added a project: Patch-For-Review.Nov 22 2017, 8:18 PM
Krinkle added a parent task: T159911: Audit modules (2017).Nov 22 2017, 8:28 PM
Krinkle added a parent task: T171093: Performance review of Editing features.Nov 22 2017, 8:33 PM
gerritbot added a comment.Jan 2 2018, 9:45 PM

Change 392902 merged by jenkins-bot:
[mediawiki/extensions/WikiEditor@master] Merge all the non-styles-only ResourceLoader modules into one

https://gerrit.wikimedia.org/r/392902
ReleaseTaggerBot added a project: MW-1.31-release-notes (WMF-deploy-2018-01-09 (1.31.0-wmf.16)).Jan 2 2018, 10:00 PM
• Deskana subscribed.Jan 4 2018, 11:43 AM

Does the above patch resolve this task?
gerritbot added a comment.Jan 4 2018, 12:02 PM

Change 402025 had a related patch set uploaded (by Esanders; owner: Esanders):
[mediawiki/extensions/WikiEditor@master] Follow-up I51745e8: Make all old modules aliases of 'ext.wikiEditor'

https://gerrit.wikimedia.org/r/402025
Esanders subscribed.Jan 4 2018, 12:02 PM

Many of these are used in the wild by user scripts, so I've re-added them as aliases. We should do an mwgrep after this has been deployed so they can eventually be killed off.
gerritbot added a comment.Jan 4 2018, 3:56 PM

Change 402025 merged by jenkins-bot:
[mediawiki/extensions/WikiEditor@master] Follow-up I51745e8: Make all old modules aliases of 'ext.wikiEditor'

https://gerrit.wikimedia.org/r/402025
Jdforrester-WMF added a comment.Jan 4 2018, 4:08 PM

Added the deprecation to Tech/News. Will create a task for that.
Jdforrester-WMF closed this task as Resolved.Jan 4 2018, 4:11 PM
Jdforrester-WMF claimed this task.
Jdforrester-WMF removed a project: Patch-For-Review.

Follow-up in T184194: Remove deprecated ResourceLoader alias modules for WikiEditor.
Restricted Application added a project: User-Ryasmeen. · View Herald TranscriptJan 4 2018, 4:11 PM
Liuxinyu970226 added a project: User-notice.Jan 5 2018, 4:48 AM
Liuxinyu970226 moved this task from To Triage to In current Tech/News draft on the User-notice board.
He7d3r subscribed.Jan 8 2018, 4:36 PM
He7d3r added a comment.EditedJan 8 2018, 4:49 PM

Could you check if the documentation¹ is up to date? (maybe such an update would help fixing the existing race condition²)

¹ https://www.mediawiki.org/w/index.php?title=Extension:WikiEditor/Toolbar_customization&oldid=2543258#Basic_setup
² https://www.mediawiki.org/wiki/Extension_talk:WikiEditor/Toolbar_customization?diff=2674204
Jack_who_built_the_house subscribed.Jan 8 2018, 9:24 PM
Billinghurst subscribed.Jan 9 2018, 12:24 AM
In T165112#3874915, @Esanders wrote:

Many of these are used in the wild by user scripts, so I've re-added them as aliases. We should do an mwgrep after this has been deployed so they can eventually be killed off.

Is this a simple text replacement? ie. all instances of commands in the list in the description above to be replaced with ext.wikiEditor
Jdforrester-WMF added a comment.Jan 9 2018, 12:26 AM
In T165112#3885172, @Billinghurst wrote:
In T165112#3874915, @Esanders wrote:

Many of these are used in the wild by user scripts, so I've re-added them as aliases. We should do an mwgrep after this has been deployed so they can eventually be killed off.

Is this a simple text replacement? ie. all instances of commands in the list in the description above to be replaced with ext.wikiEditor

Yes, though if there's duplicates after that they should be merged. Follow-up is in T184194: Remove deprecated ResourceLoader alias modules for WikiEditor.
RandomDSdevel awarded a token.Jan 9 2018, 1:44 AM
Johan moved this task from In current Tech/News draft to Already announced/Archive on the User-notice board.Jan 11 2018, 4:12 AM
Jdforrester-WMF removed a subtask: T185143: $.wikiEditor.isSupported() gone away without notice.Jan 17 2018, 10:36 PM
eranroz mentioned this in T185555: Preview tab has disappeared.Jan 24 2018, 7:58 AM
TheDJ mentioned this in T25942: "Find and Replace" is missing when "Enable dialogs for inserting links, tables and more" is not checked.Nov 13 2018, 2:09 PM
TheDJ mentioned this in T32796: "Enable dialogs for inserting links, tables and more" preference is confusing.Nov 13 2018, 4:21 PM
TheDJ mentioned this in T166857: The globe in WikiEditor disappears when loading is finished.Nov 13 2018, 5:24 PM
TheDJ mentioned this in T189029: WikiEditor toolbar shown twice on editing posts in threads.Nov 14 2018, 10:40 AM
TheDJ mentioned this in T36602: Loading ext.wikieditor.toolbar should not initialize it.Nov 16 2018, 9:25 PM
Jdforrester-WMF moved this task from Next-up to Closed on the WikiEditor board.Dec 1 2018, 12:06 AM
Krinkle mentioned this in T202154: Audit modules 2018: Reduce registry overhead.Jan 19 2019, 2:22 AM
gerritbot added a comment.Jan 19 2019, 2:24 AM

Change 485355 had a related patch set uploaded (by Krinkle; owner: Krinkle):
[mediawiki/extensions/WikiEditor@master] Remove deprecated ext.wikiEditor module aliases

https://gerrit.wikimedia.org/r/485355
gerritbot added a project: Patch-For-Review.Jan 19 2019, 2:24 AM
gerritbot added a comment.Jan 22 2019, 9:57 PM

Change 485355 merged by jenkins-bot:
[mediawiki/extensions/WikiEditor@master] Remove deprecated ext.wikiEditor module aliases

https://gerrit.wikimedia.org/r/485355
Krinkle mentioned this in T184194: Remove deprecated ResourceLoader alias modules for WikiEditor.Sep 17 2019, 2:41 AM
Maintenance_bot removed a project: Patch-For-Review.Sep 17 2019, 3:10 AM
Ladsgroup edited projects, added User-notice-archive; removed User-notice.Aug 13 2022, 1:54 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL