Page MenuHomePhabricator

Automatic edit summaries should be filtered as tags
Closed, ResolvedPublic

Description

Some wikis define Automatic edit summaries, triggered by Mediawiki. They are apparently different from the tags.

English WIkipedia defines those AESs:

  • Blanking a page
  • Replacing entire page with other text
  • Creating a new page (the first 200 characters of the article appear in the summary)
  • Creating a redirect
  • Reverting a revision

A filter for those special actions should be provided, as tags. (Original suggestion)

Event Timeline

Restricted Application added a subscriber: Aklapper. · View Herald Transcript

I know there is a “page blanking” tag. How is this different? Could the others be tags?

I know there is a “page blanking” tag. How is this different? Could the others be tags?

That tag is added by an AbuseFilter, which has to be set up manually on each wiki (although I heard we have global AFs now, is that true?).

I think it makes a lot of sense to add tags whenever we add automatic edit summaries, so that we can obviate some of these AbuseFilters.

  • Creating a new page (the first 200 characters of the article appear in the summary)

There's no point making a tag for this particular one, because there's already a filter that distinguishes new page creations from page edits.

Things we should tag:

  • Blanking
  • Removing nearly all content
  • Making a page a redirect (either redirect creation or editing an existing page)
  • Undo
  • Rollback

We don't need to tag page creations because they are already special. Creating blank pages can just be new+blank.

Change 390224 had a related patch set uploaded (by Petar.petkovic; owner: Petar.petkovic):
[mediawiki/core@master] [WIP] Add new core tags

https://gerrit.wikimedia.org/r/390224

In T167656#3747314, @TTO wrote:

It overlaps with it but not completely. This will make some of the things from that task (e.g. making a redirect) get tagged automatically, but not others (e.g. un-redirecting a page).

The submitted patch adds core tagging to following types of edits:

  • Making a page a redirect
  • Blanking of the page
  • Removing nearly all (more than 90%) content
  • Rolling back an edit

With already existing core tag:

  • Changing content model of the page

Other things we could tag, which are mostly proposed as part of other tickets:

  • Further separation of redirect tags to un-redirecting, new redirect, changed redirect target, self redirect, redirect to non-existent page, etc. (Probably an overkill)
  • Disambiguation pages
  • Moving across namespaces
  • Implement Translate extension changes with tags - T159795: Port Translate to new RC Filters system

Further separation of redirect tags to un-redirecting, new redirect, changed redirect target, self redirect, redirect to non-existent page, etc. (Probably an overkill)

Having a tag that means "new redirect, or changed existing page to a redirect, or changed the target of an existing redirect" seems like underkill. At the very least, I'd say split "new redirect, or changed existing page to a redirect" from "changed the target of an existing redirect". I don't know if this RC Filters system would allow patrollers to combine "new page" and "new redirect, or changed existing page to a redirect" to differentiate those two cases.

Patrollers would probably also like to have a tag for un-redirecting, unless this RC Filters system already somehow makes it possible to filter for those or include them in actual new page creations.

I don't know if this RC Filters system would allow patrollers to combine "new page" and "new redirect, or changed existing page to a redirect" to differentiate those two cases.

Yes it would. You can ask for "new page creations with tag X", and you can do a union on tags (i.e. "things with tag X or tag Y"). What you can't do is an intersection on tags ("things with tag X and tag Y").

Patrollers would probably also like to have a tag for un-redirecting, unless this RC Filters system already somehow makes it possible to filter for those or include them in actual new page creations.

We don't have a facility for "things that do not have tag X" right now, so I don't think you could target un-redirecting edits without a tag.

We don't have a facility for "things that do not have tag X" right now, so I don't think you could target un-redirecting edits without a tag.

This raises the need of an exclude tag for any tag.

In T167656#3747314, @TTO wrote:

When the question about duplication was asked, @Catrope answered with:

It overlaps with it but not completely. This will make some of the things from that task (e.g. making a redirect) get tagged automatically, but not others (e.g. un-redirecting a page).

which was quite true at the time of posting the response, but latest patch sets changed how redirects are tagged.
As it stands now, redirects are distinguished into separate types:

  • Making a page a redirect (Either by creating new redirect page or converting existing non-redirect page)
  • Changing redirect target
  • Changing an existing redirect into a non-redirect

Reading the description of T73236, one nice-to-have type of redirects is mentioned, that my patch is not tagging:

When a redirect is edited without changing the redirect (like for example adding a category, a comment, or simply content that won't be viewed anyway).

If we don't change the current behavior of redirect tagging, I suggest we close T177281 and T73236 as duplicates.

Just because one patch fixes multiple bugs doesn't mean those bugs are duplicates.

Change 390224 merged by jenkins-bot:
[mediawiki/core@master] Add new core tags

https://gerrit.wikimedia.org/r/390224

@Petar.petkovic : @Catrope wrote

Things we should tag:

Blanking
Removing nearly all content
Making a page a redirect (either redirect creation or editing an existing page)
Undo
Rollback

I verified that the fix works for (per your comment)

The submitted patch adds core tagging to following types of edits:
Making a page a redirect
Blanking of the page
Removing nearly all (more than 90%) content
Rolling back an edit

but it does not work for Undo - in the screenshot below shows no tags added to Undo action, only AES.

Screen Shot 2017-12-01 at 1.16.31 PM.png (86×894 px, 41 KB)

Note:
Reverting a revision is defined in Help:Automatic edit summaries as Rollback or Undo.

Maybe not adding a tag to 'Undo' action was discussed somewhere and I missed it?

Change 395744 had a related patch set uploaded (by Petar.petkovic; owner: Petar.petkovic):
[mediawiki/core@master] Add tags for undo edits

https://gerrit.wikimedia.org/r/395744

do we plan to review that task soon (to know it I include them to the report and the newsletter)?

Change 395744 merged by Nikerabbit:
[mediawiki/core@master] Add tags for undo edits

https://gerrit.wikimedia.org/r/395744

do we plan to review that task soon (to know it I include them to the report and the newsletter)?

Sorry, I wasn't able to provide such info, as I was the one submitting the patch and the reviews were slow. The patch is merged now.

Checked in betalabs - Tag: Undo is added for revisions that were undone.