Page MenuHomePhabricator
Create Task
Maniphest T188132

Merge image_comment_temp table into the image table
Closed, ResolvedPublic
Actions

Description

The image_comment_temp table was created to temporarily hold the new fields needed for T166732: Refactor comment storage in the database and abstract access in MediaWiki so it wouldn't have to be held up waiting for an expensive schema change on Commons' image table. The plan was always to eventually merge it into the image table once we had time to do that schema change.

Thanks to T187089, that image schema change is happening sooner than we had thought.

The rough plan here is:

  • Write (and merge) the patch to add the img_descrption_id field to the image table, and the maintenance code to migrate data from image_comment_temp to image, and the changes to CommentStore to
  • Actually perform the schema change on WMF sites (already in progress, see T187089)
  • Configuration changes to start writing img_description_id.
  • Run the maintenance.
  • Write (and merge) the patch to drop the image_comment_temp table and the code in CommentStore for using it.

Details

Subject Repo Branch Lines +/-
Drop img_description from CommentStore temp table list mediawiki/core master +5 -17
Drop the image_comment_temp table mediawiki/core REL1_32 +35 -124
Drop the image_comment_temp table mediawiki/core master +35 -121
Migrate image descriptions from image_comment_temp mediawiki/core master +291 -96
DB: Add img_description_id column mediawiki/core master +97 -5
Customize query in gerrit

Related Objects
Search...

Event Timeline

Anomie created this task.Feb 23 2018, 7:33 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptFeb 23 2018, 7:33 PM
Anomie moved this task from Inbox to MWPT-Q3-Jan-Mar-2018 on the MediaWiki-Platform-Team-Archived board.Feb 26 2018, 1:58 PM
Anomie edited projects, added MediaWiki-Platform-Team-Archived (MWPT-Q3-Jan-Mar-2018); removed MediaWiki-Platform-Team-Archived.
Anomie moved this task from Ready to In Progress on the MediaWiki-Platform-Team-Archived (MWPT-Q3-Jan-Mar-2018) board.
gerritbot subscribed.Mar 7 2018, 9:19 PM

Change 417039 had a related patch set uploaded (by Anomie; owner: Anomie):
[mediawiki/core@master] DB: Add img_description_id column

https://gerrit.wikimedia.org/r/417039
gerritbot added a project: Patch-For-Review.Mar 7 2018, 9:19 PM

Change 417040 had a related patch set uploaded (by Anomie; owner: Anomie):
[mediawiki/core@master] Migrate image descriptions from image_comment_temp

https://gerrit.wikimedia.org/r/417040
gerritbot added a comment.Mar 7 2018, 9:19 PM

Change 417041 had a related patch set uploaded (by Anomie; owner: Anomie):
[mediawiki/core@master] Drop the image_comment_temp table

https://gerrit.wikimedia.org/r/417041
gerritbot added a comment.Apr 3 2018, 1:18 AM

Change 417039 merged by jenkins-bot:
[mediawiki/core@master] DB: Add img_description_id column

https://gerrit.wikimedia.org/r/417039
Anomie moved this task from In Progress to Blocked on the MediaWiki-Platform-Team-Archived (MWPT-Q3-Jan-Mar-2018) board.Apr 3 2018, 1:40 AM
ReleaseTaggerBot added a project: MW-1.31-release-notes (WMF-deploy-2018-04-03 (1.31.0-wmf.28)).Apr 3 2018, 2:00 AM
CCicalese_WMF edited projects, added MediaWiki-Platform-Team-Archived (MWPT-Q4-Apr-Jun-2018); removed MediaWiki-Platform-Team-Archived (MWPT-Q3-Jan-Mar-2018).Apr 4 2018, 7:00 PM
CCicalese_WMF moved this task from Ready to Blocked on the MediaWiki-Platform-Team-Archived (MWPT-Q4-Apr-Jun-2018) board.
Krinkle moved this task from Untriaged to Schema changes on the MediaWiki-libs-Rdbms board.Apr 10 2018, 3:42 PM
CCicalese_WMF edited projects, added Core-Platform-Team-Old (CPT-Q1-Jul-Sep-2018); removed MediaWiki-Platform-Team-Archived (MWPT-Q4-Apr-Jun-2018).Jul 11 2018, 9:31 PM
CCicalese_WMF moved this task from Backlog to Blocked on the Core-Platform-Team-Old (CPT-Q1-Jul-Sep-2018) board.
Jdforrester-WMF added a subtask: T187089: Fix WMF schemas to not break when comment store goes WRITE_NEW.Aug 29 2018, 8:34 PM
Marostegui changed the status of subtask T187089: Fix WMF schemas to not break when comment store goes WRITE_NEW from Stalled to Open.Sep 13 2018, 8:36 AM
Marostegui closed subtask T187089: Fix WMF schemas to not break when comment store goes WRITE_NEW as Resolved.Sep 17 2018, 12:56 PM
Jdforrester-WMF subscribed.Sep 17 2018, 4:17 PM
CCicalese_WMF edited projects, added Platform Team Legacy (Designing); removed Core-Platform-Team-Old (CPT-Q1-Jul-Sep-2018).Oct 1 2018, 1:24 PM
CCicalese_WMF moved this task from Inbox to Blocked Externally on the Platform Team Legacy (Designing) board.
CCicalese_WMF added a project: Platform Engineering.Oct 2 2018, 2:24 PM
gerritbot added a comment.Oct 3 2018, 1:23 AM

Change 417040 merged by jenkins-bot:
[mediawiki/core@master] Migrate image descriptions from image_comment_temp

https://gerrit.wikimedia.org/r/417040
Restricted Application edited projects, added Platform Team Legacy; removed Platform Team Legacy (Designing). · View Herald TranscriptOct 3 2018, 1:23 AM
ReleaseTaggerBot added a project: MW-1.32-notes (WMF-deploy-2018-10-16 (1.32.0-wmf.26)).Oct 3 2018, 2:00 AM
CCicalese_WMF edited projects, added Platform Team Legacy (Designing), Platform Engineering (Needs Cleaning - Code Health (TEC13)); removed Platform Team Legacy, Platform Engineering.Oct 3 2018, 1:40 PM
Anomie removed a project: Patch-For-Review.Oct 3 2018, 3:58 PM
Anomie updated the task description. (Show Details)
CCicalese_WMF edited projects, added Platform Team Workboards (Blocked Externally); removed Platform Team Legacy (Designing).Oct 14 2018, 3:49 PM
Stashbot subscribed.Oct 30 2018, 3:16 PM

Mentioned in SAL (#wikimedia-operations) [2018-10-30T15:16:33Z] <anomie> Running migrateImageCommentTemp.php on test wikis and mediawikiwiki for T188132
Stashbot added a comment.Oct 31 2018, 2:22 PM

Mentioned in SAL (#wikimedia-operations) [2018-10-31T14:22:41Z] <anomie@mwmaint1002> Running migrateImageCommentTemp.php on group0 for T188132
Stashbot added a comment.Nov 1 2018, 1:35 PM

Mentioned in SAL (#wikimedia-operations) [2018-11-01T13:35:31Z] <anomie@mwmaint1002> Running migrateImageCommentTemp.php on section 1 wikis for T188132
Stashbot added a comment.Nov 1 2018, 1:36 PM

Mentioned in SAL (#wikimedia-operations) [2018-11-01T13:36:05Z] <anomie@mwmaint1002> Running migrateImageCommentTemp.php on section 2 wikis for T188132
Stashbot added a comment.Nov 1 2018, 1:36 PM

Mentioned in SAL (#wikimedia-operations) [2018-11-01T13:36:19Z] <anomie@mwmaint1002> Running migrateImageCommentTemp.php on remaining section 3 wikis for T188132
Stashbot added a comment.Nov 1 2018, 1:36 PM

Mentioned in SAL (#wikimedia-operations) [2018-11-01T13:36:33Z] <anomie@mwmaint1002> Running migrateImageCommentTemp.php on section 4 wikis for T188132
Stashbot added a comment.Nov 1 2018, 1:36 PM

Mentioned in SAL (#wikimedia-operations) [2018-11-01T13:36:43Z] <anomie@mwmaint1002> Running migrateImageCommentTemp.php on section 5 wikis for T188132
Stashbot added a comment.Nov 1 2018, 1:37 PM

Mentioned in SAL (#wikimedia-operations) [2018-11-01T13:37:04Z] <anomie@mwmaint1002> Running migrateImageCommentTemp.php on section 6 wikis for T188132
Stashbot added a comment.Nov 1 2018, 1:37 PM

Mentioned in SAL (#wikimedia-operations) [2018-11-01T13:37:16Z] <anomie@mwmaint1002> Running migrateImageCommentTemp.php on section 7 wikis for T188132
Stashbot added a comment.Nov 1 2018, 1:37 PM

Mentioned in SAL (#wikimedia-operations) [2018-11-01T13:37:25Z] <anomie@mwmaint1002> Running migrateImageCommentTemp.php on section 8 wikis for T188132
Stashbot added a comment.Nov 1 2018, 1:37 PM

Mentioned in SAL (#wikimedia-operations) [2018-11-01T13:37:42Z] <anomie@mwmaint1002> Running migrateImageCommentTemp.php on wikitech for T188132
Anomie updated the task description. (Show Details)Nov 1 2018, 4:09 PM
Anomie updated the task description. (Show Details)
• Niedzielski mentioned this in T208909: [Bug] Update old nonuniformly distributed page_random values.Nov 8 2018, 8:31 PM
Anomie mentioned this in T166733: Deploy refactored comment storage.Nov 12 2018, 4:31 PM
• Bstorm closed subtask T189158: Change `image` view to properly expose the new `img_description_id` field as Resolved.Nov 14 2018, 7:58 PM
Anomie updated the task description. (Show Details)Nov 14 2018, 8:10 PM
gerritbot added a comment.Nov 15 2018, 4:48 AM

Change 417041 merged by jenkins-bot:
[mediawiki/core@master] Drop the image_comment_temp table

https://gerrit.wikimedia.org/r/417041
ReleaseTaggerBot added a project: MW-1.33-notes (1.33.0-wmf.6; 2018-11-27).Nov 15 2018, 5:00 AM
Anomie closed this task as Resolved.Nov 15 2018, 2:37 PM
Anomie updated the task description. (Show Details)

I'm going to file the schema change as a separate task, but not keep this one open waiting on it.
Anomie added a subtask: T209591: Drop table image_comment_temp on all wikis.Nov 15 2018, 2:43 PM
Jdforrester-WMF changed the status of subtask T209591: Drop table image_comment_temp on all wikis from Open to Stalled.Nov 15 2018, 3:48 PM
gerritbot added a comment.Nov 15 2018, 4:35 PM

Change 473776 had a related patch set uploaded (by Jforrester; owner: Anomie):
[mediawiki/core@REL1_32] Drop the image_comment_temp table

https://gerrit.wikimedia.org/r/473776
gerritbot added a project: Patch-For-Review.Nov 15 2018, 4:35 PM
gerritbot added a comment.Nov 21 2018, 12:46 AM

Change 473776 merged by jenkins-bot:
[mediawiki/core@REL1_32] Drop the image_comment_temp table

https://gerrit.wikimedia.org/r/473776
ReleaseTaggerBot edited projects, added MW-1.32-notes; removed MW-1.32-notes (WMF-deploy-2018-10-16 (1.32.0-wmf.26)).Nov 21 2018, 1:00 AM
Anomie changed the status of subtask T209591: Drop table image_comment_temp on all wikis from Stalled to Open.Dec 3 2018, 2:56 PM
CCicalese_WMF moved this task from Blocked Externally to Done with CPT on the Platform Team Workboards board.Dec 13 2018, 8:09 PM
CCicalese_WMF edited projects, added Platform Team Workboards (Done with CPT); removed Platform Team Workboards (Blocked Externally).
Marostegui closed subtask T209591: Drop table image_comment_temp on all wikis as Resolved.Dec 19 2018, 1:31 PM
Reedy mentioned this in T241686: Wikimedia\Rdbms\DBQueryError when upgrading from MediaWiki 1.31.2 to 1.31.6.Jan 1 2020, 7:40 PM
Maintenance_bot removed a project: Patch-For-Review.Jan 1 2020, 8:10 PM
Aklapper removed a subscriber: Anomie.Oct 16 2020, 5:39 PM
PleaseStand mentioned this in T188336: Error in file upload via API on Russian Wikivoyage: CommentStore::insertInternal Error: 1062 Duplicate entry for key 'PRIMARY'.Aug 4 2022, 10:41 AM
gerritbot added a comment.Dec 31 2022, 12:34 AM

Change 873884 had a related patch set uploaded (by Zabe; author: Zabe):

[mediawiki/core@master] Drop img_description from CommentStore temp table list

https://gerrit.wikimedia.org/r/873884
Restricted Application added a project: Performance-Team. · View Herald TranscriptDec 31 2022, 12:34 AM
gerritbot added a project: Patch-For-Review.Dec 31 2022, 12:34 AM
Zabe subscribed.Dec 31 2022, 12:35 AM
gerritbot added a comment.Jan 1 2023, 8:43 PM

Change 873884 merged by jenkins-bot:

[mediawiki/core@master] Drop img_description from CommentStore temp table list

https://gerrit.wikimedia.org/r/873884
ReleaseTaggerBot added a project: MW-1.40-notes (1.40.0-wmf.17; 2023-01-02).Jan 1 2023, 9:00 PM
Maintenance_bot removed a project: Patch-For-Review.Jan 1 2023, 9:30 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL