Page MenuHomePhabricator
Create Task
Maniphest T210553

Deploy page issues to all wikipedias (except enwiki)
Closed, ResolvedPublic2 Estimated Story Points
Actions

Assigned To
• alexhollender_WMF
Authored By
ovasileva
Nov 27 2018, 10:17 PM
Tags
Referenced Files
F26267398: ru.m.wikipedia.org_wiki_%D0%A1%D0%BF%D0%B8%D1%81%D0%BE%D0%BA_%D0%B7%D0%B0%D1%81%D0%BB%D1%83%D0%B6%D0%B5%D0%BD%D0%BD%D1%8B%D1%85_%D0%BC%D0%B0%D1%81%D1%82%D0%B5%D1%80%D0%BE%D0%B2_%D1%81%D0%BF%D0%BE%D1%80%D1%82%D0%B0_%D0%A0%D0%BE%D1%81%D1%81%D.png
Dec 17 2018, 7:50 PM
F26267387: ru.m.wikipedia.org_wiki_%D0%A0%D0%BE%D1%81%D1%82%D0%BE%D0%B2%D1%89%D0%B8%D1%87%D0%B5%D1%81%D1%82%D0%B2%D0%BE_useskin=minerva&minerva-issues=b(iPhone 6_7_8).png
Dec 17 2018, 7:50 PM
F26267492: zh.m.wikipedia.org_wiki_%E8%A2%81%E4%B8%96%E5%87%AF_useskin=minerva&minerva-issues=b(iPhone 6_7_8).png
Dec 17 2018, 7:50 PM
F26267516: zh.m.wikipedia.org_wiki_%E4%B8%AD%E5%8C%BB%E5%AD%A6_useskin=minerva&minerva-issues=b(iPhone 6_7_8).png
Dec 17 2018, 7:50 PM
F26267599: pl.m.wikipedia.org_wiki_Ustawa_useskin=minerva&minerva-issues=b(iPhone 6_7_8).png
Dec 17 2018, 7:50 PM
F26267625: pl.m.wikipedia.org_wiki_Szyna_(profil)_useskin=minerva&minerva-issues=b(iPhone 6_7_8).png
Dec 17 2018, 7:50 PM
F26267564: pt.m.wikipedia.org_wiki_Papel-travesti_useskin=minerva&minerva-issues=b(iPhone 6_7_8).png
Dec 17 2018, 7:50 PM
F26267410: ru.m.wikipedia.org_wiki_%D0%92%D1%82%D0%BE%D1%80%D0%B0%D1%8F_%D0%BC%D0%B8%D1%80%D0%BE%D0%B2%D0%B0%D1%8F_%D0%B2%D0%BE%D0%B9%D0%BD%D0%B0_useskin=minerva&minerva-issues=b(iPhone 6_7_8).png
Dec 17 2018, 7:50 PM
View All 21 Files
Subscribers
AfroThundr3007730
Aklapper
• alexhollender_WMF
Dereckson
gerritbot
Jdlrobson
• nray
View All 12 Subscribers
Tokens
"Party Time" token, awarded by RandomDSdevel."Mountain of Wealth" token, awarded by phuedx.

Description

NOTE: this is currently scheduled for December 17, 2018

Background

We will be deploying the page issues feature to all wikipedias but enwiki (due to annual fundraiser). The changes to page issue warnings will only appear on certain ambox templates and the visual design may vary based on the templates used on the local wikis.

Acceptance criteria

  • Ensure all direct subtasks are resolved
  • Deploy the page issues feature to 100% of users on all wikipedias except enwiki

Developer notes

$wgMinervaPageIssuesNewTreatment = [
        "base" => true,
        "beta" => true,
];

Details

Subject Repo Branch Lines +/-
Page issues treatment enabled on all wikis except enwiki operations/mediawiki-config master +12 -0
Customize query in gerrit

Related Objects
Search...

Status Subtype Assigned Task
Resolved Jdlrobson T147641 [EPIC] Improve top of the article user experience - mobile
Resolved Jdlrobson T143535 [EPIC] Improve article notes
Resolved ovasileva T159262 [EPIC] Improve page issues
Resolved • alexhollender_WMF T210553 Deploy page issues to all wikipedias (except enwiki)
Resolved ovasileva T200794 Analyze results of page issues A/B test
Resolved phuedx T200793 Disable page issues A/B test
Resolved • Tbayer T200792 [EPIC] Run A/B test on page issues (Farsi, Japanese, Russian, English)
Resolved ovasileva T191532 Mobile page issues - instrument page issues
Resolved • Niedzielski T201124 Provide standard/reproducible way to access a PageToken
Resolved • Tbayer T202098 Log sectionNumbers in PageIssues schema
Resolved • Tbayer T202651 Section number in issues is reported incorrectly.
Resolved • Tbayer T202940 [subtask] Various page issues events sending NaN for sectionNumbers in old treatment
Resolved • Tbayer T203050 sectionNumbers and issuesSeverity should always be consistent in length
Resolved ovasileva T202786 [subtask] Edits via the main edit icon are not triggering Schema:Edit or Schema:PageIssues events
Resolved • Tbayer T203725 Icon correct but issuesSeverity in instrumentation is wrong
Resolved phuedx T193584 Prepare feature flagging gateway for mobile issues work
Resolved ovasileva T198113 QA mobile page issues modal
Resolved Jdlrobson T203802 Latvian Wikipedia amboxes should be compatible with Minerva's
Resolved Jdlrobson T204144 ReadingDepth sometimes initialises before PageIssues leading to incorrect or missing ReadingDepth events
Resolved • Tbayer T204143 ReadingDepth events are not being sent in browsers where navigator.sendBeacon should be supported but in practice isn't
Resolved • Tbayer T204609 Turn on page issues A/B test for Latvian Wikipedia, and conduct data checks
Resolved • Niedzielski T205355 A/B config flag should be subject to ResourceLoader caching rules not HTML caching rules
Declined None T204613 Turn A/B test for page issues on for test projects at low rates to validate instrumentation
Resolved ovasileva T204090 QA page issues feature
Duplicate None T201975 Make page issue and hatnote classes names configurable so we are not English-Wikipedia centric
Resolved • Niedzielski T211257 Split pageIssues.js into smaller functions

Event Timeline

ovasileva triaged this task as Medium priority.Nov 27 2018, 10:17 PM
ovasileva created this task.
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptNov 27 2018, 10:17 PM
ovasileva renamed this task from Deploy page issues to all wikis but enwiki to Deploy page issues to all wikis (except enwiki).Nov 27 2018, 10:18 PM
ovasileva added a subtask: T200794: Analyze results of page issues A/B test.
ovasileva updated the task description. (Show Details)
ovasileva added a subtask: T201975: Make page issue and hatnote classes names configurable so we are not English-Wikipedia centric.Nov 27 2018, 10:20 PM
ovasileva added a subtask: T202349: When a page has multiple issue boxes but doesn't use multiple issues template, the icon is shared across all issues boxes..Nov 27 2018, 10:22 PM
ovasileva moved this task from Incoming to Upcoming on the Web-Team-Backlog board.Nov 27 2018, 10:24 PM
ovasileva updated the task description. (Show Details)
ovasileva raised the priority of this task from Medium to High.Dec 4 2018, 5:05 PM
ovasileva updated the task description. (Show Details)
ovasileva updated the task description. (Show Details)Dec 4 2018, 5:18 PM
phuedx subscribed.Dec 4 2018, 5:18 PM

Changes that were made to enable the A/B test:
ovasileva added a comment.Dec 4 2018, 5:22 PM

@ovasileva to add test links
phuedx added a subscriber: pmiazga.Dec 4 2018, 5:22 PM

@pmiazga also points out that $wgMinervaPageIssuesNewTreatment = true; needs to be set everywhere too (unless it already is 🤔).
ovasileva set the point value for this task to 2.Dec 4 2018, 5:22 PM
• Tbayer subscribed.Dec 4 2018, 5:24 PM
Jdlrobson changed the status of subtask T202349: When a page has multiple issue boxes but doesn't use multiple issues template, the icon is shared across all issues boxes. from Open to Stalled.Dec 11 2018, 8:11 PM
Jdlrobson added a subtask: T211257: Split pageIssues.js into smaller functions.Dec 13 2018, 12:51 AM
Jdlrobson subscribed.

Ensure all subtasks are resolved (except T202349 and T204143

T211257 and T200794 remain unresolved so this is blocked on those.
Jdlrobson updated the task description. (Show Details)Dec 13 2018, 12:52 AM
Jdlrobson changed the status of subtask T202349: When a page has multiple issue boxes but doesn't use multiple issues template, the icon is shared across all issues boxes. from Stalled to Open.Dec 14 2018, 1:27 AM
ovasileva edited projects, added Web-Team-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q2); removed Web-Team-Backlog.Dec 17 2018, 9:47 AM
phuedx removed a subtask: T202349: When a page has multiple issue boxes but doesn't use multiple issues template, the icon is shared across all issues boxes..Dec 17 2018, 11:29 AM
phuedx mentioned this in T202349: When a page has multiple issue boxes but doesn't use multiple issues template, the icon is shared across all issues boxes..Dec 17 2018, 11:31 AM
phuedx updated the task description. (Show Details)
phuedx updated the task description. (Show Details)Dec 17 2018, 11:33 AM
• Niedzielski closed subtask T211257: Split pageIssues.js into smaller functions as Resolved.Dec 17 2018, 2:56 PM
• nray claimed this task.Dec 17 2018, 4:47 PM
• nray moved this task from To Do to Doing on the Web-Team-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q2) board.
ovasileva renamed this task from Deploy page issues to all wikis (except enwiki) to Deploy page issues to all wikipedias (except enwiki).Dec 17 2018, 6:09 PM
ovasileva updated the task description. (Show Details)
• nray reassigned this task from • nray to Jdlrobson.Dec 17 2018, 6:11 PM
• nray subscribed.
gerritbot subscribed.Dec 17 2018, 6:14 PM

Change 480127 had a related patch set uploaded (by Jdlrobson; owner: Jdlrobson):
[operations/mediawiki-config@master] Page issues treatment enabled on all wikis except enwiki

https://gerrit.wikimedia.org/r/480127
gerritbot added a project: Patch-For-Review.Dec 17 2018, 6:14 PM
Jdlrobson added a comment.Dec 17 2018, 6:20 PM

Scheduled for 40 minutes from now
phuedx awarded a token.Dec 17 2018, 6:21 PM
Jdlrobson added a project: Wikimedia-Site-requests.Dec 17 2018, 6:22 PM
Restricted Application added a subscriber: Dereckson. · View Herald TranscriptDec 17 2018, 6:22 PM
gerritbot added a comment.Dec 17 2018, 7:19 PM

Change 480127 merged by jenkins-bot:
[operations/mediawiki-config@master] Page issues treatment enabled on all wikis except enwiki

https://gerrit.wikimedia.org/r/480127
Stashbot subscribed.Dec 17 2018, 7:27 PM

Mentioned in SAL (#wikimedia-operations) [2018-12-17T19:27:58Z] <pmiazga@deploy1001> Synchronized wmf-config/InitialiseSettings.php: SWAT: [[gerrit:480127 | Page issues treatment enabled on all wikis except enwiki(T210553)]] (duration: 00m 45s)
Jdlrobson reassigned this task from Jdlrobson to ovasileva.Dec 17 2018, 7:36 PM
Jdlrobson moved this task from Doing to Needs QA on the Web-Team-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q2) board.
ovasileva added a comment.Dec 17 2018, 7:42 PM
language single issue section issue multiple issues notes
Spanish working as expected:
es.m.wikipedia.org_wiki_Ataxia_de_Friedreich_useskin=minerva&minerva-issues=b(iPhone 6_7_8).png (1×750 px, 166 KB)
link		 working as expected:
es.m.wikipedia.org_wiki_Insulina_useskin=minerva&minerva-issues=b(iPhone 6_7_8).png (1×750 px, 190 KB)
link		 working as expected:
es.m.wikipedia.org_wiki_Cruz_Azul_F%C3%BAtbol_Club_useskin=minerva&minerva-issues=b(iPhone 6_7_8).png (1×750 px, 183 KB)
link		 .
German no change no change no change ...
Japanese working as expected
ja.m.wikipedia.org_wiki_%E9%87%91%E5%85%89%E6%95%99_useskin=minerva&minerva-issues=b(iPhone 6_7_8).png (1×750 px, 421 KB)
link		 working as expected
ja.m.wikipedia.org_wiki_%E8%8F%A9%E8%96%A9_useskin=minerva&minerva-issues=b(iPhone 6_7_8).png (1×750 px, 223 KB)
link		 working as expected
ja.m.wikipedia.org_wiki_%E5%8C%97%E6%B5%B7%E9%81%93%E6%96%B0%E5%B9%B9%E7%B7%9A_useskin=minerva&minerva-issues=b(iPhone 6_7_8).png (1×750 px, 326 KB)
link		 ...
French slight FOUC
fr.m.wikipedia.org_wiki_Vezouze_useskin=minerva&minerva-issues=b(iPhone 6_7_8).png (1×750 px, 272 KB)
link		 working as expected
fr.m.wikipedia.org_wiki_Th%C3%A9orie_de_la_percolation_useskin=minerva&minerva-issues=b(iPhone 6_7_8).png (1×750 px, 180 KB)
link		 working as expected
fr.m.wikipedia.org_wiki_Break_dance_useskin=minerva&minerva-issues=b(iPhone 6_7_8).png (1×750 px, 177 KB)
link		 ...
ovasileva added a comment.Dec 17 2018, 7:50 PM
language single issue section issue multiple issues notes
Russian slight FOUC
ru.m.wikipedia.org_wiki_%D0%A0%D0%BE%D1%81%D1%82%D0%BE%D0%B2%D1%89%D0%B8%D1%87%D0%B5%D1%81%D1%82%D0%B2%D0%BE_useskin=minerva&minerva-issues=b(iPhone 6_7_8).png (1×750 px, 201 KB)
link		 working as expected
ru.m.wikipedia.org_wiki_%D0%A1%D0%BF%D0%B8%D1%81%D0%BE%D0%BA_%D0%B7%D0%B0%D1%81%D0%BB%D1%83%D0%B6%D0%B5%D0%BD%D0%BD%D1%8B%D1%85_%D0%BC%D0%B0%D1%81%D1%82%D0%B5%D1%80%D0%BE%D0%B2_%D1%81%D0%BF%D0%BE%D1%80%D1%82%D0%B0_%D0%A0%D0%BE%D1%81%D1%81%D.png (1×750 px, 208 KB)
link		 slight FOUC
ru.m.wikipedia.org_wiki_%D0%92%D1%82%D0%BE%D1%80%D0%B0%D1%8F_%D0%BC%D0%B8%D1%80%D0%BE%D0%B2%D0%B0%D1%8F_%D0%B2%D0%BE%D0%B9%D0%BD%D0%B0_useskin=minerva&minerva-issues=b(iPhone 6_7_8).png (1×750 px, 240 KB)
link		 ...
Italian no change no change no change ...
Chinese working as expected
zh.m.wikipedia.org_wiki_%E8%A2%81%E4%B8%96%E5%87%AF_useskin=minerva&minerva-issues=b(iPhone 6_7_8).png (1×750 px, 302 KB)
link		 working as expected:
zh.m.wikipedia.org_wiki_%E4%B8%AD%E5%8D%8E%E4%BA%BA%E6%B0%91%E5%85%B1%E5%92%8C%E5%9B%BD%E4%BA%BA%E6%9D%83_useskin=minerva&minerva-issues=b(iPhone 6_7_8).png (1×750 px, 225 KB)
link		 working as expected
zh.m.wikipedia.org_wiki_%E4%B8%AD%E5%8C%BB%E5%AD%A6_useskin=minerva&minerva-issues=b(iPhone 6_7_8).png (1×750 px, 188 KB)
link		 ...
Portuguese working as expected
pt.m.wikipedia.org_wiki_Z%C3%A9lia_Hoffman_useskin=minerva&minerva-issues=b(iPhone 6_7_8).png (1×750 px, 181 KB)
link		 working as expected
pt.m.wikipedia.org_wiki_Homeopatia(iPhone 6_7_8).png (1×750 px, 207 KB)
link		 working as expected
pt.m.wikipedia.org_wiki_Papel-travesti_useskin=minerva&minerva-issues=b(iPhone 6_7_8).png (1×750 px, 195 KB)
link		 ...
Polish working as expected
pl.m.wikipedia.org_wiki_Recepta_useskin=minerva&minerva-issues=b(iPhone 6_7_8).png (1×750 px, 211 KB)
link		 working as expected
pl.m.wikipedia.org_wiki_Szyna_(profil)_useskin=minerva&minerva-issues=b(iPhone 6_7_8).png (1×750 px, 113 KB)
link		 working as expected
pl.m.wikipedia.org_wiki_Ustawa_useskin=minerva&minerva-issues=b(iPhone 6_7_8).png (1×750 px, 184 KB)
link		 ...
ovasileva added a comment.Dec 17 2018, 7:50 PM

looks good! I am however getting a slight FOUC on some wikis (in particular frwiki and ruwiki)
AfroThundr3007730 subscribed.Dec 17 2018, 9:24 PM
pmiazga removed a project: Patch-For-Review.Dec 17 2018, 9:48 PM
pmiazga updated the task description. (Show Details)
ovasileva moved this task from Needs QA to Ready for Signoff on the Web-Team-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q2) board.Dec 18 2018, 11:11 AM
ovasileva added a subscriber: • alexhollender_WMF.

moving this to signoff. Since I QA'd it, perhaps @alexhollender might be a good person to do signoff.
• alexhollender_WMF added a comment.Dec 18 2018, 3:10 PM

@ovasileva sounds good, will do signoff today
• alexhollender_WMF claimed this task.Dec 18 2018, 3:11 PM
• alexhollender_WMF closed this task as Resolved.Dec 18 2018, 10:41 PM

Macro tech-barnstar: We did it team !
RandomDSdevel awarded a token.Dec 23 2018, 5:09 AM
ovasileva closed subtask T200794: Analyze results of page issues A/B test as Resolved.Jun 25 2019, 4:55 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL