Page MenuHomePhabricator
Create Task
Maniphest T218352

iOS Safari: Can't save edit in WikiText editor after entering edit summary
Closed, ResolvedPublic
Actions

Description

Steps to reproduce:

  1. On an iPhone, start editing an article with mobile Safari in the WikiText editor (can be either logged in or logged out)
  2. Click the "Next" button
  3. Click in the text area to write an edit summary (which should activate the virtual keyboard).
  4. Hit "Done" to dismiss the virtual keyboard.

Expected result: You can now click "Save" and finish the edit.
Actual result: The "Save" button isn't visible and you can't scroll further up than the "How did you improve the page?" text. If you pinch to zoom out, however, you can get to the button and save.

Here's a screenshot. You can't scroll up further than this. Notice also the grey line near the bottom of the screen. Not sure if that's related.

Image-1.jpg (1×640 px, 97 KB)

Browser details: Mobile Safari, iOS 12.1, iPhone SE

May be related to T218062, T211490, and/or T218069, but Rummana suggested I file a separate bug just in case.

Details

Subject Repo Branch Lines +/-
Do not jump to top of text editor during typing mediawiki/extensions/MobileFrontend master +4 -97
Customize query in gerrit

Related Objects

Event Timeline

kaldari created this task.Mar 14 2019, 7:47 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMar 14 2019, 7:47 PM
• marcella subscribed.Mar 14 2019, 7:48 PM
kaldari mentioned this in T211490: iPad: scrolling is broken when editing mobile site in source mode.Mar 14 2019, 7:49 PM
kaldari updated the task description. (Show Details)Mar 14 2019, 7:52 PM
kaldari added a comment.Mar 14 2019, 8:23 PM

Here's a graph Ed generated of number of saveSuccess events in iOS. Looks like there was a noticeable drop around Feb 20th, which might be related to this bug. David Lynch hypothesizes that the bug mainly affects iPhones with smaller screens.

iOS mobile editing.png (323×512 px, 30 KB)

ppelberg mentioned this in T215604: Can’t scroll to bottom of link dialog on iOS mobile VE while keyboard is open.Mar 14 2019, 10:44 PM
ppelberg subscribed.Mar 14 2019, 11:05 PM
gerritbot subscribed.Mar 14 2019, 11:43 PM

Change 496682 had a related patch set uploaded (by Jdlrobson; owner: Jdlrobson):
[mediawiki/extensions/MobileFrontend@master] iOS: Do not jump to top of text editor during typing

https://gerrit.wikimedia.org/r/496682
gerritbot added a project: Patch-For-Review.Mar 14 2019, 11:43 PM
gerritbot added a comment.Mar 15 2019, 6:08 AM

Change 496682 merged by jenkins-bot:
[mediawiki/extensions/MobileFrontend@master] Do not jump to top of text editor during typing

https://gerrit.wikimedia.org/r/496682
matmarex added a subscriber: Jdlrobson.Mar 15 2019, 1:45 PM

For future reference, in case we go back to the previous approach (@Jdlrobson's commit here basically removes all iOS scrolling workarounds), I think the necessary fix would be to change the EditorOverlay isActiveWithKeyboard() function:

	isActiveWithKeyboard: function () {
		return this.$( '.wikitext-editor' ).is( ':focus' );
	},

To instead read:

		return this.$( '.wikitext-editor' ).is( ':focus' ) || this.$( '.summary' ).is( ':focus' );

(I didn't test this though)
Volker_E subscribed.Mar 15 2019, 5:51 PM
Stashbot mentioned this in T218069: Multiple issues with scrolling in the "Add discussion" overlay on iOS render it unusable (can't save, can't type long messages).Mar 15 2019, 5:59 PM
Stashbot mentioned this in T218062: Dialogs in iOS mobile VE can't be scrolled.
Stashbot subscribed.

Mentioned in SAL (#wikimedia-operations) [2019-03-15T17:59:54Z] <thcipriani@deploy1001> Synchronized php-1.33.0-wmf.21/extensions/MobileFrontend: SWAT: [[gerrit:496827|iOS: Fix mobile editor]] T218069 T218062 T218352 T211490 T218062 T211491 T172877 (duration: 00m 54s)
Stashbot mentioned this in T211491: iPad Pro/iOS 12.1: cursor jumps out of view when editing mobile site in source mode.Mar 15 2019, 6:00 PM
Stashbot mentioned this in T172877: Backspace during mobile editing moves viewing window to the top.
Jdlrobson added a comment.Mar 15 2019, 6:12 PM

This should be fixed in production. Can somebody confirm?
Jdlrobson edited projects, added VisualEditor (Current work); removed VisualEditor.Mar 15 2019, 7:14 PM
Jdlrobson moved this task from Incoming to QA on the VisualEditor (Current work) board.
Ryasmeen added a project: Verified.Mar 15 2019, 8:10 PM
Ryasmeen moved this task from QA to Product owner review on the VisualEditor (Current work) board.
ppelberg closed this task as Resolved.Mar 15 2019, 8:19 PM
ppelberg claimed this task.
Ryasmeen reassigned this task from ppelberg to Jdlrobson.Mar 15 2019, 9:20 PM
Trizek-WMF added a project: User-notice.Mar 16 2019, 8:44 AM
Trizek-WMF moved this task from To Triage to Announce in next Tech/News on the User-notice board.
Johan moved this task from Announce in next Tech/News to In current Tech/News draft on the User-notice board.Mar 21 2019, 11:37 AM
Johan moved this task from In current Tech/News draft to Already announced/Archive on the User-notice board.Mar 28 2019, 9:59 PM
Ladsgroup edited projects, added User-notice-archive; removed User-notice.Aug 13 2022, 1:44 PM
Maintenance_bot removed a project: Patch-For-Review.Aug 13 2022, 2:30 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL