Flagged Revs configuration may be broken
Closed, ResolvedPublic

Actions

Assigned To

None

Authored By

	Reedy
	Jun 5 2019, 7:57 PM

Description

Sorry for the last minute addition of this... I didn't expect quite so much random issues going on

Basically, in an improvement to ongoing maintenance, Flagged Revs configuration may be broken in various ways on various wikis.... If it is, can people please report this to phabricator, and we'll get it remedied ASAP

Details

	Subject	Repo	Branch	Lines +/-
	Move all FR config to an extension function	operations/mediawiki-config	master	+722 -796

Customize query in gerrit

Related Objects

Search...

Status	Assigned	Task
Resolved	None	T225144 Flagged Revs configuration may be broken
Resolved	Reedy	T225276 FlaggedRevs (statistics) first three namespaces are listed twice
Resolved	Reedy	T225414 File namespace added to FlaggedRevs common configuration
Resolved	Reedy	T225776 FlaggedRevs: Disable sysop protection level on the English Wikipedia
Duplicate	None	T225777 FlaggedRevs: enwiki has again autoreview and editor usergroups (which previously got removed)
Resolved	Reedy	T225797 Remove FlaggedRevs-related user groups from all FlaggedRevs wikis that shouldn't have them
Resolved	Ladsgroup	T226054 FlaggedRevs disabled for NS "Wikisource", "MediaWiki" and "File" but it still requiring reviews for transcludes
Resolved	Reedy	T226410 In de.wiktionary admins (again!!) no longer can grant the right for "autoreview" (passiver Sichter) or "editor" (Sichter).
Resolved	None	T226932 Disabled auto promotion to `editor` on arwiki works again
Resolved	Reedy	T227260 Last reviewed revision is shown to logged-out users in ukwiki instead of last revision
Duplicate	None	T229327 autopromote of "autoreview" (passiver Sichter) no longer seems to work in de.wiktionary
Resolved	matmarex	T237191 FlaggedRevs: Automatic user promotion stopped working on some wikis on June 24, 2019
Resolved	DannyS712	T262970 FlaggedRevs doesn't check the 'neverBlocked' / APCOND_FR_NEVERBLOCKED option when autopromoting

Event Timeline

Reedy created this task.Jun 5 2019, 7:57 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJun 5 2019, 7:57 PM

Maybe not needed now...

Quiddity subscribed.Jun 6 2019, 9:55 PM

Quiddity moved this task from To Triage to In current Tech/News draft on the User-notice board.Jun 6 2019, 10:20 PM

Jdforrester-WMF added a project: Wikimedia-Site-requests.Jun 6 2019, 10:23 PM

Wargo subscribed.Jun 8 2019, 1:33 PM

For future reference, this is presumably due to migration to ext. registration: https://gerrit.wikimedia.org/r/c/mediawiki/extensions/FlaggedRevs/+/514508

I'm aware of one issue that was reported recently: T225276: FlaggedRevs (statistics) first three namespaces are listed twice. Can you look into that?

matmarex added a subtask: T225276: FlaggedRevs (statistics) first three namespaces are listed twice.Jun 10 2019, 7:06 PM

matmarex added a subtask: T225414: File namespace added to FlaggedRevs common configuration.

Reedy changed the task status from Stalled to Open.Jun 10 2019, 7:27 PM

Johan moved this task from In current Tech/News draft to Already announced/Archive on the User-notice board.Jun 10 2019, 8:19 PM

Reedy reopened subtask T225414: File namespace added to FlaggedRevs common configuration as Open.Jun 10 2019, 8:35 PM

94rain subscribed.Jun 12 2019, 12:54 PM

TerraCodes added a subtask: T225797: Remove FlaggedRevs-related user groups from all FlaggedRevs wikis that shouldn't have them.Jun 21 2019, 12:11 AM

Urbanecm added a subtask: T226054: FlaggedRevs disabled for NS "Wikisource", "MediaWiki" and "File" but it still requiring reviews for transcludes.Jun 21 2019, 5:01 PM

In T225144#5247888, @matmarex wrote:

For future reference, this is presumably due to migration to ext. registration: https://gerrit.wikimedia.org/r/c/mediawiki/extensions/FlaggedRevs/+/514508

Why would that affect production? Apparently we're still on wmf.8, and 57c1ae0 didn't make it into wmf.8. There's still extension-wip.json instead of extension.json.

In T225144#5274376, @Urbanecm wrote:

In T225144#5247888, @matmarex wrote:

For future reference, this is presumably due to migration to ext. registration: https://gerrit.wikimedia.org/r/c/mediawiki/extensions/FlaggedRevs/+/514508

Why would that affect production? Apparently we're still on wmf.8, and 57c1ae0 didn't make it into wmf.8. There's still extension-wip.json instead of extension.json.

We still wfLoadExtension() the wip json file

Thanks

In T225144#5247888, @matmarex wrote:

For future reference, this is presumably due to migration to ext. registration: https://gerrit.wikimedia.org/r/c/mediawiki/extensions/FlaggedRevs/+/514508

I'm aware of one issue that was reported recently: T225276: FlaggedRevs (statistics) first three namespaces are listed twice. Can you look into that?

I've investigated the cause of T225797, it's definitely due to ext. registration. See T225797#5276094 there.

Change 518396 had a related patch set uploaded (by Reedy; owner: Reedy):
[operations/mediawiki-config@master] Move all FR config to an extension function

https://gerrit.wikimedia.org/r/518396

gerritbot added a project: Patch-For-Review.Jun 22 2019, 9:32 PM

Change 518396 merged by jenkins-bot:
[operations/mediawiki-config@master] Move all FR config to an extension function

https://gerrit.wikimedia.org/r/518396

Mentioned in SAL (#wikimedia-operations) [2019-06-24T13:50:54Z] <reedy@deploy1001> Synchronized wmf-config/flaggedrevs.php: T225144 T225276 T225414 T225776 T225797 T226054 (duration: 00m 56s)

Stashbot mentioned this in T225276: FlaggedRevs (statistics) first three namespaces are listed twice.Jun 24 2019, 1:50 PM

Stashbot mentioned this in T225414: File namespace added to FlaggedRevs common configuration.

Stashbot mentioned this in T225776: FlaggedRevs: Disable sysop protection level on the English Wikipedia.

Stashbot mentioned this in T225797: Remove FlaggedRevs-related user groups from all FlaggedRevs wikis that shouldn't have them.

Stashbot mentioned this in T226054: FlaggedRevs disabled for NS "Wikisource", "MediaWiki" and "File" but it still requiring reviews for transcludes.

Maintenance_bot removed a project: Patch-For-Review.Jun 24 2019, 2:10 PM

JJMC89 added a subtask: T226410: In de.wiktionary admins (again!!) no longer can grant the right for "autoreview" (passiver Sichter) or "editor" (Sichter)..Jun 24 2019, 3:03 PM

Udo_T subscribed.Jun 24 2019, 3:44 PM

Reedy closed subtask T226410: In de.wiktionary admins (again!!) no longer can grant the right for "autoreview" (passiver Sichter) or "editor" (Sichter). as Resolved.Jun 24 2019, 5:11 PM

Reedy closed subtask T226054: FlaggedRevs disabled for NS "Wikisource", "MediaWiki" and "File" but it still requiring reviews for transcludes as Resolved.Jun 24 2019, 5:12 PM

Reedy closed subtask T225797: Remove FlaggedRevs-related user groups from all FlaggedRevs wikis that shouldn't have them as Resolved.

Reedy closed subtask T225776: FlaggedRevs: Disable sysop protection level on the English Wikipedia as Resolved.

Reedy closed subtask T225414: File namespace added to FlaggedRevs common configuration as Resolved.

Reedy closed subtask T225276: FlaggedRevs (statistics) first three namespaces are listed twice as Resolved.

Udo_T reopened subtask T226410: In de.wiktionary admins (again!!) no longer can grant the right for "autoreview" (passiver Sichter) or "editor" (Sichter). as Open.Jun 24 2019, 11:35 PM

Vladis13 reopened subtask T226054: FlaggedRevs disabled for NS "Wikisource", "MediaWiki" and "File" but it still requiring reviews for transcludes as Open.Jun 25 2019, 8:05 PM

Aklapper closed subtask T226410: In de.wiktionary admins (again!!) no longer can grant the right for "autoreview" (passiver Sichter) or "editor" (Sichter). as Resolved.Jun 29 2019, 11:56 AM

Urbanecm added a subtask: T226932: Disabled auto promotion to `editor` on arwiki works again.Jun 30 2019, 12:20 PM

Urbanecm moved this task from Backlog to Analysis / under discussion on the Wikimedia-Site-requests board.Jul 1 2019, 2:48 PM

Ata added a subtask: T227260: Last reviewed revision is shown to logged-out users in ukwiki instead of last revision.Jul 4 2019, 8:48 AM

Udo_T mentioned this in T229327: autopromote of "autoreview" (passiver Sichter) no longer seems to work in de.wiktionary.Jul 30 2019, 1:09 PM

@Reedy @Quiddity is there any progress on this? In Ukrainian Wikipedia T227260 was caused by this change and is not fixed for over two months now. Thanks