Description

When you visit history of a page and apply some filters (example), you will see just the filter menu and explanations of some markers.
There should be some placeholder explaining why there are no results.

Solution:

create a message in languages/i18n/en.json and documentation in languages/i18n/qqq.json (https://www.mediawiki.org/wiki/Localisation)
override IndexPager::getEmptyBody in HistoryPager class to print the new message (https://www.mediawiki.org/wiki/Manual:Messages_API#Using_messages_in_PHP)
update HistoryPager::getStartBody and HistoryPager::getEndBody, so that they produce no HTML when HistoryPager::getNumRows returns 0

QA steps

Visit https://en.wikipedia.beta.wmflabs.org/w/index.php?date-range-to=&tagfilter=sillyqa&title=Main_Page&action=history

A message should inform you that no matching revisions were found.
Click filter revisions and remove "sillyqa" from the input box
Check that the message doesn't show and there are results

QA Results - Beta

AC	Status	Details
1	✅	T227578#6037273
2	✅	T227578#6037273

QA Results - Prod cawiki

AC	Status	Details
1	✅	T227578#6042110
2	✅	T227578#6042110

Details

	Subject	Repo	Branch	Lines +/-
	Added message to be displayed when query returns no revision	mediawiki/core	master	+25 -10

Customize query in gerrit

Related Objects

Mentioned In: T251605: Omit history navigation links when no results are found
Mentioned Here: T225573: [Bug] History action's "Filter revisions" form should remain visible when a filter is applied

Event Timeline

matej_suchanek created this task.Jul 9 2019, 11:36 AM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJul 9 2019, 11:36 AM

Aklapper edited projects, added MediaWiki-Page-history; removed MediaWiki-Page-diffs.Sep 20 2019, 7:42 PM

matej_suchanek triaged this task as Low priority.Mar 2 2020, 12:30 PM

matej_suchanek added a project: good first task.

matej_suchanek updated the task description. (Show Details)

@matej_suchanek I've a newbie question - this task would require all changes to MediaWiki core only, right?

Aklapper updated the task description. (Show Details)Mar 3 2020, 6:49 AM

Yes, only MW core.

matej_suchanek updated the task description. (Show Details)Mar 3 2020, 9:44 AM

Soda claimed this task.Mar 6 2020, 1:31 PM

Change 577554 had a related patch set uploaded (by Sohom Datta; owner: Sohom Datta):
[mediawiki/core@master] Added message to be displayed when query returns no revision

https://gerrit.wikimedia.org/r/577554

gerritbot added a project: Patch-For-Review.Mar 6 2020, 1:31 PM

@matej_suchanek I've updated the patch based on your recommendations, sorry for the sloppy work on the last patch set, I somehow misinterpreted/misread your comments...

No problem, you are doing well. Sorry for any confusion.

Incoming code review request from a volunteer. cc @alexhollender @ovasileva

MBinder_WMF edited projects, added Web-Team-Backlog (Kanbanana-2019-20-Q4); removed Web-Team-Backlog (Kanbanana-2019-20-Q3).Mar 31 2020, 10:14 PM

@Jdlrobson how can we see what this looks like?

You can replicate the issue here - https://en.wikipedia.org/w/index.php?date-range-to=&tagfilter=assaas&title=1900%E2%80%9301_Indiana_State_Sycamores_men%27s_basketball_team&action=history - note the lack of feedback.

The feedback looks like this with the patch applied:

Screen Shot 2020-04-01 at 11.03.41 AM.png (792×2 px, 226 KB)

@alexhollender, @Jdlrobson - sorry for the delay. This seems ok to me.

Jdlrobson moved this task from Needs Analysis to Needs QA on the Web-Team-Backlog (Kanbanana-2019-20-Q4) board.Apr 2 2020, 6:48 PM

Jdlrobson updated the task description. (Show Details)

Change 577554 merged by jenkins-bot:
[mediawiki/core@master] Added message to be displayed when query returns no revision

https://gerrit.wikimedia.org/r/577554

Maintenance_bot removed a project: Patch-For-Review.Apr 2 2020, 7:11 PM

ReleaseTaggerBot added a project: MW-1.35-notes (1.35.0-wmf.27; 2020-04-07).Apr 2 2020, 8:00 PM

@Jdlrobson looks good, thanks for the screenshot

ovasileva reassigned this task from Soda to Edtadros.Apr 6 2020, 11:46 AM

ovasileva added a subscriber: Soda.

Test Result - Beta

Status: ✅ PASS
OS: macOS Catalina
Browser: Chrome
Device: MBP
Emulated Device: iPhoneX

Test Artifact(s):

QA steps

Visit https://en.wikipedia.beta.wmflabs.org/w/index.php?date-range-to=&tagfilter=sillyqa&title=Main_Page&action=history
✅ AC1: A message should inform you that no matching revisions were found.

en.wikipedia.beta.wmflabs.org_w_index.php_date-range-to=&tagfilter=sillyqa&title=Main_Page&action=history(iPad).png (2×1 px, 284 KB)

Click filter revisions and remove "sillyqa" from the input box
✅ AC2: Check that the message doesn't show and there are results

en.wikipedia.beta.wmflabs.org_w_index.php_title=Main_Page&action=history(iPad).png (2×1 px, 792 KB)

Edtadros updated the task description. (Show Details)Apr 7 2020, 5:30 PM

Edtadros added a project: Product-QA (RW-Test-Cases).Apr 7 2020, 5:48 PM

ovasileva moved this task from Needs QA to Needs QA in Prod on the Web-Team-Backlog (Kanbanana-2019-20-Q4) board.Apr 8 2020, 8:44 AM

Test Result - Prod cawiki

Status: ✅ PASS
OS: macOS Catalina
Browser: Chrome
Device: MBP
Emulated Device: iPhoneX

Test Artifact(s):

QA steps

Visit https://en.wikipedia.beta.wmflabs.org/w/index.php?date-range-to=&tagfilter=sillyqa&title=Main_Page&action=history
✅ AC1: A message should inform you that no matching revisions were found.
@ovasileva the message is in English. I'm not sure if this is a concern or not.

ca.wikipedia.org_w_index.php_date-range-to=&tagfilter=sillyqa&title=Main_Page&action=history(iPad).png (2×1 px, 266 KB)

Click filter revisions and remove "sillyqa" from the input box
✅ AC2: Check that the message doesn't show and there are results

ca.wikipedia.org_w_index.php_date-range-to=&tagfilter=&title=Main_Page&action=history(iPad).png (2×1 px, 730 KB)

Edtadros updated the task description. (Show Details)Apr 9 2020, 5:04 AM

Looks good @Edtadros - the message will get translated over time in translatewiki. Resolving this. Thanks everyone!

ovasileva added a project: User-notice.Apr 9 2020, 8:28 AM

matej_suchanek closed this task as Resolved.Apr 9 2020, 9:01 AM

matej_suchanek reassigned this task from ovasileva to Soda.

Johan moved this task from To Triage to In current Tech/News draft on the User-notice board.Apr 9 2020, 2:04 PM

srishakatux awarded a token.Apr 9 2020, 9:50 PM

Ammarpad merged a task: T225767: [Bug] History action page should display a friendly message when no results are found.Apr 12 2020, 6:53 AM

Ammarpad added a subscriber: • nray.

Johan moved this task from In current Tech/News draft to Already announced/Archive on the User-notice board.Apr 13 2020, 11:05 PM

Sakretsu mentioned this in T251605: Omit history navigation links when no results are found.May 1 2020, 1:27 PM

Ladsgroup edited projects, added User-notice-archive; removed User-notice.Aug 13 2022, 1:54 PM

	F31745557: ca.wikipedia.org_w_index.php_date-range-to=&tagfilter=&title=Main_Page&action=history(iPad).png
	Apr 9 2020, 5:02 AM

	F31745551: ca.wikipedia.org_w_index.php_date-range-to=&tagfilter=sillyqa&title=Main_Page&action=history(iPad).png
	Apr 9 2020, 5:02 AM

	F31740897: en.wikipedia.beta.wmflabs.org_w_index.php_title=Main_Page&action=history(iPad).png
	Apr 7 2020, 5:29 PM

	F31740894: en.wikipedia.beta.wmflabs.org_w_index.php_date-range-to=&tagfilter=sillyqa&title=Main_Page&action=history(iPad).png
	Apr 7 2020, 5:29 PM

	F31720879: Screen Shot 2020-04-01 at 11.03.41 AM.png
	Apr 1 2020, 6:36 PM

	F31657145: obrazek.png
	Mar 3 2020, 9:44 AM

History page needs a placeholder when no revisions can be shown Closed, ResolvedPublic Actions

Description

QA steps

QA Results - Beta

QA Results - Prod cawiki

Details

Related Objects

Event Timeline

Test Result - Beta

QA steps

Test Result - Prod cawiki

QA steps

History page needs a placeholder when no revisions can be shown
Closed, ResolvedPublic

Actions