Page MenuHomePhabricator
Create Task
Maniphest T254534

Technical change to WikidataPageBanner - projects using it now show mobile site notices
Closed, ResolvedPublic
Actions

Description

A technical change (T254295) to the WikidataPageBanner means that any site notice enabled on the site will now display to mobile users as well as desktop users.

Users of projects using WikidataPageBanner are advised to update their usage instructions on MediaWiki:Sitenotice to encourage editors enabling site notices to test and style (or hide!) their banner via CSS on mobile.

If you have any questions about how to do this, please feel free to ping @Jdlrobson on wiki or reply to this tech use notice.

Impacted projects are Wikivoyage, Russian Wikimedia, Catalan, Basque, Galician and Turkish Wikipedia

Related Objects

Event Timeline

Jdlrobson created this task.Jun 4 2020, 11:15 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJun 4 2020, 11:15 PM
Johan moved this task from To Triage to In current Tech/News draft on the User-notice board.Jun 5 2020, 7:00 PM
Jdlrobson updated the task description. (Show Details)Jun 8 2020, 9:54 PM
Omondi subscribed.Jun 10 2020, 6:55 PM

Why all the page banners disappeared ?
Jdlrobson added a comment.Jun 10 2020, 7:43 PM

@Omondi which project?
JSaezAndroid subscribed.EditedJun 10 2020, 11:59 PM

@Jdlrobson @Omondi
Here are some examples. Pagebanners disappeared after page load on:

  • es.wikivoyage
  • fr.wikivoyage
  • vi.wikivoyage
Jdlrobson added a comment.Jun 11 2020, 1:44 AM

French Wikivoyage had a site script which removed the subtitle. It looks like that same script might be on Spanish and Vietnamese too:

Note, iF I turn off gadgets they work fine:
https://es.wikivoyage.org/wiki/Aberdeen?safemode=1
https://vi.wikivoyage.org/wiki/Aberdeen?safemode=1
Jdlrobson added a comment.Jun 11 2020, 1:47 AM

Fixed:
https://es.wikivoyage.org/w/index.php?title=MediaWiki%3ACommon.js&type=revision&diff=160325&oldid=159319
https://vi.wikivoyage.org/w/index.php?title=MediaWiki%3ACommon.js&type=revision&diff=95004&oldid=39001
Omondi added a comment.Jun 11 2020, 8:47 AM

I have tried that on fr.wikivoyage but it doesn't work. Using Firefox, if I put "javascript.enabled" on false, the pages banners are back but that's not a solution.
Omondi added a comment.EditedJun 11 2020, 11:47 AM

I have fixed. The same thing was also writed in MediaWiki:Common.css
https://fr.wikivoyage.org/w/index.php?title=MediaWiki%3ACommon.css&type=revision&diff=471432&oldid=471428
https://fr.wikivoyage.org/w/index.php?title=MediaWiki%3ACommon.js&type=revision&diff=471433&oldid=471431
Jdlrobson added a comment.Jun 11 2020, 2:55 PM
In T254534#6214001, @Omondi wrote:

I have tried that on fr.wikivoyage but it doesn't work. Using Firefox, if I put "javascript.enabled" on false, the pages banners are back but that's not a solution.

It works fine for me without JavaScript. Do you get the same problem when you put safemode=1 at the end of the URL? e.g. https://fr.wikivoyage.org/wiki/Gastronomie_bruxelloise?safemode=1
Jdlrobson mentioned this in T255102: Links not working inside <indicator> tag at Russian Wikivoyage.Jun 11 2020, 3:09 PM
Johan moved this task from In current Tech/News draft to Already announced/Archive on the User-notice board.Jun 11 2020, 3:17 PM
Aklapper added a comment.Jun 24 2020, 11:07 AM

@Omondi: Could you please answer the last comment? Thanks!
Jdlrobson added a comment.Jun 24 2020, 2:47 PM

@Aklapper this got resolved on wiki eventually. I don't the link handy but it was a problem with a gadget.
Aklapper added a subscriber: Johan.Jun 24 2020, 4:38 PM

Ah, glad to hear that got resolved!

(Plus wondering if this task should remain open as there are no other project tags here, but @Johan probably knows best?)
Johan closed this task as Resolved.Jun 24 2020, 11:49 PM
Johan claimed this task.

If it's resolved I see no reason to keep it open.
Restricted Application added a project: User-Johan. · View Herald TranscriptJun 24 2020, 11:49 PM
Johan removed Johan as the assignee of this task.Jun 24 2020, 11:49 PM
Johan removed a project: User-Johan.
Ladsgroup edited projects, added User-notice-archive; removed User-notice.Aug 13 2022, 1:44 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL