Page MenuHomePhabricator
Create Task
Maniphest T265373

The `#jump-to-nav` div will be removed in Vector - gadgets will be impacted without change
Closed, ResolvedPublic
Actions

Description

Up to 320 user scripts [1] reference the jump-to-nav element to insert UI elements. This element will be removed within the next few weeks and those scripts may break or misbehave without any changes.

Without change this is likely to impact the display of UI elements in code such as:

 $node.insertAfter('#jump-to-nav');
document.getElementById('jump-to-nav').nextSibling

We recommend using the #siteSub or #mw-content-text elements as potential replacements.

Potentially impacted scripts

[1] https://global-search.toolforge.org/?q=jump-to-nav&regex=1&namespaces=&title=.*js

Event Timeline

Jdlrobson created this task.Oct 13 2020, 4:08 PM
Restricted Application added subscribers: Strainu, jeblad, Danmichaelo and 3 others. · View Herald TranscriptOct 13 2020, 4:08 PM
Jdlrobson updated the task description. (Show Details)Oct 13 2020, 4:08 PM
Jdlrobson updated the task description. (Show Details)
• nray subscribed.Oct 13 2020, 4:11 PM
JJMC89 updated the task description. (Show Details)Oct 13 2020, 4:16 PM
Quiddity moved this task from To Triage to Announce in next Tech/News on the User-notice board.Oct 15 2020, 8:28 PM
Quiddity subscribed.Oct 15 2020, 8:37 PM

Hi @Jdlrobson If I understand correctly, the wording in the user-notice should be something like:

Some gadgets and user-scripts use the HTML div #jump-to-nav. This div will be removed soon. Maintainers should replace these uses with either #siteSub or #mw-content-text. A list of affected scripts is at the top of phab:T265373.

If that is inaccurate/imperfect, then Please provide a correct version.
I will add it to TechNews tomorrow (Friday) morning (PST) before this issue is frozen for translation, for delivery on Monday.
Jdlrobson added a comment.Oct 15 2020, 8:37 PM

perfect.
RiazRipon subscribed.Oct 19 2020, 4:43 PM
AntiCompositeNumber updated the task description. (Show Details)Oct 19 2020, 5:02 PM
TheDJ subscribed.Oct 21 2020, 8:49 AM

I remember that [[#jump-to-nav]] in the past was also used as an anchor link sometimes instead of [[#top]]. Might be another impact to look out for.
Pelagic subscribed.Oct 21 2020, 8:19 PM

Do the alternate divs exist in other skins, or will scripts that aim to work across multiple skins need to make an existence check? If the latter, can you provide an example code snippet to aid maintainers?
Jdlrobson added a comment.Oct 21 2020, 8:39 PM

This element was never part of a standard skin spec so the HTML may or may not be in other skins. Right now this has only been removed in Vector. Other skins should not be impacted.

I'd recommend always doing an existence check for any gadget as other gadgets can alter the look and feel of the skin.

Does that answer your question?
Quiddity moved this task from Announce in next Tech/News to Already announced/Archive on the User-notice board.Oct 22 2020, 6:23 PM
Jony subscribed.Oct 23 2020, 4:51 PM
Aklapper closed this task as Resolved.May 15 2021, 10:03 AM

https://gerrit.wikimedia.org/r/c/mediawiki/skins/Vector/+/633207 was merged in October 2020; no reason to keep this ticket open
Stang unsubscribed.Nov 13 2021, 11:29 PM
Ladsgroup edited projects, added User-notice-archive; removed User-notice.Aug 13 2022, 1:44 PM
Restricted Application added a subscriber: Ericliu1912. · View Herald TranscriptAug 13 2022, 1:44 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL