Page MenuHomePhabricator
Create Task
Maniphest T308570

When user is blocked, update 'Block user' button to read 'Change block' and add an 'Unblock user' button
Closed, ResolvedPublic5 Estimated Story Points
Actions

Description

As an administrator I want to change the block status for a blocked user from my mobile device, so that I can allow the user to continue editing.

In the overflow menu on mobile web, users with the block user right see a 'Block user' button on user pages (T307341). If the user is blocked, this button still says 'Block user' and still navigates only to Special:Block. This means that while editors can change that user's block status, they cannot easily access Special:Unblock except through a small link on the block page.

We could contextually show a link to Special:Unblock with the text 'Unblock user', and change the 'Block user' text to 'Change block'.

Design

These items should replace the location of the 'Block user' button in the current list.

Text Destination OOUI icon
Change block Special:Block/USERNAME block
Unblock user Special:Unblock/USERNAME unBlock

Acceptance criteria

  • When a user who has the block user right visits a user page for a blocked user, the Overflow menu should have a 'Change block' item which links to Special:Block and a 'Unblock user' item which links to Special:Unblock.
  • The 'Block user' list item should no longer be shown
  • For users without the block user right, no block-related items should be shown in this menu
  • For users with the block user right, on user pages for users who are not blocked, no change should take place in this menu

Details

Subject Repo Branch Lines +/-
User menu overflow: add change block and unblock mediawiki/skins/MinervaNeue master +8 -0
Skin.php: Add change and unblock navigation URLs mediawiki/core master +23 -6
Customize query in gerrit

Related Objects
Search...

Event Timeline

• Samwalton9-WMF triaged this task as Low priority.May 17 2022, 3:19 PM
• Samwalton9-WMF created this task.
• Samwalton9-WMF moved this task from Inbox to Overflow menu on the Moderator-Tools-Team board.
• Samwalton9-WMF updated the task description. (Show Details)May 17 2022, 3:26 PM
• Samwalton9-WMF added projects: MobileFrontend, Advanced Mobile Contributions.May 17 2022, 3:28 PM
• Samwalton9-WMF renamed this task from When user is blocked, change 'Block user' button to read 'Change block' and add an 'Unblock user' button on mobile web to When user is blocked, update 'Block user' button to read 'Change block' and add an 'Unblock user' button on mobile web.May 20 2022, 8:34 AM
• Samwalton9-WMF edited projects, added Moderator-Tools-Team (Kanban); removed Moderator-Tools-Team.
• Samwalton9-WMF edited projects, added Moderator-Tools-Team; removed Moderator-Tools-Team (Kanban).
• Samwalton9-WMF set the point value for this task to 5.May 25 2022, 4:59 PM
• Samwalton9-WMF moved this task from Overflow menu to Kanban on the Moderator-Tools-Team board.May 26 2022, 9:58 AM
• Samwalton9-WMF edited projects, added Moderator-Tools-Team (Kanban); removed Moderator-Tools-Team.
jsn.sherman subscribed.Jun 3 2022, 2:35 PM

to get to the necessary state to see this in docker:

  • register a new account
  • sign in as Admin in another session
  • block the new account
  • see the current state where the block button is still shown for blocked users
jsn.sherman claimed this task.Jun 6 2022, 3:34 PM
jsn.sherman moved this task from Ready to In Progress on the Moderator-Tools-Team (Kanban) board.
jsn.sherman removed jsn.sherman as the assignee of this task.Jun 16 2022, 3:44 PM
jsn.sherman moved this task from In Progress to Ready on the Moderator-Tools-Team (Kanban) board.
Scardenasmolinar claimed this task.Jun 27 2022, 6:58 PM
Scardenasmolinar moved this task from Ready to In Progress on the Moderator-Tools-Team (Kanban) board.
gerritbot added a comment.Jun 28 2022, 11:06 PM

Change 809315 had a related patch set uploaded (by Scardenasmolinar; author: Scardenasmolinar):

[mediawiki/core@master] Skin.php: Add change and unblock navigation URLs

https://gerrit.wikimedia.org/r/809315
gerritbot added a project: Patch-For-Review.Jun 28 2022, 11:06 PM
gerritbot added a comment.Jun 28 2022, 11:09 PM

Change 809317 had a related patch set uploaded (by Scardenasmolinar; author: Scardenasmolinar):

[mediawiki/skins/MinervaNeue@master] User menu overflow: add change block and unblock

https://gerrit.wikimedia.org/r/809317
PatchDemoBot added a comment.Jun 28 2022, 11:55 PM

Test wiki created on Patch demo by SCardenas (WMF) using patch(es) linked to this task:
https://patchdemo.wmflabs.org/wikis/c08cc0531e/w/
Scardenasmolinar moved this task from In Progress to Code review on the Moderator-Tools-Team (Kanban) board.Jun 29 2022, 12:01 AM

This is ready for review! I created a patch demo to check that everything is working correctly.
• Samwalton9-WMF added a comment.EditedJun 29 2022, 11:54 AM

In desktop Vector I see <changeblockip> in the sidebar when on a blocked user's user page:

Screenshot 2022-06-29 at 12.49.32.png (302×151 px, 25 KB)

I think it's OK that we're also changing this behaviour for desktop (Like on mobile, "Block user" shows in the sidebar regardless of the user's block status which isn't tremendously helpful), but it seems like this isn't displaying correctly right now.
Scardenasmolinar added a comment.Jun 29 2022, 4:25 PM

On it!
PatchDemoBot added a comment.Jun 29 2022, 5:10 PM

Test wiki on Patch demo by SCardenas (WMF) using patch(es) linked to this task was deleted:

https://patchdemo.wmflabs.org/wikis/c08cc0531e/w/
PatchDemoBot added a comment.Jun 29 2022, 5:42 PM

Test wiki created on Patch demo by SCardenas (WMF) using patch(es) linked to this task:
https://patchdemo.wmflabs.org/wikis/870fd56ab8/w/
Scardenasmolinar added a comment.Jun 29 2022, 5:50 PM

This new patch demo has the updated version of the MediaWiki core patch. I have verified it's working correctly in Vector, Monobook, and Timeless. Let me know if you see anything else :)
• Samwalton9-WMF added a comment.Jun 30 2022, 11:00 AM

LGTM :)
gerritbot added a comment.Jul 1 2022, 3:14 PM

Change 809315 merged by jenkins-bot:

[mediawiki/core@master] Skin.php: Add change and unblock navigation URLs

https://gerrit.wikimedia.org/r/809315
• Samwalton9-WMF renamed this task from When user is blocked, update 'Block user' button to read 'Change block' and add an 'Unblock user' button on mobile web to When user is blocked, update 'Block user' button to read 'Change block' and add an 'Unblock user' button.Jul 5 2022, 2:56 PM
• Samwalton9-WMF moved this task from Code review to Done on the Moderator-Tools-Team (Kanban) board.
jsn.sherman added subscribers: ovasileva, Jdlrobson.EditedJul 5 2022, 4:36 PM

After last weeks talk with @Jdlrobson, I want to make sure we're looping in readers web.

@ovasileva this is a fairly small followup to T307341: Add Block button to Overflow menu that touches Minerva
https://gerrit.wikimedia.org/r/c/809315

Is this something y'all can take a look at? Or is this a small enough change for us to qa and +2?
Jdlrobson awarded a token.Jul 6 2022, 6:15 PM
Scardenasmolinar added a comment.Jul 7 2022, 6:19 PM

There is also this ticket ready for review! https://gerrit.wikimedia.org/r/c/mediawiki/skins/MinervaNeue/+/809317
jsn.sherman added a comment.Jul 7 2022, 8:00 PM
In T308570#8062831, @Scardenasmolinar wrote:

There is also this ticket ready for review! https://gerrit.wikimedia.org/r/c/mediawiki/skins/MinervaNeue/+/809317

Yes! @Jdlrobson This is what I meant to link to! Sorry @Scardenasmolinar
ReleaseTaggerBot added a project: MW-1.39-notes (1.39.0-wmf.21; 2022-07-18).Jul 11 2022, 11:01 PM
• Samwalton9-WMF added a project: User-notice.Jul 12 2022, 12:03 AM

For tech news:

Administrators will now see 'Change block' and 'Unblock user' buttons instead of 'Block user' on user pages if the user is already blocked.
Quiddity subscribed.Jul 14 2022, 7:42 PM

Re: Tech News - Thanks for the draft, that helps immensely!
If I understand correctly, this is not available yet. I.e. It is not currently in translatewiki, and thus not live on the wikis.
(I checked by looking at the gerrit commits, and trying to search for the two new strings, but minerva-page-actions-change-block and minerva-page-actions-unblock are not there yet. But changeblockip is there.)

Question: Is this just a change in the mobile web? I believe so (it looks like desktop handles this via change-blocklink and unblocklink), but I'm not certain. Please correct me if I'm wrong.

Therefore, I suggest postponing this Tech News item until the week after next, and at that time, writing the entry (in the "Recent changes" section) like so:

On the mobile web site, Administrators will now see buttons for 'Change block' and 'Unblock user' instead of 'Block user' on user pages if the user is already blocked.
Quiddity moved this task from To Triage to Not ready to announce on the User-notice board.Jul 14 2022, 7:42 PM
• Samwalton9-WMF added a comment.Jul 14 2022, 8:28 PM

Therefore, I suggest postponing this Tech News item until the week after next

That's correct, this will go out in the train next week.

Question: Is this just a change in the mobile web? I believe so (it looks like desktop handles this via change-blocklink and unblocklink), but I'm not certain. Please correct me if I'm wrong.

This will impact both the mobile and desktop sites.
Scardenasmolinar added a comment.Jul 15 2022, 2:42 AM

There is still one patch that has not been merged yet, but if the +2 it on Friday or Monday, it will make next week's train.
gerritbot added a comment.Jul 18 2022, 5:47 PM

Change 809317 merged by jenkins-bot:

[mediawiki/skins/MinervaNeue@master] User menu overflow: add change block and unblock

https://gerrit.wikimedia.org/r/809317
Maintenance_bot removed a project: Patch-For-Review.Jul 18 2022, 6:30 PM
PatchDemoBot added a comment.Jul 18 2022, 11:05 PM

Test wiki on Patch demo by SCardenas (WMF) using patch(es) linked to this task was deleted:

https://patchdemo.wmflabs.org/wikis/870fd56ab8/w/
Quiddity moved this task from Not ready to announce to In current Tech/News draft on the User-notice board.Jul 21 2022, 9:17 PM
• Samwalton9-WMF closed this task as Resolved.Jul 26 2022, 11:58 AM

Looking good, tested with my personal account on en.wiki :)
Quiddity moved this task from In current Tech/News draft to Already announced/Archive on the User-notice board.Jul 28 2022, 8:59 PM
Ladsgroup edited projects, added User-notice-archive; removed User-notice.Aug 13 2022, 1:54 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL