Page MenuHomePhabricator

Edits which hit the condition limit should be tagged
Closed, ResolvedPublic

Assigned To
Authored By
OdMishehu
Aug 13 2014, 8:02 PM
Referenced Files
None
Tokens
"Grey Medal" token, awarded by RandomDSdevel."Like" token, awarded by Liuxinyu970226."Like" token, awarded by matej_suchanek."Like" token, awarded by Dalba.

Description

The Abuse Filter occasionally stops handling specific edits because it reached the condition limit. It should be possible to see which edits these are - both because they didn't pass the scrutiny of all the filters (and are likely to be problematic), and to allow the Abuse Filter managers to find the expensive filters which cause these.

Event Timeline

bzimport raised the priority of this task from to Low.Nov 22 2014, 3:45 AM
bzimport added a project: AbuseFilter.
bzimport set Reference to bz69492.
bzimport added a subscriber: Unknown Object (MLST).
He7d3r added a project: Performance Issue.
He7d3r set Security to None.

Change 339927 had a related patch set (by Matěj Suchánek) published:
[mediawiki/extensions/AbuseFilter@master] Tag actions which hit the condition limit

https://gerrit.wikimedia.org/r/339927

Change 339927 merged by jenkins-bot:
[mediawiki/extensions/AbuseFilter@master] Tag actions which hit the condition limit

https://gerrit.wikimedia.org/r/339927

Huji removed a project: Patch-For-Review.

Wow! If you have done what I think you have done, this deserves all the story points and user notices it can get! I'm very much looking forward to seeing this in action!

@matej_suchanek How would you phrase this in Tech News?

What about something like this:

Some edits have to be checked against too many conditions before they can trigger an abuse filter. If any filter is not executed for that reason, the edit will be [{{fullurl:Special:RecentChanges|tagfilter=abusefilter-condition-limit}} tagged] for further review.