Page MenuHomePhabricator
Create Task
Maniphest T92357

Fix database master queries from HTTP GET/HEAD before active-active multi-dc
Open, MediumPublic
Actions

Description

Most of MediaWiki was written with the assumption that MediaWiki and its data stores are collocated and connected via reliable, low-latency network links. Until recently, MediaWiki had minimal facilities for maintaining consistency and partition tolerance across wide-area network links. As a result, although the Wikimedia Foundation operates data centers in multiple locations, we only run MediaWiki in one location at any one time.

This has several practical consequences: first, we are not as fault-tolerant as we'd like to be. We have a secondary data center with enough capacity to serve our traffic in case our primary datacenter goes down, but it is in cold standby, meaning it takes some time (and some manual effort) to get it running. Second, site performance is poor for logged-in users that are geographically remote from Ashburn, Virginia, due to the time it takes to transmit and receive data across long-distance links. Thirdly, in some basic cases, like parsing pages, the master database must be up, leading to a SPOF.

It's going to take a lot of work to fix this completely, but we are getting closer to being able to serve some traffic from secondary datacenter. Specifically, we would like to serve "reads" -- requests that don't require a master database connection -- from a secondary datacenter.

In order to serve reads from a different datacenter, we need to be able to predict which incoming requests will modify data, so that we can route them accordingly. We need to be able to make this determination at the edge -- i.e., the outermost layers of the infrastructure, so it cannot be complicated or slow.

The solution we have is to use the HTTP request method (T91820): GETs/HEADs are read-only, while POSTs are not. This was already true for most cases, but there is a long tail of actions with side-effects that are done via GET, such as purge, rollback, markpatrolled.

This task mostly involves fixing DBPerformance log warnings. Warnings can be dealt with be:
a) Changing DB master reads to use DB slaves
b) Moving the database updates to POST requests, the jobqueue, or at least to post-send updates via DeferredUpdates
c) Disabling warnings for a few exceptional cases like CentralAuth.

See +channel:DBPerformance on logstash.wikimedia.org

Most of these warnings are writes or master queries on HTTP GET requests, which would be cross DC in active-active setup for some user. Ideally we could eventually get these to zero.

Details

Subject Repo Branch Lines +/-
Use the main stash for basic user talk page notifications mediawiki/core master +41 -53
[WIP] Avoid Category count refresh DB writes on HTTP GET mediawiki/core master +19 -27
Add UserOptionsUpdateJob class and use it for namespaces at SpecialSearch mediawiki/core master +17 -8
Use a job for triggering new user talk messages mediawiki/extensions/NewUserMessage master +45 -3
Avoid triggering master queries in ApiValidatePassword mediawiki/extensions/CentralAuth master +8 -3
Avoid master queries in beginSecondaryAuthentication() mediawiki/extensions/CentralAuth master +1 -1
Avoid DB_MASTER queries in User::newSystemUser() when possible mediawiki/core master +19 -7
Avoid master queries in SpecialGlobalRenameProgress mediawiki/extensions/CentralAuth master +3 -3
Use TranslateUtils::getSafeReadDB() in loadAggregateGroups mediawiki/extensions/Translate master +1 -1
Avoid DB_MASTER queries on HTTP GET in ArticleMetadata->getMetadata mediawiki/extensions/PageTriage master +6 -0
Add $flags parameter to renameInProgressOn() mediawiki/extensions/CentralAuth master +7 -3
Avoid master queries in loadAndLazyInit() for miser mode mediawiki/core master +8 -3
Make opportunistic password hash upgrades post-send mediawiki/extensions/CentralAuth master +9 -8
Avoid page_touched update for HTTP GET action=purge requests mediawiki/core master +77 -23
Make CentralAuthHooks::onLocalUserCreated() trigger importLocalNames() mediawiki/extensions/CentralAuth master +25 -14
Make SessionBackend::save() update the user post-send mediawiki/core master +22 -1
Fix central logout mediawiki/extensions/CentralAuth REL1_27 +3 -2
Fix central logout mediawiki/extensions/CentralAuth master +3 -2
Avoid DBPerformance log warnings in onUserLogout() mediawiki/extensions/CentralAuth REL1_27 +6 -5
Avoid DBPerformance log warnings in onUserLogout() mediawiki/extensions/CentralAuth master +6 -5
Avoid DBPerformance warnings in writeToDatabase() mediawiki/extensions/Math master +10 -8
Avoid DBPerformance warnings in Category::initialize() mediawiki/core master +5 -1
Avoid master queries/writes in listUnattached() mediawiki/extensions/CentralAuth master +29 -27
Avoid master queries on HTTP GET in getVisibilitySettingsFromRow() mediawiki/extensions/FlaggedRevs master +0 -1
Avoid DBPerformance warnings on PURGE/TRACE requests mediawiki/core master +33 -21
Avoid master connection in recacheMessageCount() mediawiki/extensions/LiquidThreads master +1 -1
Avoid master queries on GET in showPermissionError() mediawiki/extensions/Wikibase master +5 -2
Fix central logout mediawiki/extensions/CentralAuth wmf/1.28.0-wmf.2 +3 -2
Defer DB update in showEnrollmentView() mediawiki/extensions/EducationProgram master +4 -1
Revert "Avoid DBPerformance log warnings in onUserLogout()" mediawiki/extensions/CentralAuth master +5 -6
Use DeferredUpdates in queueUpdates() mediawiki/extensions/Translate master +10 -9
Defer DB update in NewUserMessagesView mediawiki/extensions/LiquidThreads master +4 -1
Avoid master queries in GET in onProtectionForm() mediawiki/extensions/FlaggedRevs master +2 -1
Convert the top X reviewers cache to the main stash mediawiki/extensions/FlaggedRevs master +29 -27
Avoid master queries on GET in ProtectionForm mediawiki/core master +3 -1
Defer DB writes in SpecialNewMessages mediawiki/extensions/LiquidThreads master +3 -1
Avoid master queries in getAutoDeleteReason() mediawiki/core master +4 -4
Avoid DBPerformance log warnings in saveNamespaces() mediawiki/core master +4 -1
Avoid master queries on page views in loadFilterData() mediawiki/extensions/AbuseFilter master +3 -1
Avoid master queries on page view in lazyImportLocalNames() mediawiki/extensions/CentralAuth master +9 -11
Avoid always using DB_MASTER with ?CentralAuthLatest=1 mediawiki/extensions/CentralAuth master +11 -2
Avoid incorrectly setting mFromMaster to true mediawiki/extensions/CentralAuth master +9 -10
Defer the user save in onCustomEditor() to post-send mediawiki/extensions/VisualEditor master +3 -1
Avoid master queries on deletion form view mediawiki/core master +4 -2
Avoid master queries on GET requests for blocking mediawiki/extensions/VisualEditor master +1 -1
Use DB_SLAVE in TranslatablePage for GET request mediawiki/extensions/Translate master +25 -10
Avoid master queries in Title::getLinksFrom() mediawiki/core master +3 -7
Avoid DB master block table queries on view mediawiki/extensions/LiquidThreads master +3 -3
Move category refreshes to a deferred update mediawiki/core master +1 -1
Avoid calling Block::deleteIfExpired() when not needed mediawiki/core master +2 -2
resourceloader: Migrate from msg_resource table to object cache mediawiki/core wmf/1.27.0-wmf.8 +266 -419
resourceloader: Migrate from msg_resource table to object cache mediawiki/core master +266 -419
Defer the redirect table update in WikiPage::insertRedirect() mediawiki/core master +33 -17
Allow for CentralAuthUser::loadState() to generally use DB slaves mediawiki/extensions/CentralAuth master +133 -30
Use DB slaves for Campaign reads on GET requests mediawiki/extensions/CentralNotice master +24 -21
Defer the ApiTranslateUser::trackGroup saveSettings() call mediawiki/extensions/Translate master +4 -1
Defer the user update in enableCXBetaFeature() mediawiki/extensions/ContentTranslation master +4 -1
Defer the User::saveSettings call in getPreferences() mediawiki/extensions/BetaFeatures master +4 -1
Avoid master queries on image history view mediawiki/core master +6 -9
Defer the User::saveSettings() call in TopicListBlock mediawiki/extensions/Flow master +4 -1
Also defer the markRead() master updates mediawiki/extensions/Echo master +7 -8
Defer "lastuse" preference updates mediawiki/extensions/PageTriage master +5 -3
Defer the "seen time" updates on GET requests mediawiki/extensions/Echo master +3 -1
Defer User::saveSettings() updates on watchlist view mediawiki/extensions/MobileFrontend master +3 -1
Defer "language" preference update mediawiki/extensions/UniversalLanguageSelector master +5 -2
Default the "watchlisttoken" value to a derived HMAC value mediawiki/core master +14 -5
Set watchlisttoken preference on account creation mediawiki/core master +3 -0
Defer the resetAuthToken() call on logout mediawiki/extensions/CentralAuth master +3 -1
Removed READ_LATEST from revision load in getMsgFromNamespace() mediawiki/core master +1 -3
Suppress DBPerformance log during account autocreation mediawiki/extensions/CentralAuth master +3 -0
Removed pointless Title::GAID_FOR_UPDATE for altBaseRevId field mediawiki/extensions/FlaggedRevs master +1 -1
Use quickUserCan() in showHeader() to avoid master queries mediawiki/extensions/LiquidThreads master +3 -2
Defer "remember" preference updates mediawiki/extensions/CentralAuth master +6 -3
Ignore DBPerformance thresholds in Special:ConfirmEmail mediawiki/core master +8 -0
Supress DBPerformance log entries from OAI special page mediawiki/extensions/OAI master +2 -0
Defer clearTalkNotification() updates as they often happen on GET requests mediawiki/extensions/Echo master +4 -1
Avoid using DB_MASTER in SpecialEditWatchlist::getWatchlist() mediawiki/core master +4 -1
Defer spreadAnyEditBlock() post-send mediawiki/core master +7 -2
Defer the saveSettings() call in onMakeGlobalVariablesScript() mediawiki/extensions/GettingStarted master +5 -1
Made User::loadFromId() use READ_NORMAL by default mediawiki/core master +1 -1
Made User generally use DB_SLAVE by default mediawiki/core master +28 -39
Replace prior fix for view-time master manipulation in transcodes mediawiki/extensions/TimedMediaHandler master +30 -10
Moved ActiveUsers updates to recent changes jobs mediawiki/core REL1_25 +150 -174
Moved ActiveUsers updates to recent changes jobs mediawiki/core master +150 -174
Removed DB updates in updateJobQueue mediawiki/extensions/TimedMediaHandler master +35 -63
Avoid doing DB link updates on page view mediawiki/extensions/FlaggedRevs master +67 -21
Avoid constant master ipblocks queries on page views mediawiki/extensions/LiquidThreads master +8 -7
Made replaceSectionContent try to use DB_SLAVE mediawiki/core master +12 -2
Avoid calling purgeExpiredConfigurations() on page views mediawiki/extensions/FlaggedRevs master +7 -11
Avoid master queries on SpecialBlockList mediawiki/core master +4 -5
Made getWatchlistInfo use DB_SLAVE mediawiki/core master +1 -1
Avoid DB_MASTER in replaceSectionAtRev() mediawiki/core master +1 -4
Use DB_SLAVE in a few places mediawiki/extensions/CodeReview master +2 -2
Track request method in dbperformance.log mediawiki/core wmf/1.25wmf23 +4 -1
Track request method in dbperformance.log mediawiki/core wmf/1.25wmf24 +4 -1
Track request method in dbperformance.log mediawiki/core master +3 -1
Skin: Account for User::newFromName returning false mediawiki/core master +7 -3
Made Skin::getRelevantUser use READ_NORMAL mediawiki/core master +1 -0
Switched to using User::touch() to avoid DB write spam mediawiki/extensions/CentralAuth master +1 -3
Avoid using DB_MASTER in makeLikeArray mediawiki/core master +1 -1
Removed view event from $wgAutopromoteOnce mediawiki/core master +3 -12
Avoid needless master queries on page views mediawiki/extensions/MobileFrontend master +1 -0
Introduced User::touch() method to bump the getTouched() value using memcached mediawiki/core master +50 -4
Avoid master queries on edit form views mediawiki/extensions/ConfirmEdit master +9 -4
Allow callers to load user objects from slaves if desired mediawiki/core master +25 -10
Avoid master queries on page view for block checks mediawiki/extensions/MobileFrontend master +1 -1
Made getNewtalk use slaves instead of cache/master mediawiki/core master +1 -11
Avoid excess master queries in getTimestampFromId mediawiki/core master +12 -12
Avoid pointless block table master queries mediawiki/extensions/LiquidThreads master +1 -1
Show related patches Customize query in gerrit

Related Objects
Search...

Status Subtype Assigned Task
Resolved aaron T88445 MediaWiki active/active datacenter investigation and work (tracking)
Open None T92357 Fix database master queries from HTTP GET/HEAD before active-active multi-dc
Resolved aude T94030 Avoid opening master db connection on special pages (e.g. Special:NewItem) when not needed
Duplicate • Gilles T95156 Wikidata needlessly queries master DB to populate deprecated wbUserIsBlocked JS variable
Duplicate aaron T95232 High frequency of master queries on GET requests due to Flow
Resolved aaron T95753 Translate extensions uses the master a lot on page views
Duplicate None T70530 Many INSERT queries on some web requests
Resolved hoo T103429 Investigation: Parser save hook handler does master writes in GETs
Duplicate None T110399 WikiPageEntityMetaDataLookup querying DB master on HTTP GET
Duplicate None T138376 Avoid falling back to master when loading page data in GET requests
Resolved aaron T119689 Enable $wgCentralAuthUseSlaves to avoid master queries
Open None T122708 ShortUrl must not write to master db on page views (DBPerformance warning)
Open None T256993 Deploy read-only mode for ShortUrl
Resolved PRODUCTION ERROR aaron T129973 Dig through logs from 15 Mar 2016 read-only test and file bugs
Duplicate None T133422 DB master queries for entities on parse
Resolved aaron T134608 CentralAuth uses master on POST requests for API/specialpages that return false for doesWrites()
Resolved Nikerabbit T134841 MessageGroupStats::queueUpdates trigger on page views
Resolved aaron T134842 SpecialCentralAutoLogin calls User::saveSettings() on HTTP GET presend
Resolved aaron T135170 Require POST in ?action=purge
Duplicate None T143435 Purge asks for "Clear the cache of this page" for logged in users with the "purge" right
Duplicate None T144524 problem with Purge function
Resolved MarcoAurelio T215131 The "right-purge" message needs to be updated since it always require confirmation
Resolved aaron T136224 OATHAuth doing DB master queries on HTTP GET
Resolved tstarling T154554 AbuseFilter "Examine past edits" feature opens master conn on GET in certain cases involving Scribunto
Resolved Ladsgroup T154555 Special:SetSiteLink, other SpecialModifyEntity subclasses open master connection on GET
Resolved Krinkle T154556 Babel autocreates category and system user on GET
Duplicate aaron T154596 SpecialModifyEntity master queries on page views
Resolved kostajh T154719 PageTriage opens master connection on GET for ArticleMetadata cache misses
Resolved Huji T154795 CheckUser opens DB master connection when email is sent
Resolved aaron T179760 File metadata gets refreshed when accessing the file description page
Resolved aaron T151903 Special:Search performs DB writes on GET request
Resolved aaron T188801 Migrate wl_notificationtimestamp updates to the job queue
Open PRODUCTION ERROR None T216287 BannerMessageGroup::registerGroupHook of CentralNotice must not query master on GET request (page views)

Event Timeline

There are a very large number of changes, so older changes are hidden. Show Older Changes
Catrope added a subtask: T154556: Babel autocreates category and system user on GET.Jan 4 2017, 1:53 AM
aaron created subtask T154596: SpecialModifyEntity master queries on page views.Jan 4 2017, 5:38 PM
Catrope added a subtask: T154719: PageTriage opens master connection on GET for ArticleMetadata cache misses.Jan 5 2017, 11:40 PM
Catrope added a subtask: T154795: CheckUser opens DB master connection when email is sent.Jan 6 2017, 6:34 PM
gerritbot added a comment.Apr 13 2017, 1:18 AM

Change 348030 had a related patch set uploaded (by Aaron Schulz):
[mediawiki/extensions/CentralAuth@master] Make opportunistic password hash upgrades post-send

https://gerrit.wikimedia.org/r/348030
gerritbot removed a project: MW-1.28-release (WMF-deploy-2016-10-25_(1.28.0-wmf.23)).Apr 13 2017, 1:18 AM
gerritbot added a comment.Apr 13 2017, 7:31 PM

Change 348030 merged by jenkins-bot:
[mediawiki/extensions/CentralAuth@master] Make opportunistic password hash upgrades post-send

https://gerrit.wikimedia.org/r/348030
ReleaseTaggerBot added a project: MW-1.29-release (WMF-deploy-2017-04-25_(1.29.0-wmf.21)).Apr 13 2017, 8:00 PM
gerritbot added a comment.Apr 18 2017, 12:41 AM

Change 348658 had a related patch set uploaded (by Aaron Schulz):
[mediawiki/extensions/CentralAuth@master] Avoid triggering master queries in ApiValidatePassword

https://gerrit.wikimedia.org/r/348658
gerritbot added a comment.Apr 29 2017, 5:11 AM

Change 350969 had a related patch set uploaded (by Aaron Schulz; owner: Aaron Schulz):
[mediawiki/core@master] Avoid master queries in loadAndLazyInit() for miser mode

https://gerrit.wikimedia.org/r/350969
gerritbot added a comment.May 1 2017, 11:24 PM

Change 350969 merged by jenkins-bot:
[mediawiki/core@master] Avoid master queries in loadAndLazyInit() for miser mode

https://gerrit.wikimedia.org/r/350969
ReleaseTaggerBot added a project: MW-1.30-release-notes (WMF-deploy-2017-05-09_(1.30.0-wmf.1)).May 2 2017, 12:00 AM
Krinkle edited projects, added Multiple-active-datacenters archived; removed Wikimedia-Multiple-active-datacenters, Sustainability.May 3 2017, 7:37 PM
Krinkle moved this task from Backlog to Doing on the Multiple-active-datacenters archived board.May 3 2017, 7:52 PM
Krinkle edited projects, added Sustainability (MediaWiki-MultiDC); removed Multiple-active-datacenters archived.May 3 2017, 7:58 PM
Krinkle moved this task from Later to Current: Performance Team on the Sustainability (MediaWiki-MultiDC) board.May 3 2017, 8:00 PM
gerritbot added a comment.May 5 2017, 3:27 AM

Change 351790 had a related patch set uploaded (by Krinkle; owner: Aaron Schulz):
[mediawiki/extensions/CentralAuth@master] Add $flags parameter to renameInProgressOn()

https://gerrit.wikimedia.org/r/351790
Krinkle merged a task: T88144: Avoid master queries on HEAD/GET MediaWiki requests.May 5 2017, 3:27 AM
Krinkle removed projects: MW-1.29-release (WMF-deploy-2017-04-25_(1.29.0-wmf.21)), MW-1.28-release (WMF-deploy-2016-09-13_(1.28.0-wmf.19)), MW-1.28-release-notes.
Krinkle added a subscriber: • brooke.
gerritbot added a comment.May 5 2017, 3:30 AM

Change 351790 merged by jenkins-bot:
[mediawiki/extensions/CentralAuth@master] Add $flags parameter to renameInProgressOn()

https://gerrit.wikimedia.org/r/351790
gerritbot added a comment.May 14 2017, 10:49 PM

Change 353823 had a related patch set uploaded (by Aaron Schulz; owner: Aaron Schulz):
[mediawiki/extensions/CentralAuth@master] Avoid master queries in beginSecondaryAuthentication()

https://gerrit.wikimedia.org/r/353823
gerritbot added a comment.May 14 2017, 11:46 PM

Change 353824 had a related patch set uploaded (by Aaron Schulz; owner: Aaron Schulz):
[mediawiki/extensions/PageTriage@master] Avoid DB_MASTER queries on HTTP GET in ArticleMetadata->getMetadata

https://gerrit.wikimedia.org/r/353824
gerritbot added a comment.May 14 2017, 11:51 PM

Change 353825 had a related patch set uploaded (by Aaron Schulz; owner: Aaron Schulz):
[mediawiki/extensions/CentralAuth@master] Avoid master queries in SpecialGlobalRenameProgress

https://gerrit.wikimedia.org/r/353825
gerritbot added a comment.May 14 2017, 11:56 PM

Change 353827 had a related patch set uploaded (by Aaron Schulz; owner: Aaron Schulz):
[mediawiki/core@master] Avoid DB_MASTER queries in User::newSystemUser() when possible

https://gerrit.wikimedia.org/r/353827
gerritbot added a comment.May 15 2017, 12:25 AM

Change 353829 had a related patch set uploaded (by Aaron Schulz; owner: Aaron Schulz):
[mediawiki/extensions/Translate@master] Use TranslateUtils::getSafeReadDB() in loadAggregateGroups

https://gerrit.wikimedia.org/r/353829
gerritbot added a comment.May 16 2017, 10:06 AM

Change 353824 merged by jenkins-bot:
[mediawiki/extensions/PageTriage@master] Avoid DB_MASTER queries on HTTP GET in ArticleMetadata->getMetadata

https://gerrit.wikimedia.org/r/353824
ReleaseTaggerBot edited projects, added MW-1.30-release-notes (WMF-deploy-2017-05-23_(1.30.0-wmf.2)); removed MW-1.30-release-notes (WMF-deploy-2017-05-09_(1.30.0-wmf.1)).May 16 2017, 11:00 AM
gerritbot added a comment.May 20 2017, 10:22 AM

Change 353829 merged by jenkins-bot:
[mediawiki/extensions/Translate@master] Use TranslateUtils::getSafeReadDB() in loadAggregateGroups

https://gerrit.wikimedia.org/r/353829
gerritbot added a comment.May 24 2017, 5:58 PM

Change 353825 merged by jenkins-bot:
[mediawiki/extensions/CentralAuth@master] Avoid master queries in SpecialGlobalRenameProgress

https://gerrit.wikimedia.org/r/353825
ReleaseTaggerBot edited projects, added MW-1.30-release-notes (WMF-deploy-2017-05-30_(1.30.0-wmf.3)); removed MW-1.30-release-notes (WMF-deploy-2017-05-23_(1.30.0-wmf.2)).May 24 2017, 6:00 PM
Krinkle changed the status of subtask T88044: Make rollback use POST instead of GET (use AJAX in GUI) from Open to Stalled.May 26 2017, 5:09 PM
gerritbot added a comment.Jun 3 2017, 5:16 AM

Change 353827 merged by jenkins-bot:
[mediawiki/core@master] Avoid DB_MASTER queries in User::newSystemUser() when possible

https://gerrit.wikimedia.org/r/353827
ReleaseTaggerBot edited projects, added MW-1.30-release-notes; removed MW-1.30-release-notes (WMF-deploy-2017-05-30_(1.30.0-wmf.3)).Jun 3 2017, 6:00 AM
Seb35 subscribed.Jun 3 2017, 6:48 AM
gerritbot added a comment.Jun 9 2017, 4:17 AM

Change 353823 merged by jenkins-bot:
[mediawiki/extensions/CentralAuth@master] Avoid master queries in beginSecondaryAuthentication()

https://gerrit.wikimedia.org/r/353823
ReleaseTaggerBot edited projects, added MW-1.30-release-notes (WMF-deploy-2017-06-13_(1.30.0-wmf.5)); removed MW-1.30-release-notes.Jun 9 2017, 5:00 AM
gerritbot added a comment.Jun 9 2017, 5:40 AM

Change 348658 merged by jenkins-bot:
[mediawiki/extensions/CentralAuth@master] Avoid triggering master queries in ApiValidatePassword

https://gerrit.wikimedia.org/r/348658
Huji closed subtask T154795: CheckUser opens DB master connection when email is sent as Resolved.Aug 28 2017, 12:33 PM
Ladsgroup closed subtask T154555: Special:SetSiteLink, other SpecialModifyEntity subclasses open master connection on GET as Resolved.Sep 20 2017, 11:02 AM
Ciencia_Al_Poder mentioned this in T173360: PHP Notice: Undefined index: frameCount.Nov 4 2017, 2:45 PM
Ciencia_Al_Poder added a subtask: T179760: File metadata gets refreshed when accessing the file description page.Nov 4 2017, 2:52 PM
tstarling closed subtask T154554: AbuseFilter "Examine past edits" feature opens master conn on GET in certain cases involving Scribunto as Resolved.Feb 21 2018, 3:19 AM
tstarling added a subtask: T151903: Special:Search performs DB writes on GET request.Feb 21 2018, 5:01 AM
Krinkle closed subtask T154556: Babel autocreates category and system user on GET as Resolved.Mar 30 2018, 4:46 AM
aaron removed a project: MW-1.30-release-notes (WMF-deploy-2017-06-13_(1.30.0-wmf.5)).Jul 16 2018, 9:12 PM
Etonkovidova closed subtask T154719: PageTriage opens master connection on GET for ArticleMetadata cache misses as Resolved.Aug 22 2018, 10:57 PM
Krinkle mentioned this in T203283: Special:CreateAccount causes ApiValidatePassword to log a DBPerformance warning from CentralAuth.Aug 31 2018, 9:21 PM
Pginer-WMF closed subtask T134841: MessageGroupStats::queueUpdates trigger on page views as Resolved.Nov 27 2018, 8:37 AM
Krinkle merged a task: T88143: Move writes on read requests to the job queue.Feb 10 2019, 12:17 AM
Krinkle added subscribers: Catrope, ori.
Krinkle added a subtask: T216287: BannerMessageGroup::registerGroupHook of CentralNotice must not query master on GET request (page views).Feb 19 2019, 12:31 AM
aaron closed subtask T188801: Migrate wl_notificationtimestamp updates to the job queue as Resolved.Mar 15 2019, 5:11 PM
gerritbot added a comment.Mar 29 2019, 5:39 AM

Change 499969 had a related patch set uploaded (by Aaron Schulz; owner: Aaron Schulz):
[mediawiki/core@master] Use the main stash for basic user talk page notifications

https://gerrit.wikimedia.org/r/499969
gerritbot added a comment.Mar 29 2019, 8:14 AM

Change 499985 had a related patch set uploaded (by Aaron Schulz; owner: Aaron Schulz):
[mediawiki/core@master] Add UserOptionsUpdateJob class and use it for namespaces at SpecialSearch

https://gerrit.wikimedia.org/r/499985
gerritbot added a comment.Mar 29 2019, 8:44 AM

Change 499990 had a related patch set uploaded (by Aaron Schulz; owner: Aaron Schulz):
[mediawiki/extensions/NewUserMessage@master] Use a job for triggering new user talk messages

https://gerrit.wikimedia.org/r/499990
gerritbot added a comment.Mar 29 2019, 9:33 AM

Change 499995 had a related patch set uploaded (by Aaron Schulz; owner: Aaron Schulz):
[mediawiki/core@master] [WIP] Avoid Category count refresh DB writes on HTTP GET

https://gerrit.wikimedia.org/r/499995
aaron closed subtask T179760: File metadata gets refreshed when accessing the file description page as Resolved.Apr 1 2019, 7:54 PM
Legoktm mentioned this in T220923: URL Shortener should not obfuscate important links.Apr 14 2019, 8:48 PM
gerritbot added a comment.Apr 23 2019, 9:00 PM

Change 499990 merged by jenkins-bot:
[mediawiki/extensions/NewUserMessage@master] Use a job for triggering new user talk messages

https://gerrit.wikimedia.org/r/499990
ReleaseTaggerBot added a project: MW-1.34-notes (1.34.0-wmf.3; 2019-04-30).Apr 23 2019, 10:00 PM
gerritbot added a comment.May 8 2019, 8:41 PM

Change 499985 abandoned by Aaron Schulz:
Add UserOptionsUpdateJob class and use it for namespaces at SpecialSearch

Reason:
Taking a different route

https://gerrit.wikimedia.org/r/499985
aaron closed subtask T151903: Special:Search performs DB writes on GET request as Resolved.May 8 2019, 10:08 PM
aaron removed aaron as the assignee of this task.May 21 2019, 9:04 PM
aaron removed a project: Patch-For-Review.
• Lucas_Werkmeister_WMDE subscribed.Jun 14 2019, 4:15 PM
Krinkle mentioned this in T36156: SiteStatsInit::refresh() triggered inappropriately, caused downtime.Jun 27 2019, 10:13 PM
Krinkle renamed this task from Fix problematic database master queries performed on HTTP GET/HEAD to Fix database master queries from HTTP GET/HEAD before active-active multid-dc.Jul 2 2020, 2:53 PM
Krinkle removed a subtask: T88044: Make rollback use POST instead of GET (use AJAX in GUI).
Krinkle mentioned this in T88044: Make rollback use POST instead of GET (use AJAX in GUI).
Krinkle removed a project: MW-1.34-notes (1.34.0-wmf.3; 2019-04-30).
Krinkle added a project: Performance-Team.Jul 2 2020, 2:55 PM
Krinkle subscribed.

I'm slightly rescoping this to give the tracking task a natural end, namely to only track that which we want to get done prior to starting to serve active-active. For the rest we can file individual Sustainability and/or Performance Issue tasks that we might track on our Performance-Team (Radar)
Krinkle renamed this task from Fix database master queries from HTTP GET/HEAD before active-active multid-dc to Fix database master queries from HTTP GET/HEAD before active-active multi-dc.Jul 2 2020, 4:08 PM
Krinkle changed the status of subtask T154552: ApiLogin should not open master connection to centralauth DB from Open to Stalled.Jul 2 2020, 4:15 PM
Krinkle claimed this task.Jul 6 2020, 8:20 PM
Krinkle reassigned this task from Krinkle to aaron.
Krinkle moved this task from Inbox, needs triage to Doing (old) on the Performance-Team board.
aaron removed a subtask: T154552: ApiLogin should not open master connection to centralauth DB.Jul 16 2020, 9:01 PM
Krinkle moved this task from Doing (old) to To-do: Goals prioritized current Quarter on the Performance-Team board.Jul 20 2020, 8:22 PM
DannyS712 updated the task description. (Show Details)Sep 12 2020, 2:19 AM
DannyS712 subscribed.
Krinkle moved this task from Current: Performance Team to Later on the Sustainability (MediaWiki-MultiDC) board.Dec 22 2020, 10:41 PM
RhinosF1 subscribed.Jan 25 2021, 8:36 PM
Krinkle moved this task from To-do: Goals prioritized current Quarter to Backlog: Maintenance, non-prioritized on the Performance-Team board.Mar 2 2021, 9:33 PM
kostajh mentioned this in T302638: Sunset ApiFeatureUsage (TDMP).Feb 28 2022, 10:44 AM
gerritbot added a comment.Mar 22 2022, 4:40 AM

Change 499995 abandoned by Aaron Schulz:

[mediawiki/core@master] [WIP] Avoid Category count refresh DB writes on HTTP GET

Reason:

https://gerrit.wikimedia.org/r/499995
Krinkle closed subtask T134842: SpecialCentralAutoLogin calls User::saveSettings() on HTTP GET presend as Resolved.Apr 5 2022, 1:58 AM
tstarling mentioned this in T196378: Investigate solutions for MySQL connection pooling.May 25 2022, 11:54 PM
Aklapper removed aaron as the assignee of this task.Sep 26 2022, 10:33 AM
Aklapper removed a subscriber: • Gilles.

Removing task assignee due to inactivity as this open task has been assigned for more than two years. See the email sent to the task assignee on August 22nd, 2022.
Please assign this task to yourself again if you still realistically [plan to] work on this task - it would be welcome!
If this task has been resolved in the meantime, or should not be worked on ("declined"), please update its task status via "Add Action… 🡒 Change Status".
Also see https://www.mediawiki.org/wiki/Bug_management/Assignee_cleanup for tips how to best manage your individual work in Phabricator. Thanks!
gerritbot added a comment.Oct 5 2022, 9:09 PM

Change 499969 abandoned by Aaron Schulz:

[mediawiki/core@master] Use the main stash for basic user talk page notifications

Reason:

https://gerrit.wikimedia.org/r/499969
Bugreporter mentioned this in T355916: One-click email unsubscribe service in MediaWiki core.Jan 26 2024, 3:55 AM
Krinkle edited projects, added Wikimedia-Performance-recommendation; removed Performance-Team.Mar 10 2024, 2:31 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL