Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[css-fonts][css-multicol][css-scroll-anchoring][css-scrollbars][css-shapes][css-size-adjust][css-transforms][css-ui] Update Computed Value and Animation lines to new format. #3198

Merged
merged 2 commits into from Nov 15, 2018

Conversation

tabatkins
Copy link
Member

Update a bunch of propdefs' Computed Value and Animation lines to the new format.

@litherum @frivoal @dirkschulze @rachelandrew @upsuper @astearns @dbaron Please review your respective specs; we'll merge when everyone gets a review in.

Copy link
Member

@upsuper upsuper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes to css-scrollbars look good to me.

Copy link
Contributor

@svgeesus svgeesus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes to fonts 4 look good to me.
Changes to fonts 3 (Fonts.html) look fine too but will need to be merged in as errata first (and manually, because the .src.html diverged from the final version of the spec).

css-ui-4/Overview.bs Outdated Show resolved Hide resolved
@frivoal
Copy link
Collaborator

Multicol 1 & 2, as well as css-ui 3 and 4 OK, except for 1 comment: #3198 (comment)

@fantasai
Copy link
Collaborator

fantasai commented Oct 9, 2018

@svgeesus Could you clarify if you're requesting changes to this patch before merging, or if your comment is about something else that needs to happen outside of the changes to these files in this repository? (IIRC I edited the .src.html source and the .html output directly so whatever's in sync or not is still in sync or not as before.)

@svgeesus
Copy link
Contributor

I'm not requesting changes to the patch. I'm just saying that updating the files here doesn't update the Rec, and that the .src.html format is a pain in the ass.

(sent in a hurry while on vacation)

Copy link
Member

@dbaron dbaron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

css-size-adjust change looks fine

Copy link
Member

@astearns astearns left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, one nitpick you can fix or leave as-is

css-shapes-2/Overview.bs Outdated Show resolved Hide resolved
tabatkins and others added 2 commits November 15, 2018 11:21
…hapes][css-size-adjust][css-transforms][css-ui] Update Computed Value and Animation lines to new format.
@frivoal
Copy link
Collaborator

Fixed the things that were asked for during the review, and resolved the conflicts. Merging.

@frivoal frivoal merged commit 6bcd8e8 into w3c:master Nov 15, 2018
@frivoal
Copy link
Collaborator

@svgeesus , It's your turn to deal with fonts-3, as you mentioned in #3198 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

8 participants