New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upstream change from Trusted Types #1709
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
@domenic seeing as you've looked at some of the other upstreaming PRs, I don't suppose you have review rights on this spec do you? |
I do not, sorry! @mkruisselbrink is the active editor. |
lukewarlow force-pushed the trusted-types branch from
April 22, 2024 13:31
c1a974d
to 00574a6
Compare
lukewarlow changed the title
Upstream IDL change from Trusted Types
Upstream change from Trusted Types
Apr 22, 2024
Changes register to take a union of (TrustedScriptURL or USVString) rather than just a USVString. Updates the register method steps to call Get Trusted Type compliant string
lukewarlow force-pushed the trusted-types branch from
April 22, 2024 13:53
00574a6
to 4242fab
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
sorry for the slow response, this lgtm
github-actions bot added a commit that referenced this pull request
Apr 30, 2024
SHA: 8ac9c66 Reason: push, by mkruisselbrink Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
No worries, thank you! |
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Changes register to take a union of (TrustedScriptURL or USVString) rather than just a USVString.
Updates the register method steps to call Get Trusted Type compliant string
Tested in https://wpt.live/trusted-types/WorkerGlobalScope-importScripts.html
Fixes #1710
Preview | Diff