Hooks::register( 'Hook', [ self::class, 'onHook' ] ) doesn't work as expected
Closed, ResolvedPublic

Actions

Assigned To

Authored By

	Reedy
	May 24 2021, 8:56 PM

Description

Forking from T283539: Error: Call to undefined function MediaWiki\Extension\Interwiki\Hooks(), but I know it's an issue I've seen before, and given up and just left the stringified class name behind

https://github.com/wikimedia/mediawiki-extensions-Interwiki/blob/7bb8875/includes/Hooks.php#L45

In this case, using [ self::class, 'onInterwikiLoadPrefix' ] results in an error like Error: Call to undefined function MediaWiki\Extension\Interwiki\Hooks()

Details

Subject	Repo	Branch	Lines +/-
HookContainer: Fix normalization of callback for static handler	mediawiki/core	REL1_36	+15 -3
HookContainer: Fix normalization of callback for static handler	mediawiki/core	REL1_35	+15 -3
HookContainer: Fix normalization of callback for static handler	mediawiki/core	master	+15 -3

Customize query in gerrit

Related Objects

Mentioned In: T283539: Error: Call to undefined function MediaWiki\Extension\Interwiki\Hooks()
Mentioned Here: T283539: Error: Call to undefined function MediaWiki\Extension\Interwiki\Hooks()

Event Timeline

Reedy created this task.May 24 2021, 8:56 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMay 24 2021, 8:56 PM

Reedy mentioned this in T283539: Error: Call to undefined function MediaWiki\Extension\Interwiki\Hooks().May 24 2021, 9:54 PM

Jdforrester-WMF subscribed.May 25 2021, 12:46 AM

Ammarpad renamed this task from MWHooks::register( 'Hook', [ self::class, 'onHook' ] ) doesn't work as expected to Hooks::register( 'Hook', [ self::class, 'onHook' ] ) doesn't work as expected.May 25 2021, 5:34 AM

Ammarpad claimed this task.May 25 2021, 8:26 AM

Change 694595 had a related patch set uploaded (by Ammarpad; author: Ammarpad):

[mediawiki/core@master] HookContainer: Fix normalization of callback for static handler

https://gerrit.wikimedia.org/r/694595

gerritbot added a project: Patch-For-Review.May 25 2021, 5:30 PM

Reedy added projects: MW-1.35-release, MW-1.36-release.May 25 2021, 8:41 PM

Change 695317 had a related patch set uploaded (by Reedy; author: Ammarpad):

[mediawiki/core@REL1_35] HookContainer: Fix normalization of callback for static handler

https://gerrit.wikimedia.org/r/695317

Change 695318 had a related patch set uploaded (by Reedy; author: Ammarpad):

[mediawiki/core@REL1_36] HookContainer: Fix normalization of callback for static handler

https://gerrit.wikimedia.org/r/695318

Change 694595 merged by jenkins-bot:

[mediawiki/core@master] HookContainer: Fix normalization of callback for static handler

https://gerrit.wikimedia.org/r/694595

ReleaseTaggerBot added a project: MW-1.37-notes (1.37.0-wmf.9; 2021-06-07).May 26 2021, 7:00 PM

Reedy closed this task as Resolved.May 26 2021, 7:20 PM

Change 695317 merged by jenkins-bot:

[mediawiki/core@REL1_35] HookContainer: Fix normalization of callback for static handler

https://gerrit.wikimedia.org/r/695317

Change 695318 merged by jenkins-bot: