Page MenuHomePhabricator
Create Task
Maniphest T321503

[structured mentor list] Replace action=growthsetmentorstatus with action=growthmanagementorlist
Closed, ResolvedPublic
Actions

Description

Thanks to T264343 / structured mentor list, we now have an "umbrella API endpoint" to manage information about mentors. Once the structured mentor list gets deployed (T310905), we should replace action=growthsetmentorstatus with action=growthmanagementorlist.

Checklist:

Details

Subject Repo Branch Lines +/-
Remove ApiSetMentorStatus mediawiki/extensions/GrowthExperiments master +0 -137
Mentor dashboard: Deprecate ApiSetMentorStatus mediawiki/extensions/GrowthExperiments master +52 -40
[i18n] Add missing documentation for action=growthmanagementorlist API mediawiki/extensions/GrowthExperiments master +4 -0
Customize query in gerrit

Related Objects
Search...

Event Timeline

Urbanecm_WMF created this task.Oct 24 2022, 4:39 PM
Restricted Application added a project: Growth-Team. · View Herald TranscriptOct 24 2022, 4:39 PM
Restricted Application added a subscriber: Aklapper. · View Herald Transcript
Urbanecm_WMF triaged this task as Low priority.Oct 24 2022, 4:39 PM
Urbanecm_WMF added a parent task: T321501: Post-structured mentor list cleanup.
Urbanecm_WMF moved this task from Inbox to Upcoming Work on the Growth-Team board.Oct 25 2022, 10:16 PM
MShilova_WMF moved this task from New Tasks to Needs Discussion / Blocked on the GrowthExperiments-Mentorship board.Oct 26 2022, 5:43 PM
MShilova_WMF moved this task from Upcoming Work to Triaged on the Growth-Team board.Nov 7 2022, 6:20 PM
kostajh moved this task from Needs Discussion / Blocked to Backlog on the GrowthExperiments-Mentorship board.Feb 7 2023, 9:29 AM
kostajh added a parent task: T323132: [Epic] Q3 FY 2022-23 Growth Maintenance Work.
kostajh added a project: Essential-Work.
DMburugu edited parent tasks, added: T333335: [Epic] Q4 FY 2022-23 Growth Maintenance Work; removed: T323132: [Epic] Q3 FY 2022-23 Growth Maintenance Work.Mar 28 2023, 2:28 PM
DMburugu edited parent tasks, added: T340455: [Epic] Q1 FY 2023-24 Growth Maintenance Work; removed: T333335: [Epic] Q4 FY 2022-23 Growth Maintenance Work.Jun 26 2023, 5:08 PM
gerritbot added a comment.Jul 6 2023, 9:21 PM

Change 936090 had a related patch set uploaded (by Urbanecm; author: Urbanecm):

[mediawiki/extensions/GrowthExperiments@master] Mentor dashboard: Deprecate ApiSetMentorStatus

https://gerrit.wikimedia.org/r/936090
gerritbot added a project: Patch-For-Review.Jul 6 2023, 9:21 PM
Urbanecm_WMF updated the task description. (Show Details)Jul 6 2023, 9:22 PM
Urbanecm_WMF updated the task description. (Show Details)
gerritbot added a comment.Jul 6 2023, 9:26 PM

Change 936091 had a related patch set uploaded (by Urbanecm; author: Urbanecm):

[mediawiki/extensions/GrowthExperiments@master] [i18n] Add missing documentation for action=growthmanagementorlist API

https://gerrit.wikimedia.org/r/936091
Urbanecm_WMF updated the task description. (Show Details)Jul 7 2023, 7:27 AM
Urbanecm_WMF claimed this task.Jul 7 2023, 11:19 AM
Urbanecm_WMF edited projects, added Growth-Team (Sprint 0 (Growth Team)); removed Growth-Team.
Maintenance_bot moved this task from Backlog to In Progress on the GrowthExperiments-Mentorship board.Jul 7 2023, 11:29 AM
Sgs changed the task status from Open to In Progress.Jul 7 2023, 12:21 PM
Sgs moved this task from Incoming to In Progress on the Growth-Team (Sprint 0 (Growth Team)) board.
gerritbot added a comment.Jul 10 2023, 12:30 PM

Change 936091 merged by jenkins-bot:

[mediawiki/extensions/GrowthExperiments@master] [i18n] Add missing documentation for action=growthmanagementorlist API

https://gerrit.wikimedia.org/r/936091
ReleaseTaggerBot added a project: MW-1.41-notes (1.41.0-wmf.17; 2023-07-11).Jul 10 2023, 1:00 PM
gerritbot added a comment.Jul 13 2023, 10:02 AM

Change 936090 merged by jenkins-bot:

[mediawiki/extensions/GrowthExperiments@master] Mentor dashboard: Deprecate ApiSetMentorStatus

https://gerrit.wikimedia.org/r/936090
Urbanecm_WMF updated the task description. (Show Details)Jul 13 2023, 10:02 AM
Maintenance_bot removed a project: Patch-For-Review.Jul 13 2023, 10:11 AM
Urbanecm_WMF added a project: User-notice.Jul 13 2023, 10:12 AM

Added a draft to the Tech news.

Summary for User-notice: The growthsetmentorstatus API will be deprecated in the wmf.18 train in favour of the growthmanagementorlist API, which can do everything growthsetmentorstatus can, plus a bunch of other things. It is likely the growthsetmentorstatus API will be fully removed fairly soon (we'll check usages before removing anything).
Urbanecm_WMF updated the task description. (Show Details)Jul 13 2023, 10:13 AM
Urbanecm_WMF moved this task from To Triage to In current Tech/News draft on the User-notice board.
Urbanecm_WMF changed the task status from In Progress to Stalled.Jul 13 2023, 10:16 AM
Urbanecm_WMF moved this task from In Progress to Blocked / Needs work on the Growth-Team (Sprint 0 (Growth Team)) board.

Now waiting on the announcement, wmf.18 train deployment and the waiting period. Starting Aug 1, we should check for usages and decide whether the endpoint can be safely removed.
ReleaseTaggerBot edited projects, added MW-1.41-notes (1.41.0-wmf.18; 2023-07-18); removed MW-1.41-notes (1.41.0-wmf.17; 2023-07-11).Jul 13 2023, 11:00 AM
Frostly moved this task from In current Tech/News draft to Already announced/Archive on the User-notice board.Jul 18 2023, 1:39 AM
Ayoub_ subscribed.Jul 18 2023, 5:18 AM
gerritbot added a comment.Aug 2 2023, 4:28 PM

Change 944956 had a related patch set uploaded (by Urbanecm; author: Urbanecm):

[mediawiki/extensions/GrowthExperiments@master] Remove ApiSetMentorStatus

https://gerrit.wikimedia.org/r/944956
gerritbot added a project: Patch-For-Review.Aug 2 2023, 4:28 PM
Urbanecm_WMF added a comment.Aug 2 2023, 4:28 PM 
In [2]: df = spark.run("SELECT COUNT(*) FROM event.mediawiki_api_request WHERE year=2023 AND (month=8 OR (month=7 AND day > 20)) AND params['action'] = 'growthsetmentorstatus'"); df
[...]
Out[2]: 
   count(1)
0         0
In [3]: df = spark.run("SELECT COUNT(*) FROM event.mediawiki_api_request WHERE year=2023 AND (month=8 OR (month=7 AND day > 20)) AND params['action'] = 'growthmanagementorlist'"); df
[...]

Seems like the old API is not used by external users at all (which matches expectations). Let's remove it!
Urbanecm_WMF changed the task status from Stalled to Open.Aug 2 2023, 4:29 PM
Urbanecm_WMF moved this task from Blocked / Needs work to Code Review on the Growth-Team (Sprint 0 (Growth Team)) board.
Urbanecm_WMF updated the task description. (Show Details)
gerritbot added a comment.Aug 14 2023, 8:27 AM

Change 944956 merged by jenkins-bot:

[mediawiki/extensions/GrowthExperiments@master] Remove ApiSetMentorStatus

https://gerrit.wikimedia.org/r/944956
Maintenance_bot removed a project: Patch-For-Review.Aug 14 2023, 8:29 AM
Urbanecm_WMF moved this task from Code Review to QA on the Growth-Team (Sprint 0 (Growth Team)) board.Aug 14 2023, 8:36 AM
ReleaseTaggerBot edited projects, added MW-1.41-notes (1.41.0-wmf.22; 2023-08-15); removed MW-1.41-notes (1.41.0-wmf.18; 2023-07-18).Aug 14 2023, 9:00 AM
Urbanecm_WMF closed this task as Resolved.Aug 14 2023, 9:30 AM
Urbanecm_WMF updated the task description. (Show Details)
Maintenance_bot edited projects, added User-notice-archive; removed User-notice.Aug 24 2023, 9:31 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL