Page MenuHomePhabricator

Show edit count at Special:Contributions
Closed, ResolvedPublicFeature

Description

This feature was voted #45 on the 2022 Community Wishlist Survey.

Problem: Edit counts are hard to determine unless you know about external tools and user scripts that show this information, or if you explicitly state how many edits you have on your userpage. Attempting to paginate through a user's contributions to count their edits can take a very long time if they have a very high edit count.

Proposed solution: Show a user's edit count at Special:Contributions, similar to how it is done on mobile web.

Note that some discussion around this in the past has been to introduce a new magic word; this feature is not that.

Event Timeline

There are a very large number of changes, so older changes are hidden. Show Older Changes

A possible design inspiration for this would be the work done by Growth on their new impact module.

Let me know if you need any reviews on the patch

FWIW, the gadget that does it in Persian Wikipedia adds a bit more info (I assumed it's copied from another wiki):

image.png (107×788 px, 19 KB)

literally translates to: "user, oversight, checkuser, blah blah, 16 years and 6 months age at wiki, xxxx number of edits, last edit was 38 minutes ago".

Maybe age, usergroups and last edit could be also incorporated?

FWIW, the gadget that does it in Persian Wikipedia adds a bit more info (I assumed it's copied from another wiki):

image.png (107×788 px, 19 KB)

literally translates to: "user, oversight, checkuser, blah blah, 16 years and 6 months age at wiki, xxxx number of edits, last edit was 38 minutes ago".

Maybe age, usergroups and last edit could be also incorporated?

It is https://meta.wikimedia.org/w/index.php?title=User:SMcCandlish/userinfo.js

Change 867281 had a related patch set uploaded (by Jdlrobson; author: Jdlrobson):

[mediawiki/core@master] [WIP] Add user stats box to top of Special:Contributions page

https://gerrit.wikimedia.org/r/867281

Test wiki created on Patch demo by Jdlrobson using patch(es) linked to this task:
https://patchdemo.wmflabs.org/wikis/0d42dd5cd7/w

Proposed solution: Show a user's edit count at Special:Contributions, similar to how it is done on mobile web.

I was a bit confused about this line here. The contributions page on mobile web never showed edit count to my knowledge? Is this referring to the way we styled the editor icon differently?

Screen Shot 2022-12-12 at 1.30.58 PM.png (587×903 px, 51 KB)

Here's the old code: https://gerrit.wikimedia.org/r/c/mediawiki/extensions/MobileFrontend/+/758567/2/includes/specials/SpecialMobileContributions.php

The mobile page is now identical to desktop page.

Is this referring to how we show edit count on diff on mobile?

Side note, we also have the contribute page now.https://en.m.wikipedia.beta.wmflabs.org/wiki/Special:Contributions/Jdlrobson so must be careful about adding stuff to the top of the page, since the top of the page varies by skin.

I ran with @Trizek-WMF mock and built out a possible UI we could use here:

I think this could be extended to provide other useful information (I'm not sure if there are other wishlist items for this..?) but I think an extensible solution would be great here.
@Samwilson I hope this is not stepping on your toes, and helpful.

https://patchdemo.wmflabs.org/wikis/0d42dd5cd7/wiki/Special:Contributions/Patch_Demo

Screen Shot 2022-12-12 at 2.22.53 PM.png (512×932 px, 77 KB)

Do we have any designers working during the wishathon week that we could work with to realize such a thing?

It looks great!

Can we imagine to have the number of Thanks received displayed here as well?

Do we have any designers working during the wishathon week that we could work with to realize such a thing?

Growth designer is off until next year. But @AAlhazwani-WMF is in Wishathon channel and might help?

It looks great!

Can we imagine to have the number of Thanks received displayed here as well?

I've updated the offering to introduce a hook that can be utilized in future. It seems there would be a few blockers to do that though: T325095

Adding @Pginer-WMF since the language team have been modifying the contributions page experience recently. I would be interested in his reaction to the blue box in the earlier patch demo https://patchdemo.wmflabs.org/wikis/0d42dd5cd7/wiki/Special:Contributions/Patch_Demo

The code is ready for review @Ladsgroup and @Samwilson - but please don't merge until we've got some design input! Thanks in advance!

hi @Jdlrobson and everyone! I'm wondering if we could rearrange the "Member since" as it doesn't have much connection to the total number of edits/edit count and it can be confusing to see one next to the other. could we change the "Member since" to something like "Last edit / Last edited"? also +1 on having other things displayed like Thanks received and other info :)

regarding the blue boxes (would love to hear Pau's thoughts on this too!), right now they seem to work as separate things, maybe the whole block can be blue but the white line doesn't go all the way to the ends of the block to make them look more incorporated to each other (like Growth's scorecards)?

feel free to reach out with any comments! this looks great! :)

A possible design inspiration for this would be the work done by Growth on their new impact module.

Regarding the Growth impact module, boxes all have the same width.

hi @Jdlrobson and everyone! I'm wondering if we could rearrange the "Member since" as it doesn't have much connection to the total number of edits/edit count and it can be confusing to see one next to the other.

Reading into the wish - the desire seems to be about getting a sense of a user's editing experience. Edit count is helpful but an editor who has been around for ten years also counts for something. I'm happy to descope this if we want to think about it more, but the reason I included it was it looks a bit strange with just one box! :-) but if we also want to add thanks then this doesn't seem so pressing.

could we change the "Member since" to something like "Last edit / Last edited"? also +1 on having other things displayed like Thanks received and other info :)

The last edit is already in the page - it's the first edit in the list. I think we could do this in future, but that will be a little more work. I'm not sure I'll be able to do that during the wishathon week.

I just showing the edit count okay for a first pass?

regarding the blue boxes (would love to hear Pau's thoughts on this too!), right now they seem to work as separate things, maybe the whole block can be blue but the white line doesn't go all the way to the ends of the block to make them look more incorporated to each other (like Growth's scorecards)?

Here's the latest iteration of the design:

Screen Shot 2022-12-14 at 10.52.52 AM.png (566×1 px, 197 KB)

cool! thanks for this thoughtful and clarifying explanation :) yeah I agree one box would look weird

Edit count is helpful but an editor who has been around for ten years also counts for something

this makes sense! we can keep the Member since then (or at least for now), and if extending the info that is displaying is a consensus, we can revisit this!

I just showing the edit count okay for a first pass?

sure :) thanks for letting me know about complexity

the image on the design iteration seems to be restricted :(

@JFernandez-WMF fixed mock! We can jump into a Slack this afternoon if you wanted to review it further!

This is how it looks on the Growth homepage (not shown by default yet in most wikis): https://en.wikipedia.org/w/index.php?title=Special:Homepage&source=personaltoolslink&namespace=0&new-impact=1

Might make sense to align looks (code not so much, the Growth cards are in Vue).

Test wiki created on Patch demo by Jdlrobson using patch(es) linked to this task:
https://patchdemo.wmflabs.org/wikis/8e8c1b86e9/w

It's worth noting that Special:Contributions is a place where patrollers do their work. These stats are awesome, especially as its extendable and we can add more, but I wonder if we should consider a more compact design. That little bit of scrolling is enough to slow down workflows. In my opinion users should not be distracted from the purpose of Special:Contribs – to browse contributions. If a more compact design isn't desired, maybe the stats could be collapsible with the collapsible state tied to a hidden user preference (so that it's "sticky')?

Please also don't forget to update https://www.mediawiki.org/wiki/Help:User_contributions

@JFernandez-WMF and @Jdlrobson thanks for all of your work on this.
@MusikAnimal thanks for raising the need for updated documentation + the screen real estate concerns given the core user actions on the page for patrollers.

I agree that core actions should take precedence over the real estate of the stats + requiring scrolling. I would say the ideal would be to reduce the size of the stats while still making them visually distinct at the top of the page. What other treatments were explored? I think the summary bar under the username makes sense in terms of information hierarchy on the page. Will follow up on a thread on slack!

I shy away from the idea of making things collapsable, especially when there's real estate on the page where we could add the information without adding scroll depth!

Calling people "members" of the wiki feels weird too, it's not terminology we use elsewhere for this relationship. We usually just call them Users... Who then may be members of (user) groups...

@Reedy thanks for the note on terminology consistence, let's say "User since" instead

@Reedy thanks for the note on terminology consistence, let's say "User since" instead

Done: https://gerrit.wikimedia.org/r/c/mediawiki/core/+/867281/14/languages/i18n/en.json

It's worth noting that Special:Contributions is a place where patrollers do their work. These stats are awesome, especially as its extendable and we can add more, but I wonder if we should consider a more compact design. That little bit of scrolling is enough to slow down workflows. In my opinion users should not be distracted from the purpose of Special:Contribs – to browse contributions. If a more compact design isn't desired, maybe the stats could be collapsible with the collapsible state tied to a hidden user preference (so that it's "sticky')?

Please also don't forget to update https://www.mediawiki.org/wiki/Help:User_contributions

Okay after chatting to community tech team including @MusikAnimal, we've decided to feature flag this issue since there are various things about it to work out. The newly added feature flag will allow us to try out different layouts with community members and unblocks code review for this task as the default state is "off".

https://gerrit.wikimedia.org/r/c/mediawiki/core/+/867281 is now ready for review / merging !

I wonder if it would make sense to create a new special page, Special:UserStatistics maybe, linked from the contributions page, and use the contribution statistics card system there?

Regarding the naming terminology, Special:CentralAuth uses "Registered:". e.g. https://en.wikipedia.org/wiki/Special:CentralAuth/Jimbo_Wales
(that page can actually be used to find out the edit count of an user in the current wiki, albeit it is an odd path)

In T324166#8472791, @Tgr wrote:

I wonder if it would make sense to create a new special page, Special:UserStatistics maybe, linked from the contributions page, and use the contribution statistics card system there?

I agree. Providing it under a separate Special:UserStatistics page makes more sense.

I wonder if it would make sense to create a new special page, Special:UserStatistics maybe, linked from the contributions page, and use the contribution statistics card system there?

Also agreed. I only just discovered the new Special:Contribute that @Jdlrobson built (T286466). It seems this was mostly designed for mobile, but the UI otherwise looks like a very fitting place for the new stats! I.e. what if we added a "Stats" tab here?

Persistent - Create.png (903×375 px, 48 KB)

The code as currently written is in the MediaWiki\Specials\Contribute namespace, anyway.

The wish asks for the edit count at Special:Contribs, as that's where people instinctively go when they don't where else to go to find this info. So we could still put a link there or something to make Special:Contribute easier to find.

Thoughts?

Also agreed. I only just discovered the new Special:Contribute that @Jdlrobson built (T286466). It seems this was mostly designed for mobile, but the UI otherwise looks like a very fitting place for the new stats! I.e. what if we added a "Stats" tab here?

This is definitely another approach that could be taken. I guess my question here would be does this solve the problem posed in the wishlist. Was there a specific reason they asked for this page in particular that would be invalidated by that idea (perhaps they want to avoid another click to XTools or similar)?

It sounds like this task needs more input from the community to understand the problem and designers before it's rolled out. This could be done by rolling out the feature to one project and getting a reaction or reaching out them via various village pumps.

The existing code could easily be repurposed to apply to a third Special:ContributeStatistics page if that was needed. We'd just need to shuffle the existing code around.

I'm out from next week, so community tech should feel free to take over this patch from me or build on top of it. Have a good holiday y'all!

Hi @NRodriguez please let me know how I can support you. https://gerrit.wikimedia.org/r/c/mediawiki/core/+/867281 should be ready to go but let me know if you want to take another approach here. Patch was +1ed by @Samwilson but I'm not sure what the next steps here and who this is now waiting on.

The persistent entry point to contribute (T322740) will show on desktop in the following way:

Desktop.png (900×1 px, 71 KB)

It presents two tabs, one for starting a new contribution and another for reviewing existing contributions. I think the edit count module makes sense as part of the list of existing contributions (that is, shown below "View contributions" when such option is selected). Since the counter is representing the total number of those contributions.

It presents two tabs, one for starting a new contribution and another for reviewing existing contributions. I think the edit count module makes sense as part of the list of existing contributions (that is, shown below "View contributions" when such option is selected). Since the counter is representing the total number of those contributions.

The discussion here is about whether to add total number of thanks a user received on top of Special:Contributions and my suggestion was the total number of thanks received to be on top Special:Contribute (as you mostly care about thanks you received while edit count is mostly about judging about others). We all agree edit count should be on "View contributions"

It presents two tabs, one for starting a new contribution and another for reviewing existing contributions. I think the edit count module makes sense as part of the list of existing contributions (that is, shown below "View contributions" when such option is selected). Since the counter is representing the total number of those contributions.

The discussion here is about whether to add total number of thanks a user received on top of Special:Contributions and my suggestion was the total number of thanks received to be on top Special:Contribute (as you mostly care about thanks you received while edit count is mostly about judging about others). We all agree edit count should be on "View contributions"

Thanks for the clarification, @Ladsgroup. Regarding the tanks received, that seems to me information connected to the contributions made and their impact (not related to future new contributions the user can make). So it makes sense to me to keep edit count and thanks count together and close to the list of the contributions.

Change 867281 abandoned by Jdlrobson:

[mediawiki/core@master] Add user stats box to top of Special:Contributions page

Reason:

Not thinking about this any more. Community tech team: feel free to reach out if you want to restore this work. Happy to help when we both have more bandwidth.

https://gerrit.wikimedia.org/r/867281

Change 946669 had a related patch set uploaded (by Novem Linguae; author: Novem Linguae):

[mediawiki/core@master] Add edit count to Special:Contributions page

https://gerrit.wikimedia.org/r/946669

Test wiki created on Patch demo by Jdlrobson using patch(es) linked to this task:
https://patchdemo.wmflabs.org/wikis/fdefd7a458/w

Change 946669 merged by jenkins-bot:

[mediawiki/core@master] Add edit count to Special:Contributions page

https://gerrit.wikimedia.org/r/946669

Change 950185 had a related patch set uploaded (by Novem Linguae; author: Novem Linguae):

[mediawiki/core@master] Refactor Special:Contributions

https://gerrit.wikimedia.org/r/950185

Change 950190 had a related patch set uploaded (by Novem Linguae; author: Novem Linguae):

[mediawiki/core@master] Add account creation date to Special:Contributions

https://gerrit.wikimedia.org/r/950190

Change 950190 merged by jenkins-bot:

[mediawiki/core@master] Add account creation date to Special:Contributions

https://gerrit.wikimedia.org/r/950190

I suggest this text for Tech News. Please confirm it is ok, or provide preferred replacement text. (Drafts always help!) Thanks!

Recent changes

  • All Special:Contributions pages now show the user's local edit count and the account's creation or attachment date. (1)

(I suspect there's a clearer way to phrase the last part, without the "attachment" jargon or getting lost in details/edge-cases (I resisted!), but I'm struggling to find the words...)

Consider removing "or attachment". I think that makes it a bit clearer :)

Change 950185 merged by jenkins-bot:

[mediawiki/core@master] Refactor Special:Contributions

https://gerrit.wikimedia.org/r/950185

Test wiki on Patch demo by Jdlrobson using patch(es) linked to this task was deleted:

https://patchdemo.wmflabs.org/wikis/8e8c1b86e9/w/

Test wiki on Patch demo by Jdlrobson using patch(es) linked to this task was deleted:

https://patchdemo.wmflabs.org/wikis/0d42dd5cd7/w/

Test wiki on Patch demo by Jdlrobson using patch(es) linked to this task was deleted:

https://patchdemo.wmflabs.org/wikis/fdefd7a458/w/