Page MenuHomePhabricator
Create Task
Maniphest T337809

Error deleting pages on MediaWiki.org: Cannot use object of type OOUI\FieldLayout as array
Closed, ResolvedPublicPRODUCTION ERROR
Actions

Description

Steps to replicate the issue (include links if applicable):

What happens?:

[a66b7206-cd80-4844-a696-27de2d6198de] 2023-05-31 04:07:07: Fatal exception of type "Error"

What should have happened instead?:
The deletion form shows up (I was trying to temporarily delete the page to clean up an old messy import that caused parallel histories). Seems to show up with all deletions of pages older than a certain point.

Error: Cannot use object of type OOUI\FieldLayout as array

from /srv/mediawiki/php-1.41.0-wmf.11/includes/htmlform/HTMLForm.php(409)
#0 /srv/mediawiki/php-1.41.0-wmf.11/includes/htmlform/HTMLForm.php(392): HTMLForm->addFields(array)
#1 /srv/mediawiki/php-1.41.0-wmf.11/includes/htmlform/OOUIHTMLForm.php(41): HTMLForm->__construct(array, RequestContext, string)
#2 /srv/mediawiki/php-1.41.0-wmf.11/includes/htmlform/HTMLForm.php(359): OOUIHTMLForm->__construct(array, RequestContext, string)
#3 /srv/mediawiki/php-1.41.0-wmf.11/includes/actions/DeleteAction.php(476): HTMLForm::factory(string, array, RequestContext)
#4 /srv/mediawiki/php-1.41.0-wmf.11/includes/actions/DeleteAction.php(352): DeleteAction->showForm(string)
#5 /srv/mediawiki/php-1.41.0-wmf.11/includes/actions/DeleteAction.php(146): DeleteAction->tempConfirmDelete()
#6 /srv/mediawiki/php-1.41.0-wmf.11/includes/actions/DeleteAction.php(116): DeleteAction->tempDelete()
#7 /srv/mediawiki/php-1.41.0-wmf.11/includes/MediaWiki.php(559): DeleteAction->show()
#8 /srv/mediawiki/php-1.41.0-wmf.11/includes/MediaWiki.php(334): MediaWiki->performAction(Article, MediaWiki\Title\Title)
#9 /srv/mediawiki/php-1.41.0-wmf.11/includes/MediaWiki.php(925): MediaWiki->performRequest()
#10 /srv/mediawiki/php-1.41.0-wmf.11/includes/MediaWiki.php(579): MediaWiki->main()
#11 /srv/mediawiki/php-1.41.0-wmf.11/index.php(50): MediaWiki->run()
#12 /srv/mediawiki/php-1.41.0-wmf.11/index.php(46): wfIndexMain()
#13 /srv/mediawiki/w/index.php(3): require(string)
#14 {main}

Details

Request URL
https://www.mediawiki.org/w/index.php?action=delete&title=Manual:PhpWiki_conversion
Subject Repo Branch Lines +/-
DeleteAction: Replace remaining OOUI fields mediawiki/core wmf/1.41.0-wmf.11 +7 -13
DeleteAction: Replace remaining OOUI fields mediawiki/core master +7 -13
Customize query in gerrit

Related Objects
Search...

Status Subtype Assigned Task
Resolved Release dduvall T337525 1.41.0-wmf.11 deployment blockers
Resolved PRODUCTION ERROR Func T337809 Error deleting pages on MediaWiki.org: Cannot use object of type OOUI\FieldLayout as array

Event Timeline

Pppery created this task.May 31 2023, 4:08 AM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMay 31 2023, 4:08 AM
Pppery added projects: Wikimedia-production-error, MediaWiki-Page-deletion.May 31 2023, 4:08 AM
Aklapper changed the subtype of this task from "Bug Report" to "Production Error".May 31 2023, 5:47 AM
Aklapper renamed this task from Error deleting very old pages on MediaWiki.org to Error deleting very old pages on MediaWiki.org: Cannot use object of type OOUI\FieldLayout as array.May 31 2023, 5:50 AM
Aklapper set Request URL to https://www.mediawiki.org/w/index.php?action=delete&title=Manual:PhpWiki_conversion.
Aklapper updated the task description. (Show Details)
Aklapper added a project: MediaWiki-HTMLForm.
Aklapper triaged this task as Unbreak Now! priority.May 31 2023, 5:53 AM
Aklapper added a parent task: T337525: 1.41.0-wmf.11 deployment blockers.
gerritbot added a comment.May 31 2023, 7:21 AM

Change 924140 had a related patch set uploaded (by Func; author: Func):

[mediawiki/core@master] DeleteAction: Replace remaining OOUI fields

https://gerrit.wikimedia.org/r/924140
gerritbot added a project: Patch-For-Review.May 31 2023, 7:21 AM
Func renamed this task from Error deleting very old pages on MediaWiki.org: Cannot use object of type OOUI\FieldLayout as array to Error deleting pages on MediaWiki.org: Cannot use object of type OOUI\FieldLayout as array.May 31 2023, 7:22 AM
gerritbot added a comment.May 31 2023, 11:41 AM

Change 924140 merged by jenkins-bot:

[mediawiki/core@master] DeleteAction: Replace remaining OOUI fields

https://gerrit.wikimedia.org/r/924140
gerritbot added a comment.May 31 2023, 11:42 AM

Change 924576 had a related patch set uploaded (by Daimona Eaytoy; author: Func):

[mediawiki/core@wmf/1.41.0-wmf.11] DeleteAction: Replace remaining OOUI fields

https://gerrit.wikimedia.org/r/924576
ReleaseTaggerBot added a project: MW-1.41-notes (1.41.0-wmf.12; 2023-06-06).May 31 2023, 12:00 PM
gerritbot added a comment.May 31 2023, 1:50 PM

Change 924576 merged by jenkins-bot:

[mediawiki/core@wmf/1.41.0-wmf.11] DeleteAction: Replace remaining OOUI fields

https://gerrit.wikimedia.org/r/924576
Stashbot mentioned this in T322452: Personalized praise Echo notification.May 31 2023, 1:51 PM

Mentioned in SAL (#wikimedia-operations) [2023-05-31T13:51:31Z] <urbanecm@deploy1002> Started scap: Backport for [[gerrit:924939|Personalized praise: Fix first-ever notifications (T322452)]], [[gerrit:924576|DeleteAction: Replace remaining OOUI fields (T337809)]]
Stashbot added a comment.May 31 2023, 1:53 PM

Mentioned in SAL (#wikimedia-operations) [2023-05-31T13:53:03Z] <urbanecm@deploy1002> daimona and urbanecm: Backport for [[gerrit:924939|Personalized praise: Fix first-ever notifications (T322452)]], [[gerrit:924576|DeleteAction: Replace remaining OOUI fields (T337809)]] synced to the testservers: mwdebug2002.codfw.wmnet, mwdebug2001.codfw.wmnet, mwdebug1002.eqiad.wmnet, mwdebug1001.eqiad.wmnet
ReleaseTaggerBot edited projects, added MW-1.41-notes (1.41.0-wmf.11; 2023-05-30); removed MW-1.41-notes (1.41.0-wmf.12; 2023-06-06).May 31 2023, 2:00 PM
Stashbot added a comment.May 31 2023, 2:02 PM

Mentioned in SAL (#wikimedia-operations) [2023-05-31T14:02:43Z] <urbanecm@deploy1002> Finished scap: Backport for [[gerrit:924939|Personalized praise: Fix first-ever notifications (T322452)]], [[gerrit:924576|DeleteAction: Replace remaining OOUI fields (T337809)]] (duration: 11m 11s)
Maintenance_bot removed a project: Patch-For-Review.May 31 2023, 2:10 PM
Func closed this task as Resolved.May 31 2023, 2:11 PM
Func claimed this task.
matej_suchanek added a project: User-notice.Jun 6 2023, 7:46 AM
matej_suchanek subscribed.

This change should be announced because it might have broken scripts / gadgets interacting with the reason input field (example).
Quiddity subscribed.Jun 7 2023, 5:57 PM

For Tech News, please could someone summarize what information needs to be shared? I'm not sure what exact keywords to use, nor how to describe the best way for editors to fix any problems. (The example link is great, but I'm not sure if it fixes multiple (unrelated?) things, nor if it will make intuitive sense to other technical editors).
Perhaps something like this... (please rewrite it to fix inaccuracies! Or whatever will be most clear for the editors who need to read it) :

Last week, an update to [?? the API's DeleteAction hooks ??] may have broken some gadgets or user-scripts. Those can be fixed by replacing [???] with [???] (see an example fix).
Quiddity moved this task from To Triage to Announce in next Tech/News on the User-notice board.Jun 7 2023, 5:57 PM
matej_suchanek added a comment.Jun 8 2023, 7:41 AM

More like:

Last week, an update to the delete form may have broken some gadgets or user scripts. If you need to manipulate (empty) the reason field, replace #wpReason with #wpReason > input. See an example fix.
Quiddity moved this task from Announce in next Tech/News to In current Tech/News draft on the User-notice board.Jun 8 2023, 5:07 PM
Trizek-WMF moved this task from In current Tech/News draft to Already announced/Archive on the User-notice board.Jun 15 2023, 10:22 AM
Maintenance_bot edited projects, added User-notice-archive; removed User-notice.Jun 25 2023, 10:30 AM
Krinkle added a project: Unstewarded-production-error.Feb 13 2024, 4:50 PM
Krinkle moved this task from Untriaged to May 2023 on the Wikimedia-production-error board.
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL