Background
In T358501: Review line-heights for typography changes in light of the feedback we got about Minerva for other Minerva sizes and V22 we reviewed the current line heights for Vector and Minerva. The results of the investigation will be implemented in this ticket for the vector skin.
User story
- As a reader, I want the ability to read comfortably on the desktop skin, across all typography settings
Requirements
- The Vector22 line heights should be as follows
Vector22
| Param | Small | Standard | Large |
| Font-size(px) | 14 | 16 | 20 |
| Line-height(em) | 1.57 | 1.6 | 1.5 |
BDD
Feature: Vector22 Skin Text Size and Line Height Configuration
Scenario Outline: Ensure Vector22 skin adheres to designated line heights for different text sizes
Given the Vector22 skin is active on Wikipedia
When the user selects "<Text>" text size
Then the font size should be "<Font-size>" pixels
And the line height should be "<Line-height>" ems
Examples:
| Text | Font-size | Line-height |
| Small | 14 | 1.57 |
| Standard | 16 | 1.6 |
| Large | 20 | 1.5 |
Test Steps
- Verify Line Height for Small Text Size in Vector22:
- Select the Vector22 skin on Wikipedia and adjust text size to Small.
- AC1: Confirm the font size is 14 pixels and the line height is 1.57 ems.
- Verify Line Height for Standard Text Size in Vector22:
- Adjust text size to Standard.
- AC2: Confirm the font size is 16 pixels and the line height is 1.6 ems.
- Verify Line Height for Large Text Size in Vector22:
- Adjust text size to Large.
- AC3: Confirm the font size is 20 pixels and the line height is 1.5 ems.
Design
- See above
Acceptance criteria
- No changes to the default (small) font size
- Change the standard font size line height from 1.5 to 1.6
- Change the large font size line height from 1.3 to 1.5
Communication criteria - does this need an announcement or discussion?
- TechNews
QA Results - Prod
| AC | Status | Details |
|---|---|---|
| 1 | ✅ | T359030#9667450 |
| 2 | ✅ | T359030#9667450 |
| 3 | ✅ | T359030#9667450 |
