Update functions.php #2232
Update functions.php #2232
Conversation
Hi @rufus87! 👋 Thank you for your contribution to WordPress! 💖 It looks like this is your first pull request to No one monitors this repository for new pull requests. Pull requests must be attached to a Trac ticket to be considered for inclusion in WordPress Core. To attach a pull request to a Trac ticket, please include the ticket's full URL in your pull request description. Pull requests are never merged on GitHub. The WordPress codebase continues to be managed through the SVN repository that this GitHub repository mirrors. Please feel free to open pull requests to work on any contribution you are making. More information about how GitHub pull requests can be used to contribute to WordPress can be found in this blog post. Please include automated tests. Including tests in your pull request is one way to help your patch be considered faster. To learn about WordPress' test suites, visit the Automated Testing page in the handbook. If you have not had a chance, please review the Contribute with Code page in the WordPress Core Handbook. The Developer Hub also documents the various coding standards that are followed:
Thank you, |
Use hardcoded "8" position for admin menu "Widgets" sub-menu item.
| @@ -5195,7 +5195,7 @@ function wp_widgets_add_menu() { | |||
| return; | |||
| } | |||
| $submenu['themes.php'][7] = array( __( 'Widgets' ), 'edit_theme_options', 'widgets.php' ); | |||
| $submenu['themes.php'][8] = array( __( 'Widgets' ), 'edit_theme_options', 'widgets.php' ); | |||
There was a problem hiding this comment.
Question: What will the impact be to extenders who expect the Widgets menu to be in the 7th position as it's always been? Changing this might cause another problem for others.
Committed in https://core.trac.wordpress.org/changeset/53020 |
In the last 5.9 version there is an issue related to admin panel's "Customize" sub-menu item for block based themes. The problem is that for block based themes the "Customize" sub-menu item position is 7 (for the old themes it is 6). However, "Widgets" sub-menu item is constantly registered in the exactly same 7th position and in case of block based themes, it overwrites "Customize" sub-menu item.
I've added a small tweak that will increase "Widgets" sub-menu item position by 1 ( will be 8 instead of 7 ) by checking if active theme is a block based one ( using native "wp_is_block_theme" function )
Trac ticket: https://core.trac.wordpress.org/ticket/54916
This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.