"Make text bigger" setting does not scale all UI elements
Categories
(Core :: Widget: Win32, defect)
Tracking
()
People
(Reporter: mstriemer, Assigned: emilio, NeedInfo)
References
(Blocks 1 open bug)
Details
Attachments
(2 files)
STR
- Under Settings > Ease of Access > Display set Make text bigger to 150%
- Go to about:logins or about:addons
Expected Results:
Font sizes should be 150% larger than usual
Actual Results:
Font sizes are still the same
This appears to partly stem from setting font-size: 15px on HTML documents [1] but there may be some other solution we can apply to make this work. The XUL pages tend to work since they rely on font:menu/message-box/etc
however icon only buttons do not grow since they're also defined in px units.
Our toolbars also only grow with font size, so buttons that are icon only like the close tab, new tab, back/forward all stay the same size.
Emilio suggested that perhaps we can apply a more general solution to all of these surfaces to zoom them instead
|
Assignee |
|
Updated•
2 years ago
|
|
Assignee |
|
Comment 1•
2 years ago
|
||
Much like we expose overlay scrollbars.
|
Assignee |
|
Comment 2•
2 years ago
|
||
GTK already did this, sorta, in a platform-specific way: by hacking in the
scale factor in the CSS screen code. I think this is cleaner, since we have a
centralized place to compute the full zoom in nsPresContext, and that code path
is fairly well tested.
This also would make it trivial to make this text zoom rather than full zoom in
the future, if we wanted (which is probably technically more correct, even
though less pretty less pretty).
This also allows us to remove some hacks where we were undoing the text scale
factor on Linux (since stuff like scrollbars already ignore full zoom).
Depends on D148675
|
Assignee |
|
Updated•
2 years ago
|
|
Assignee |
|
Comment 3•
2 years ago
|
||
(ni? To look into the issues Mark found in the phab revision)
|
Assignee |
|
Comment 4•
2 years ago
|
||
Oh, though I bet I know where they are.
|
Assignee |
|
Updated•
2 years ago
|
|
Assignee |
|
Updated•
2 years ago
|
Pushed by ealvarez@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/cb7c4d0b9462 Expose Windows' text scale factor to LookAndFeel. r=handyman
Pushed by ealvarez@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/6e1cbabce0af Treat text scale factor as an additional zoom factor, on both GTK and Windows. r=stransky,handyman
|
Reporter |
|
Comment 7•
2 years ago
|
||
Asa, this adds support for zooming content based on the Windows "Make text bigger" setting. This is in line with what other browser and apps appear to do in Windows.
However, previously users who wanted larger text for web content would need to change their Font settings in Preferences. These two settings will now be additive, meaning that if you've set your Windows setting to 150% and your minimum font size to 24px to match you'll now be getting much larger text. This would also happen if you've set your default zoom to 150% for example.
I'm curious if you think we should provide some messaging to users that have both of these settings on, or write a new SUMO page/update an existing page to reflect the change. The fix would be to reset your font/zoom settings to default and Firefox should now provide the expected defaults based on the Windows setting.
Looks like this is going to dupe bug 1610122.
|
|
|
Comment 9•
2 years ago
|
||
bugherder |
|
Assignee |
|
Updated•
2 years ago
|
|
|
|
Updated•
2 years ago
|
|
|
|
Updated•
2 years ago
|
|
|
|
Updated•
2 years ago
|
|
|
|
Updated•
2 years ago
|
|
|
|
Comment 11•
2 years ago
•
|
||
(In reply to Mark Striemer [:mstriemer] from comment #0)
This appears to partly stem from setting font-size: 15px on HTML documents
The preferred mechanism would be to use system fonts: the CSS font
property can be set to -moz-dialog
, -moz-list
, -moz-field
, or -moz-button
, for example. If those don't provide sufficient control, then inheritance and percentage values can provide more variation.
|
Assignee |
|
Comment 12•
2 years ago
|
||
Release Note Request (optional, but appreciated)
[Why is this notable]: Changes to how OS scale factor works. Matches other browsers and Linux behavior.
[Affects Firefox for Android]: no
[Suggested wording]: Windows' "Make text bigger" accessibility setting now affects all the UI and content pages, rather than just affecting system font sizes.
[Links (documentation, blog post, etc)]:
|
|
|
Comment 13•
2 years ago
|
||
Note added to the 103 beta release notes.
|
|
|
Comment 14•
2 years ago
|
||
I managed to reproduce this issue on Firefox 102.0(build ID: 20220623063721) on Windows 10 64-bits. Verified as fixed on Firefox 103.0b5(build ID: 20220705185846) and Nightly 104.0a1(buildID: 20220706214039) on Windows 10 64-bits.
|
|
|
Updated•
2 years ago
|
Description
•