Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modifier overrides Object parameters, not Part parameters #2657

Closed
cjbaar opened this issue Jul 19, 2019 · 5 comments
Closed

Modifier overrides Object parameters, not Part parameters #2657

cjbaar opened this issue Jul 19, 2019 · 5 comments

Comments

@cjbaar
Copy link

Version

2.0.0

Operating system type + version

OSX

3D printer brand / version + firmware version (if known)

MK3S + MMU2S

Behavior

The new version of PrusaSlicer has a lot of great improvements, but it is still missing one feature I was hoping for, which is the ability to use modifier meshes on MMU prints. Every time a modifier is created or added, it automatically gets an "Extruder" parameter added to it that cannot be removed. When trying to make MMU prints, this makes the modifier functions effectively useless, but I can't apply a modifier to a portion of the model without also changing its color (extruder).

Project File (.3MF) where problem occurs

Attaching a project file that shows 5 MMU blocks, with a cylinder modifier. The modifier overrides the color where it crosses the print.
mmu2test.3mf.gz

@bubnikv
Copy link
Collaborator

bubnikv commented Jul 22, 2019 via email

@cjbaar
Copy link
Author

Thanks @bubnikv. Appreciate you taking a look at it.

@bubnikv bubnikv changed the title [Feature Request] Remove "Extruder" option from modifier meshes for MMU Modifier overrides Object parameters, not Part parameters Sep 19, 2019
@bubnikv
Copy link
Collaborator

It is a general issue of how the modifier mesh parameters are processed. Currently the modifier meshes override object parameters, not the part parameters that they overlap with. Unfortunately the slicing back end invalidation mechanism is tightly coupled to the current parameter inheritance hierarchy, it will take quite some effort to change it.

@cjbaar
Copy link
Author

@bubnikv Understood. Thanks for your time in looking into it. I think this would definitely be useful for MMU prints.

@bubnikv
Copy link
Collaborator

It is a general issue of how the modifier mesh parameters are processed. Currently the modifier meshes override object parameters, not the part parameters that they overlap with. Unfortunately the slicing back end invalidation mechanism is tightly coupled to the current parameter inheritance hierarchy, it will take quite some effort to change it.

It took me couple of sweaty weeks actually, the refactoring has been done also to support the new MM painting feature.

In PrusaSlicer 2.4.0-alpha1 the modifier volumes are applied strictly in the order they are presented at the side panel, one modifier may override the other and a "default" extruder means "don't change, use the parent's".

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants