fix some msvc compile error under Chinese Windows system. #5583
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
ShenRen commented
Dec 25, 2020
ShenRen commented
I don't like the idea of changing the used characters just to make a compiler happy. Can't you force the source encoding to UTF-8? Newer MSVC compilers allow that, don't they? |
You don't need to change it like this. Just add some code to CMakeLists to start utf8 mode of MSVC |
I will try this, hahah. |
@ShenRen Change your system locale to English(United States)
|
bubnikv added a commit that referenced this pull request
Feb 10, 2021
Hopefully a fix of fix some msvc compile error under Chinese Windows system. #5583 Hopefully it will not break any localization.
Hopefully fixed with 32b8a59 |
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.