Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account
Jump to bottom

Error compiling on Linux #5752

Merged
merged 1 commit into from Feb 10, 2021
Merged

Error compiling on Linux #5752

merged 1 commit into from Feb 10, 2021

Conversation

sebastianha
Copy link
Contributor

Version

2.3.0 (fcabe8a)

Operating system type + version

openSUSE-Leap-15.2

Behavior

When compiling with "-DSLIC3R_WX_STABLE=1" I get the following error:

PrusaSlicer_latest/src/slic3r/GUI/UnsavedChangesDialog.cpp:201:47: error: operands to ?: have different types ‘wxString’ and ‘std::__cxx11::string {aka std::__cxx11::basic_string<char>}’
         m_old_color_bmp = get_bitmap(m_toggle ? m_old_color : grey);
                                      ~~~~~~~~~^~~~~~~~~~~~~~~~~~~~
PrusaSlicer_latest/src/slic3r/GUI/UnsavedChangesDialog.cpp:203:47: error: operands to ?: have different types ‘wxString’ and ‘std::__cxx11::string {aka std::__cxx11::basic_string<char>}’
         m_new_color_bmp = get_bitmap(m_toggle ? m_new_color : grey);
                                      ~~~~~~~~~^~~~~~~~~~~~~~~~~~~~

This PR solves this for me, it would be nice if you could take a look.

@bubnikv bubnikv merged commit f050bf7 into prusa3d:master Feb 10, 2021
@bubnikv
Copy link
Collaborator

Thanks. I suppose it is a compilation issue on wxWidgets 3.0, right?

@sebastianha
Copy link
Contributor Author

Thanks. I suppose it is a compilation issue on wxWidgets 3.0, right?

I think so. Current master (f050bf7) compiles without issues for me, thank you very much!

@pmjdebruijn pmjdebruijn mentioned this pull request Feb 12, 2021
Merged
lukasmatena pushed a commit that referenced this pull request Feb 14, 2021
@pmjdebruijn @lukasmatena
UnsavedChangesDialog: fix wxString casts
b75830d 
similar instance: 08388d3

related to: #5752
@bubnikv bubnikv mentioned this pull request Aug 6, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@sebastianha @bubnikv