Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account
Jump to bottom

--scale-to-fit not accepting any input as valid #5772

Closed
mattswest opened this issue Jan 14, 2021 · 2 comments
Closed

--scale-to-fit not accepting any input as valid #5772

mattswest opened this issue Jan 14, 2021 · 2 comments

Comments

@mattswest
Copy link

Version

Version of PrusaSlicer used goes here

Use About->About PrusaSlicer for release versions

For -dev versions, use git describe --tag or get the hash value for the version you downloaded or git rev-parse HEAD

Operating system type + version

What OS are you using, and state any version #s
In case of 3D rendering issues, please attach the content of menu Help -> System Info dialog

3D printer brand / version + firmware version (if known)

What 3D printer brand / version are you printing on, is it a stock model or did you modify the printer, what firmware is running on your printer, version of the firmware #s

Behavior

  • Describe the problem
  • Steps needed to reproduce the problem
    • If this is a command-line slicing issue, include the options used
  • Expected Results
  • Actual Results
    • Screenshots from PrusaSlicer preview are preferred

Is this a new feature request?

Project File (.3MF) where problem occurs

Upload a PrusaSlicer Project File (.3MF) (Plater -> Export plate as 3MF for Slic3r PE 1.41.2 and older, File -> Save / Save Project for PrusaSlicer, Slic3r PE 1.42.0-alpha and newer)
Images (PNG, GIF, JPEG), PDFs or text files could be drag & dropped to the issue directly, while all other files need to be zipped first (.zip, .gz)

image
bubnikv added a commit that referenced this issue Jan 14, 2021
@bubnikv
Fix of --scale-to-fit not accepting any input as valid (#5772)
4887761 
Fixed parsing of Point3, fortunately Point3 was used at just a single
command line parameter, thus this was not a big deal.
@bubnikv
Copy link
Collaborator

This is a regression likely since PrusaSlicer 2.0.0 when porting the command line interface from Perl to C++.

I have fixed half of the problem for now with 4887761
Fix of --scale-to-fit not accepting any input as valid (#5772)
Fixed parsing of Point3, fortunately Point3 was used at just a single
command line parameter, thus this was not a big deal.

Still the method
void ModelObject::scale_to_fit(const Vec3d &size)
is empty since PrusaSlicer 2.0.0 and it needs to be filled in.

lukasmatena added a commit that referenced this issue Aug 4, 2021
@lukasmatena
CLI: Ensure that objects are on bed by default, new CLI config option:
bc81c22 
'dont-ensure-on-bed' (which allows to override). This was the original
behaviour in Slic3r and Sli3rPE, probably broken long ago when CLI
was ported from  Perl.
Also, --scale-to-fit should now work again (#5772)
@lukasmatena
Copy link
Collaborator

lukasmatena commented Aug 4, 2021 •
edited

This issue should be fixed on master by bc81c22 (with a follow-up e76b54b). It turns out that not only the --scale-to-fit did not work, but the command line interface did not make sure that the objects are on bed and allowed them to sink when transformed. This was probably broken long ago during the Perl to C++ transition.

I reinstated the old behaviour (ensure objects are on bed) and added an extra bool option --ensure-on-bed (which is on by default) so it is configurable. We have just allowed sinking objects in the GUI version, so it makes sense to have it available through the CLI as well. Please, report any problems.

Closing.

@bubnikv bubnikv mentioned this issue Aug 6, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@bubnikv @mattswest @lukasmatena