Postprocessing moved to temp dir #6000
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
This just broke all my post processing - any chance to make this optional? |
@foreachthing replied in you in ticket. No worries in worst case it'll be reverted. You can revert it locally for the meantime |
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
*Why this change in needed?
I upload my gcode files onto network storage over 2.4GHz wifi and it takes noticeable time.
It becomes worse if also use post-processing scripts, since it is now implemented in way that post-processing happens after gcode file was move to its final path.
*What is the change?
I moved post-processing step to happen before gcode files move from temp dir to final. Temp directory is usually a fast SSD so it eliminates the problem