Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Korean localization addition update #6314

Merged
merged 3 commits into from Jul 8, 2021
Merged

Korean localization addition update #6314

merged 3 commits into from Jul 8, 2021

Conversation

ulsanether
Copy link
Contributor

Korean localization addition update

@bubnikv bubnikv merged commit d243282 into prusa3d:master Jul 8, 2021
@bubnikv
Copy link
Collaborator

Thank you for your contribution.

@bubnikv
Copy link
Collaborator

Dear @ulsanether

why did you provide two dictionaries, PrusaSlicer_ko.po and PrusaSlicer_ko_KR.po? The two dictionaries differ in a handful of keys. Why?

How do your dictionaries differ from the dictionaries in ko/PrusaSlicer_ko_KR.po?
I may be ignorant to the localization issue, but it seems we distribute three Korean dictionaries now, while a single dictionary would do. The dictionary ko/PrusaSlicer_ko_KR.po is yours with a single commit in addition
9a4863a

Could we merge all three dictionaries into a single one?

@ulsanether
Copy link
Contributor Author

Dear @ulsanether

why did you provide two dictionaries, PrusaSlicer_ko.po and PrusaSlicer_ko_KR.po? The two dictionaries differ in a handful of keys. Why?

How do your dictionaries differ from the dictionaries in ko/PrusaSlicer_ko_KR.po? I may be ignorant to the localization issue, but it seems we distribute three Korean dictionaries now, while a single dictionary would do. The dictionary ko/PrusaSlicer_ko_KR.po is yours with a single commit in addition 9a4863a

Could we merge all three dictionaries into a single one?

This work was done as part of my hobbies. I've let go of this translation now, and I don't have time.
You only need to write one of the two files. There is little difference. If I have time, I will work again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants