Fix for to clipper::union without enough offset #6451
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
It check that all polygons are all thicker than scaled_epsilon
The issue is caused by slice simplification. |
Fixed by refactoring the slicing algorithm vs. xy offset compensation order. |
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
with prusaslicer 2.3.1:
If I try to slice this object with a modifier:
clipper_error_test.zip
then some extremely tiny holes are created and ruin the print
I've created this pullrequest to repair this error
It allow clipper::union to not add extremely small holes if called with safety_offset
It check that all polygons are all thicker than scaled_epsilon
It may be a bit costly.. i don't know by how much vs the union. It may use more int and less double with some careful refactoring...