Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account
Jump to bottom

[css-scroll-snap] Make it more obvious that scroll-padding/scroll-margin have effects outside snap containers #3721

Closed
fantasai opened this issue Mar 11, 2019 · 4 comments
Closed

[css-scroll-snap] Make it more obvious that scroll-padding/scroll-margin have effects outside snap containers #3721

fantasai opened this issue Mar 11, 2019 · 4 comments
Labels
Closed Accepted as Editorial Commenter Satisfied Commenter has indicated satisfaction with the resolution / edits. css-scroll-snap-1 Current Work

Comments

@fantasai
Copy link
Collaborator

This seems to be a common slip-up, which isn't surprising, since the spec was originally written to only apply to snap containers.
@fantasai fantasai added the css-scroll-snap-1 Current Work label Mar 11, 2019
@jonjohnjohnson
Copy link

#2428

fantasai added a commit that referenced this issue Mar 11, 2019
@fantasai
[css-scroll-snap-1] Emphasize that scroll-padding and scroll-margin a…
fb52823 
…pply even when snapping is off. #3721
@fantasai
Copy link
Collaborator Author

Agenda+ to request republication.

@jonjohnjohnson
Copy link

@fantasai if you think the changes and upcoming discussion in this issue warrant closing #2428, please do so. I'll be glad it's at least covered here, even if slightly discouraged that something I thoughtfully filed flew under the radar.

@css-meeting-bot
Copy link
Member

The CSS Working Group just discussed Scroll Snap republication, and agreed to the following:

  • RESOLVED: Publish updated CR for Scroll Snap
The full IRC log of that discussion <dael> Topic: Scroll Snap republication
<dael> github: https://github.com//issues/3721#issuecomment-471783264
<dael> fantasai: Made some spec clarification to make implications easier to notice. Clearly editorial, asking for repub
<dael> astearns: What about the issue from jonjonjohnson?
<dael> fantasai: That's filed against CSSOM View spec. If that needs clarification I didn't fix anything in there. I just fixed scrollsnap
<dael> fantasai: Updated CR
<dael> astearns: There is a change list and DoC?
<dael> fantasai: There was only one comment which was mine. DoC seemed excessive
<fantasai> https://drafts.csswg.org/css-scroll-snap-1/#changes
<dael> astearns: SHould have a changes list so when we repub people know it's one thing
<dael> fantasai: Here it is ^
<dael> astearns: Just editorial or any test changes?
<florian> I have reviewed the change and support it.
<dael> fantasai: No normative implications. Emphasizing points on stuff we agreed
<dael> astearns: Comments on updating?
<dael> astearns: I see florian supports
<dael> astearns: Objection to Publish updated CR for Scroll Snap?
<dael> RESOLVED: Publish updated CR for Scroll Snap

@jonjohnjohnson jonjohnjohnson mentioned this issue Mar 13, 2019
Open
@fantasai fantasai added the Commenter Satisfied Commenter has indicated satisfaction with the resolution / edits. label Nov 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Closed Accepted as Editorial Commenter Satisfied Commenter has indicated satisfaction with the resolution / edits. css-scroll-snap-1 Current Work
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@jonjohnjohnson @fantasai @css-meeting-bot and others