BREAKING CHANGE: cleanup lottie component and remove default styles #992
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
matinzd force-pushed the fix/container_props branch from d6626c1 to 7f9766a Compare
matinzd changed the title
matinzd changed the title
matinzd force-pushed the fix/container_props branch from f4754b7 to fc4d7a5 Compare
matinzd changed the title
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Rationale
There are a lot of styles being applied behind the scenes resulting in unexpected behaviors.
Solution
Remove the outer layer and pass everything directly to native lottie view
What is changed?
LottieViewWhat actions need to be taken moving forward?
You need to handle everything related to aspect ratio and sizing yourself. The reason for removing all these default values is to avoid confusion when using the library as well as to prevent unexpected behaviors.
Fixes