Closed Bug 1683116 Opened 3 years ago Closed 3 years ago

Flicker and artifacts over entire window on https://www.vsynctester.com/ caused by remote canvas with WebRender

Categories

(Core :: Graphics: Canvas2D, defect)

Product:
Core
Component:
Graphics: Canvas2D
Type:
defect

Tracking

()

Status:
RESOLVED FIXED
Milestone:
86 Branch
Tracking Flags:
Tracking Status
relnote-firefox --- 84+
firefox84 + fixed
firefox85 --- fixed
firefox86 --- fixed

People

(Reporter: jrmuizel, Assigned: bobowen)

Details

Attachments

(1 file)

Bug 1683116: Disable remote canvas 2D for Release and late Beta. r=jrmuizel!
48 bytes, text/x-phabricator-request
RyanVM
: approval-mozilla-beta+
RyanVM
: approval-mozilla-release+
Details | Review

I just noticed this yesterday but regression windowed it to remote canvas being turned on. Flipping the pref confirmed it.

Remote canvas is shipping now for the first time in 84 so this is somewhat worrying.

Severity: -- → S2

I see this on a Intel HD Graphics 530 but don't on a GTX 1080

Summary: Flicker and artifacts over entire window on https://www.vsynctester.com/ caused by remote canvas → Flicker and artifacts over entire window on https://www.vsynctester.com/ caused by remote canvas with WebRender
Assignee: nobody → bobowencode
Status: NEW → ASSIGNED

[Tracking Requested - why for this release]: there are concerns that this and particularly bug 1683120, might cause significant performance issues for people without webrender or advanced layers on Fx84

tracking-firefox84: --- → ? 
Pushed by bobowencode@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/b78c92616ff7
Disable remote canvas 2D for Release and late Beta. r=jrmuizel

https://hg.mozilla.org/mozilla-central/rev/b78c92616ff7

Status: ASSIGNED → RESOLVED
Closed: 3 years ago
status-firefox86: affected → fixed
Resolution: --- → FIXED
Target Milestone: --- → 86 Branch

Comment on attachment 9193774 [details]
Bug 1683116: Disable remote canvas 2D for Release and late Beta. r=jrmuizel!

Beta/Release Uplift Approval Request

  • User impact if declined: Performance issue for users without webrender or advanced layers.
  • Is this code covered by automated tests?: Yes
  • Has the fix been verified in Nightly?: No
  • Needs manual test from QE?: No
  • If yes, steps to reproduce:
  • List of other uplifts needed: None
  • Risk to taking this patch: Low
  • Why is the change risky/not risky? (and alternatives if risky): Just a config change back to previous setting.
  • String changes made/needed: None
Attachment #9193774 - Flags: approval-mozilla-release?
Attachment #9193774 - Flags: approval-mozilla-beta?

Comment on attachment 9193774 [details]
Bug 1683116: Disable remote canvas 2D for Release and late Beta. r=jrmuizel!

Approved for 85.0b4.

Attachment #9193774 - Flags: approval-mozilla-beta? → approval-mozilla-beta+

Comment on attachment 9193774 [details]
Bug 1683116: Disable remote canvas 2D for Release and late Beta. r=jrmuizel!

Approved for 84.0.1.

Attachment #9193774 - Flags: approval-mozilla-release? → approval-mozilla-release+

Added to the Firefox 84.0.1 relnotes:

Fixed slower than expected performance and flickering on Canvas elements for some Windows users

relnote-firefox: --- → 84+
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: