Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account
Jump to bottom

Investigation requested for beforeprint/afterprint #5096

Open
annevk opened this issue Nov 18, 2019 · 3 comments
Open

Investigation requested for beforeprint/afterprint #5096

annevk opened this issue Nov 18, 2019 · 3 comments
Labels
clarification Standard could be clearer good first issue Ideal for someone new to a WHATWG standard or software project needs tests Moving the issue forward requires someone to write tests

Comments

@annevk
Copy link
Member

If you have A nests B nests C nests D and the user decides to print B (not sure any user agent provides UI for that, but let's assume there is), the specification suggests events in B and C, not D. Is that really what we want?

Also, if you have A nests B1 and B2, what's the order of the events? Does it matter if either B1 or B2 is cross-site? (Is it quicker than postMessage()?)

Marking this as a good first issue as the first step needed here is writing tests for these scenarios, which is relatively straightforward, albeit a bit tedious perhaps. If there are any questions around getting started with tests, do let me know.
@annevk annevk added clarification Standard could be clearer good first issue Ideal for someone new to a WHATWG standard or software project needs tests Moving the issue forward requires someone to write tests labels Nov 18, 2019
This was referenced Nov 22, 2019
Merged
Closed
@domenic domenic mentioned this issue Jan 27, 2021
Merged
@Subhamvk

This comment was marked as off-topic.

Sign in to view
@domenic
Copy link
Member

domenic commented May 2, 2022 •
edited

Chromium apparently dispatches recursively on all descendants, but bails out for OOPIFs. Ick.

It also appears beforeprint might be synchronous.

@tawandamoyo
Copy link
Contributor

Hi @annevk ,

I'd like to work on this. If you can please provide some pointers and how to get started with tests? Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
clarification Standard could be clearer good first issue Ideal for someone new to a WHATWG standard or software project needs tests Moving the issue forward requires someone to write tests
Milestone
No milestone
Development

No branches or pull requests
5 participants
@domenic @annevk @tawandamoyo @Subhamvk and others