Bob Clary [:bc] (inactive) Reporter
	Description • 9 years ago

chown has potentially different syntax depending on the version of android. The usage messages for older versions is Usage: chown <USER>[.GROUP] <FILE1> [FILE2] ... while newer versions say Usage: chown <USER>[:GROUP] <FILE1> [FILE2] ...

It does appear that some versions of chown supports the -R recurse flag while others do not. It would be good to implement this as a command in adb.py so that we can hide these implementation differences. Detection in the ADBDevice constructor in a similar fashion to that used for ls might be appropriate.

	Edwin Takahashi (:egao | infrequent contributor) Assignee
	Comment 1 • 6 years ago

Try run for builds on all platforms:

https://treeherder.mozilla.org/#/jobs?repo=try&revision=796327815cb6dc8a46606a1a594de612449dc646

	Edwin Takahashi (:egao | infrequent contributor) Assignee
	Comment 2 • 6 years ago

Try run with tests that invoke mozdevice:

https://treeherder.mozilla.org/#/jobs?repo=try&revision=a68d0f78db8f62e03b36af64303a7fae6474ae5c

	Edwin Takahashi (:egao | infrequent contributor) Assignee
	Comment 3 • 6 years ago

- added method for ADBDevice class called chown()
- when initializing ADBDevice class, check if recursive flag is supported
- added handling for recursive and non-recursive flags
- added handling for situation where recursive is desired but -R flag is not supported
- added unit tests to exercise each code path, checking if expected values are being returned

	Edwin Takahashi (:egao | infrequent contributor) Assignee
	Comment 4 • 6 years ago

Additional try run for records:
https://treeherder.mozilla.org/#/jobs?repo=try&revision=a00336b210cd866d0aa00d8d134c34ed263ad973

	Pulsebot
	Comment 5 • 6 years ago

Pushed by gmierz2@outlook.com:
https://hg.mozilla.org/integration/autoland/rev/53dfca556ff1
Add chown method to adb.py, refactor chmod r=bc

	Andrei Ciure[:aciure]
	Comment 6 • 6 years ago
bugherder

https://hg.mozilla.org/mozilla-central/rev/53dfca556ff1