New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: [#21777] Prevent focusing of FireFox address bar #22215
Merged
jorgefilipecosta merged 1 commit into WordPress:master from kirilzh:fix/firefox-keyboard-shortcut-button
May 8, 2020
Merged
fix: [#21777] Prevent focusing of FireFox address bar #22215
jorgefilipecosta merged 1 commit into WordPress:master from kirilzh:fix/firefox-keyboard-shortcut-button
May 8, 2020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
kirilzh force-pushed the fix/firefox-keyboard-shortcut-button branch from
May 8, 2020 10:24
33e8d18
to 7de6bac
Compare
kirilzh force-pushed the fix/firefox-keyboard-shortcut-button branch from
May 8, 2020 10:35
7de6bac
to aa4a28e
Compare
kirilzh changed the title
WIP: fix: [#21777] Prevent focusing of FireFox address bar
fix: [#21777] Prevent focusing of FireFox address bar
May 8, 2020
kirilzh requested review from ajitbohra, jorgefilipecosta and Soean as code owners
May 8, 2020 10:53
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixes the problem in my tests 👍
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Description
Fixes #21777.
Using 'META + K' to add a link to the button block triggers FireFox's focus on address bar.
How has this been tested?
The problem is resolved by preventing the default behavior of that keyboard shortcut.
Types of changes
Bug fix (non-breaking change which fixes an issue).
Checklist: