Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: [#21777] Prevent focusing of FireFox address bar #22215

Conversation

kirilzh
Copy link
Contributor

@kirilzh kirilzh commented May 8, 2020

Description

Fixes #21777.
Using 'META + K' to add a link to the button block triggers FireFox's focus on address bar.

How has this been tested?

The problem is resolved by preventing the default behavior of that keyboard shortcut.

Types of changes

Bug fix (non-breaking change which fixes an issue).

Checklist:

  • My code follows the WordPress code style.

@kirilzh kirilzh requested a review from talldan May 8, 2020 10:08
@kirilzh kirilzh force-pushed the fix/firefox-keyboard-shortcut-button branch from 33e8d18 to 7de6bac Compare May 8, 2020 10:24
@kirilzh kirilzh force-pushed the fix/firefox-keyboard-shortcut-button branch from 7de6bac to aa4a28e Compare May 8, 2020 10:35
@kirilzh kirilzh changed the title WIP: fix: [#21777] Prevent focusing of FireFox address bar fix: [#21777] Prevent focusing of FireFox address bar May 8, 2020
@kirilzh kirilzh marked this pull request as ready for review May 8, 2020 10:53
Copy link
Member

@jorgefilipecosta jorgefilipecosta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixes the problem in my tests 👍

@jorgefilipecosta jorgefilipecosta merged commit d2988b1 into WordPress:master May 8, 2020
@github-actions github-actions bot added this to the Gutenberg 8.1 milestone May 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cmd + K to add link to a Button block focuses the browser address bar in Firefox
2 participants