Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account
Jump to bottom

Interface: Add missing param docs for singleEnableItems() and multipleEnableItems() #22964

Merged
merged 1 commit into from Jun 6, 2020
Merged

Interface: Add missing param docs for singleEnableItems() and multipleEnableItems() #22964

merged 1 commit into from Jun 6, 2020

Conversation

ocean90
Copy link
Member

Description

See #22907.

Fixes the following JSDoc warnings:

packages/interface/src/store/reducer.js
  11:1  warning  Missing JSDoc @param "action.type" declaration      jsdoc/require-param
  11:1  warning  Missing JSDoc @param "action.itemType" declaration  jsdoc/require-param
  11:1  warning  Missing JSDoc @param "action.scope" declaration     jsdoc/require-param
  11:1  warning  Missing JSDoc @param "action.item" declaration      jsdoc/require-param
  15:0  warning  Missing @param "action.type"                        jsdoc/check-param-names
  15:0  warning  Missing @param "action.itemType"                    jsdoc/check-param-names
  15:0  warning  Missing @param "action.scope"                       jsdoc/check-param-names
  15:0  warning  Missing @param "action.item"                        jsdoc/check-param-names
  36:1  warning  Missing JSDoc @param "action.type" declaration      jsdoc/require-param
  36:1  warning  Missing JSDoc @param "action.itemType" declaration  jsdoc/require-param
  36:1  warning  Missing JSDoc @param "action.scope" declaration     jsdoc/require-param
  36:1  warning  Missing JSDoc @param "action.item" declaration      jsdoc/require-param
  36:1  warning  Missing JSDoc @param "action.isEnable" declaration  jsdoc/require-param
  40:0  warning  Missing @param "action.type"                        jsdoc/check-param-names
  40:0  warning  Missing @param "action.itemType"                    jsdoc/check-param-names
  40:0  warning  Missing @param "action.scope"                       jsdoc/check-param-names
  40:0  warning  Missing @param "action.item"                        jsdoc/check-param-names
  40:0  warning  Missing @param "action.isEnable"                    jsdoc/check-param-names

How has this been tested?

npm run lint-js packages/interface/src

Types of changes

Bug fix

@ocean90 ocean90 added [Type] Bug An existing feature does not function as intended [Package] Interface /packages/interface labels Jun 6, 2020
@github-actions
Copy link

Size Change: 0 B

Total Size: 1.12 MB

ℹ️ View Unchanged
Filename Size Change
build/a11y/index.js 1.14 kB 0 B
build/annotations/index.js 3.62 kB 0 B
build/api-fetch/index.js 3.4 kB 0 B
build/autop/index.js 2.83 kB 0 B
build/blob/index.js 620 B 0 B
build/block-directory/index.js 6.75 kB 0 B
build/block-directory/style-rtl.css 892 B 0 B
build/block-directory/style.css 892 B 0 B
build/block-editor/index.js 106 kB 0 B
build/block-editor/style-rtl.css 11.4 kB 0 B
build/block-editor/style.css 11.4 kB 0 B
build/block-library/editor-rtl.css 7.87 kB 0 B
build/block-library/editor.css 7.87 kB 0 B
build/block-library/index.js 127 kB 0 B
build/block-library/style-rtl.css 7.72 kB 0 B
build/block-library/style.css 7.72 kB 0 B
build/block-library/theme-rtl.css 684 B 0 B
build/block-library/theme.css 686 B 0 B
build/block-serialization-default-parser/index.js 1.88 kB 0 B
build/block-serialization-spec-parser/index.js 3.1 kB 0 B
build/blocks/index.js 48.1 kB 0 B
build/components/index.js 193 kB 0 B
build/components/style-rtl.css 19.5 kB 0 B
build/components/style.css 19.5 kB 0 B
build/compose/index.js 9.31 kB 0 B
build/core-data/index.js 11.4 kB 0 B
build/data-controls/index.js 1.29 kB 0 B
build/data/index.js 8.45 kB 0 B
build/date/index.js 5.47 kB 0 B
build/deprecated/index.js 771 B 0 B
build/dom-ready/index.js 568 B 0 B
build/dom/index.js 3.17 kB 0 B
build/edit-navigation/index.js 8.25 kB 0 B
build/edit-navigation/style-rtl.css 918 B 0 B
build/edit-navigation/style.css 919 B 0 B
build/edit-post/index.js 303 kB 0 B
build/edit-post/style-rtl.css 5.43 kB 0 B
build/edit-post/style.css 5.43 kB 0 B
build/edit-site/index.js 15.5 kB 0 B
build/edit-site/style-rtl.css 2.96 kB 0 B
build/edit-site/style.css 2.96 kB 0 B
build/edit-widgets/index.js 9.33 kB 0 B
build/edit-widgets/style-rtl.css 2.4 kB 0 B
build/edit-widgets/style.css 2.4 kB 0 B
build/editor/editor-styles-rtl.css 425 B 0 B
build/editor/editor-styles.css 428 B 0 B
build/editor/index.js 44.7 kB 0 B
build/editor/style-rtl.css 4.26 kB 0 B
build/editor/style.css 4.27 kB 0 B
build/element/index.js 4.64 kB 0 B
build/escape-html/index.js 733 B 0 B
build/format-library/index.js 7.72 kB 0 B
build/format-library/style-rtl.css 502 B 0 B
build/format-library/style.css 502 B 0 B
build/hooks/index.js 2.13 kB 0 B
build/html-entities/index.js 621 B 0 B
build/i18n/index.js 3.56 kB 0 B
build/is-shallow-equal/index.js 711 B 0 B
build/keyboard-shortcuts/index.js 2.52 kB 0 B
build/keycodes/index.js 1.94 kB 0 B
build/list-reusable-blocks/index.js 3.12 kB 0 B
build/list-reusable-blocks/style-rtl.css 226 B 0 B
build/list-reusable-blocks/style.css 226 B 0 B
build/media-utils/index.js 5.3 kB 0 B
build/notices/index.js 1.79 kB 0 B
build/nux/index.js 3.41 kB 0 B
build/nux/style-rtl.css 616 B 0 B
build/nux/style.css 613 B 0 B
build/plugins/index.js 2.56 kB 0 B
build/primitives/index.js 1.5 kB 0 B
build/priority-queue/index.js 789 B 0 B
build/redux-routine/index.js 2.85 kB 0 B
build/rich-text/index.js 14.8 kB 0 B
build/server-side-render/index.js 2.68 kB 0 B
build/shortcode/index.js 1.7 kB 0 B
build/token-list/index.js 1.28 kB 0 B
build/url/index.js 4.06 kB 0 B
build/viewport/index.js 1.85 kB 0 B
build/warning/index.js 1.14 kB 0 B
build/wordcount/index.js 1.17 kB 0 B

compressed-size-action

gziolo
gziolo approved these changes Jun 6, 2020
View reviewed changes
Copy link
Member

@gziolo gziolo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅

@ocean90 ocean90 merged commit ed80299 into master Jun 6, 2020
@ocean90 ocean90 deleted the fix/interface-store-reduce-missing-params branch June 6, 2020 11:45
@github-actions github-actions bot added this to the Gutenberg 8.3 milestone Jun 6, 2020
@ocean90 ocean90 mentioned this pull request Jun 6, 2020
Closed
40 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gziolo gziolo gziolo approved these changes

Assignees
No one assigned
Labels
[Package] Interface /packages/interface [Type] Bug An existing feature does not function as intended
Projects
None yet
Milestone
Gutenberg 8.3
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@ocean90 @gziolo