New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Post content: show placeholder if trying to render itself #24010
Merged
noahtallen merged 7 commits into master from update/entity-editor-behavior-for-post-content-and-query-loop
Aug 31, 2020
Merged
Post content: show placeholder if trying to render itself #24010
noahtallen merged 7 commits into master from update/entity-editor-behavior-for-post-content-and-query-loop
Aug 31, 2020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Addison-Stavlo changed the title
WIP - placeholders and bypass queryloop errors
WIP - Post content and query loop entity editor behavior goo.
Jul 16, 2020
Size Change: +630 B (0%) Total Size: 1.17 MB
ℹ️ View Unchanged
|
noahtallen force-pushed the update/entity-editor-behavior-for-post-content-and-query-loop branch from
July 20, 2020 21:11
59a692a
to bea53c7
Compare
note that I'd love to get designs for these, but I feel like we can merge this "rough" one and it will be an improvement until we do have placeholder designs |
noahtallen force-pushed the update/entity-editor-behavior-for-post-content-and-query-loop branch from
July 22, 2020 21:08
46b0f8e
to 101f7b3
Compare
noahtallen changed the title
WIP - Post content and query loop entity editor behavior goo.
Do not render post content block if context matches current post
Jul 22, 2020
noahtallen added [Feature] Full Site Editing [Type] Bug
An existing feature does not function as intended
[Type] Enhancement
A suggestion for improvement.
labels
Jul 22, 2020
noahtallen force-pushed the update/entity-editor-behavior-for-post-content-and-query-loop branch from
August 27, 2020 00:40
53f05a4
to 12ebeb9
Compare
cc @youknowriad this could use a review! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's do it!
noahtallen changed the title
Do not render post content block if context matches current post
Post content: show placeholder if trying to render itself
Aug 31, 2020
noahtallen deleted the update/entity-editor-behavior-for-post-content-and-query-loop branch
August 31, 2020 17:58
4 tasks
This was referenced
Mar 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Type] Bug
An existing feature does not function as intended
[Type] Enhancement
A suggestion for improvement.
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Fixes #22080, fixes #23762 (by stopping those crashes from occurring when a post content block exists.)
Related to #24006.
Description
Although it will show all posts retrieved from the entity records as there is no query to control or limit them. 🤔
How has this been tested?
locally in edit site, edit post (while editing posts and templates)
Screenshots
For the Singular template, instead of looking totally broken we get:
(note that the post content placeholder has since been updated to look like this:)
And for the Index template the broken query loop block:
Shows posts:
Types of changes
Bug fix, enhancement
Checklist: