Navigation: Fix creating Navigation from pages or menu with HTML in title #24673
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
…itle Pages and menu items in WordPress allow HTML in the title. We should therefore not escape the menu item title when creating a Navigation block from top-level pages or an existing menu. Additionally, the menu items REST API endpoint was setting title.raw to the menu item CPT's post_title and title.rendered to the referenced post's post_title. Both title.raw and title.rendered should be set to the menu item's title, which is properly set by wp_setup_nav_menu_item(). The only difference is that title.rendered should be passed through the_title, which escapes & characters, and nav_menu_item_title, which provides plugins a chance to customise menu item titles before display. This matches what Walker_Nav_Menu does.
noisysocks added [Type] Bug noisysocks requested review from ajitbohra, Soean, spacedmonkey, talldan and TimothyBJacobs as code owners
Size Change: +5.87 kB (0%) Total Size: 1.17 MB
ℹ️ View Unchanged
|
This looks right to me @noisysocks, can we get a phpunit test covering this? |
Done! |
Huh. The test fails in GitHub Actions but succeeds locally. I'll investigate tomorrow. |
Turns out the regular tests were passing but the multisite tests were failing. This is because administrators in a multisite do not have |
Co-authored-by: Timothy Jacobs <timothy@ironbounddesigns.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Fixes #23919.
Pages and menu items in WordPress allow HTML in the title. We should therefore not escape the menu item title when creating a Navigation block from top-level pages or an existing menu.
Additionally, the menu items REST API endpoint was setting
title.rawto the menu item CPT'spost_title($menu_item->post_title) andtitle.renderedto the referenced object'spost_title(get_post( $menu_item->object_id )->post_title)). Bothtitle.rawandtitle.renderedshould be set to the menu item'stitle($menu_item->title), which is properly set bywp_setup_nav_menu_item().The only difference is that
title.renderedshould be passed throughthe_title, which escapes&characters, andnav_menu_item_title, which provides plugins a chance to customise menu item titles before display. This matches whatWalker_Nav_Menudoes.How to test
<strong>Menu item</strong> & foo<strong>Page</strong> & foo.Both blocks should have bold text and a
&in one of the links.