Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Post Comment block #24781

Merged
merged 21 commits into from Aug 26, 2020

Conversation

david-szabo97
Copy link
Member

@david-szabo97 david-szabo97 commented Aug 25, 2020

Description

Related: #24101
Laying the foundation for a block-based post comment building. Adds a Post Comment block which requires a Comment ID input for now. The Post Comment block provides a context for the inner blocks.

As an example, also implemented a very simple Post Comment Content block, which uses the context provided by the Post Comment block.

How has this been tested?

  1. Open site editor
  2. Add Post Comment block
  3. Input an existing comment's ID
  4. Insert Post Comment Content block into the Post Comment block
  5. You should see the content of the comment

Types of changes

New feature

Checklist:

  • My code is tested.
  • My code follows the WordPress code style.
  • My code follows the accessibility standards.
  • My code has proper inline documentation.
  • I've included developer documentation if appropriate.
  • I've updated all React Native files affected by any refactorings/renamings in this PR.

Copy link
Contributor

@ockham ockham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unit tests are failing because of missing fixtures for the two new blocks that this PR introduces. This doc has some information on how to create them 🙂

@david-szabo97
Copy link
Member Author

@ockham Gotcha! Added the icons and fixtures. Tests are happy now!

Copy link
Contributor

@ockham ockham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good! This will provide us with a good baseline to work on other comment related blocks.

@david-szabo97 david-szabo97 merged commit a1201ab into WordPress:master Aug 26, 2020
@github-actions github-actions bot added this to the Gutenberg 8.9 milestone Aug 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants