Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correct @since version for block parser package #24819

Merged

Conversation

JustinyAhin
Copy link
Member

@JustinyAhin JustinyAhin commented Aug 26, 2020

Description

Fix #22050

Types of changes

Bug fix (non-breaking change which fixes an issue)

Checklist:

  • My code is tested.
  • My code follows the WordPress code style.
  • My code follows the accessibility standards.
  • My code has proper inline documentation.
  • I've included developer documentation if appropriate.
  • I've updated all React Native files affected by any refactorings/renamings in this PR.

@JustinyAhin JustinyAhin added the [Type] Developer Documentation Documentation for developers label Aug 26, 2020
@dmsnell
Copy link
Contributor

Nice work - thanks for cleaning this up @JustinyAhin!

@dmsnell dmsnell merged commit c47ba60 into WordPress:master Aug 31, 2020
@github-actions github-actions bot added this to the Gutenberg 9.0 milestone Aug 31, 2020
@JustinyAhin JustinyAhin deleted the fix/since-version-in-default-parser-php branch September 14, 2020 05:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Type] Developer Documentation Documentation for developers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The @since versions for WP_Block_Parser_Block are inaccurate
2 participants