print minified css for global styles #24924
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
annezazu added CSS Styling 
What do you think of using |
Good idea, added an extra check for that. |
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Description
For development purposes adding tabs and linebreaks to the generated styles makes sense since it makes things easier to read. But for production and code that is going to be shipped to millions of websites, we should try to minimize our footprint as much as possible.
This PR modifies the generated CSS from global styles so they don't include tabs, spaces, and linebreaks.
Every byte counts.
How has this been tested?
Tested that the same styles get generated and printed, the only thing that changes is whitespace.
Types of changes
Removed whitespace characters from the
gutenberg_experimental_global_styles_resolver_stylesfunction.Checklist:
My code has proper inline documentation.I've included developer documentation if appropriate.I've updated all React Native files affected by any refactorings/renamings in this PR.