Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account
Jump to bottom

Add block parent selector component readme #24962

Merged
merged 2 commits into from Sep 1, 2020
Merged

Add block parent selector component readme #24962

merged 2 commits into from Sep 1, 2020

Conversation

JustinyAhin
Copy link
Member

Description

Added documentation for the block parent selector component (see #22891)

How has this been tested?

N/A, documentation only

Types of changes

Documentation

Checklist:

  • [n/a] My code is tested.
  • [n/a] My code follows the WordPress code style.
  • [n/a] My code follows the accessibility standards.
  • [n/a] My code has proper inline documentation.
  • I've included developer documentation if appropriate.
  • I've updated all React Native files affected by any refactorings/renamings in this PR.

@JustinyAhin JustinyAhin mentioned this pull request Sep 1, 2020
Open
@ntsekouras ntsekouras added the [Type] Developer Documentation Documentation for developers label Sep 1, 2020
@JustinyAhin @ntsekouras
Update packages/block-editor/src/components/block-parent-selector/REA…
32becbb 
…DME.md

Co-authored-by: Nik Tsekouras <ntsekouras@outlook.com>
ntsekouras
ntsekouras approved these changes Sep 1, 2020
View reviewed changes
Copy link
Contributor

@ntsekouras ntsekouras left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your help @JustinyAhin! 👍

@ntsekouras ntsekouras merged commit 187167b into WordPress:master Sep 1, 2020
@github-actions github-actions bot added this to the Gutenberg 9.0 milestone Sep 1, 2020
@JustinyAhin
Copy link
Member Author

Thanks for your help @JustinyAhin! +1

My pleasure. Thanks for reviewing. I have on my list to write the docs for a few others packages (see #22891 (comment)) so there might be some others PR coming later today and in the week 😀.

@JustinyAhin JustinyAhin deleted the add/block-parent-selector-component-readme branch September 2, 2020 05:56
@JustinyAhin JustinyAhin restored the add/block-parent-selector-component-readme branch September 2, 2020 07:23
@JustinyAhin JustinyAhin mentioned this pull request Sep 2, 2020
Merged
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ntsekouras ntsekouras ntsekouras approved these changes

@ellatrix ellatrix Awaiting requested review from ellatrix

@youknowriad youknowriad Awaiting requested review from youknowriad

Assignees
No one assigned
Labels
[Type] Developer Documentation Documentation for developers
Projects
None yet
Milestone
Gutenberg 9.0
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@JustinyAhin @ntsekouras