Allow sharp gradients. #24967
Merged
Allow sharp gradients. #24967
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
jasmussen added [Type] Enhancement jasmussen requested review from ajitbohra, chrisvanpatten and youknowriad as code owners
Size Change: +144 B (0%) Total Size: 1.17 MB
ℹ️ View Unchanged
|
Hi @jasmussen, thank you for this fix 👍 It seems the variable MINIMUM_DISTANCE_BETWEEN_POINTS was also used for the distance between inserter and existing points and the movement that is applied to a point on using keyboard arrows. I created additional variables to fix the issue and it seems the inserter is working well now. Unfortunately, the keyboard movements are still broken but that is another issue not from this PR and I will try to fix it separately. Let me know if things are working well in your tests :) |
YES JORGE! That is solid! So good!
We can't ship this fast enough! |
Nice little improvement everyone :) |
This was referenced
Mar 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
This extracts a small change from #23802 (comment) to allow sharp gradients. Before, only this was possible:
With this PR, this is possible:
Fixes #23816. That's the good news.
The bad news is that the variable this PR changes allows the "plus" to be created on top of an existing handle:
It would be such a nice feature to have, is there an easy fix to address that? CC: @jorgefilipecosta