Add title attribute to Navigation Link block. #24993
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
tellthemachines requested review from ajitbohra, Soean and talldan as code owners
Size Change: +28 B (0%) Total Size: 1.17 MB
ℹ️ View Unchanged
|
Perhaps controversial, but I am wondering if there was any discussion about not supporting the title attribute? There is still an ongoing issue about removing title attributes from core. |
Great question! With this PR we're looking to replicate the functionality in the Menus screen ( If I read the ticket you linked to above correctly, it's about removing title attributes from the admin interface, not to stop users from adding them to their content. Whether to encourage users to not use these attributes is another question (and a good one!), but would be better addressed as a separate issue. |
This was referenced
Mar 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Description
Partially addresses #23731 by adding the "title" attribute to the Navigation Link block.
How has this been tested?
Tested in browser.
Screenshots
Types of changes
Checklist: