Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account
Jump to bottom

Add/block variation picker component readme #24995

Merged
merged 4 commits into from Sep 10, 2020
Merged

Add/block variation picker component readme #24995

merged 4 commits into from Sep 10, 2020

Conversation

JustinyAhin
Copy link
Member

Description

Added documentation for the block variations picker component (see #22891)

How has this been tested?

N/A, documentation only

Types of changes

Documentation

Checklist:

  • [n/a] My code is tested.
  • [n/a] My code follows the WordPress code style.
  • [n/a] My code follows the accessibility standards.
  • [n/a] My code has proper inline documentation.
  • I've included developer documentation if appropriate.
  • I've updated all React Native files affected by any refactorings/renamings in this PR.

@JustinyAhin JustinyAhin mentioned this pull request Sep 2, 2020
Open
@JustinyAhin JustinyAhin added the [Type] Developer Documentation Documentation for developers label Sep 2, 2020
mkaz
mkaz requested changes Sep 9, 2020
View reviewed changes
Copy link
Member

@mkaz mkaz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for going through and filling out the package documentation! 👍
I have a couple of minor changes.

packages/block-editor/src/components/block-variation-picker/README.md Show resolved Hide resolved
packages/block-editor/src/components/block-variation-picker/README.md Outdated Show resolved Hide resolved
mkaz
mkaz approved these changes Sep 10, 2020
View reviewed changes
Copy link
Member

@mkaz mkaz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the updates

@mkaz
Copy link
Member

I think you'll need to rebase to clear the failing test.
I saw something similar a day or two ago that got fixed with a rebase.

@JustinyAhin JustinyAhin force-pushed the add/block-variation-picker-component-readme branch from 7f3fbe8 to e87882d Compare September 10, 2020 18:53
@JustinyAhin JustinyAhin merged commit a94a95b into WordPress:master Sep 10, 2020
@github-actions github-actions bot added this to the Gutenberg 9.0 milestone Sep 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mkaz mkaz mkaz approved these changes

@talldan talldan Awaiting requested review from talldan

Assignees
No one assigned
Labels
[Type] Developer Documentation Documentation for developers
Projects
None yet
Milestone
Gutenberg 9.0
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@JustinyAhin @mkaz