Fix unlinked padding controls JS error #25000
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
youknowriad added [Type] Bug youknowriad requested review from ajitbohra and chrisvanpatten as code owners
Size Change: +11 B (0%) Total Size: 1.17 MB
ℹ️ View Unchanged
|
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
It seems that the
styledHoC can add extra emptychildrenprops? At last that's what my debugging suggests.So I'm omitting this from spreading to children components.
This is one of the reasons I don't like prop spreading in UI components. We should probably move away from this at some point and be more specific about what props we allow.
Testing instructions