Size Change: +9 B (0%)

Total Size: 1.17 MB

_{compressed-size-action}

it might not be able to find existing autodrafts because it does not convert the slug.

Looking through the code for auto-drafting, it seems like this would be the case. Im thinking we would just need to change the 'name' value in that query array you mentioned by adding the clean_for_slug there.

Looking at the format of the autodraft:

$post = [
  "post_title" => "test-dir/new-template-part",
  "post_status" => "auto-draft",
  "post_name" => "test-dir-new-template-part"
  "post_type" => "wp_template_part",

];

When inserting the post, both title and name are set to the slug, so it appears that only the name field is being modified here 🤔

Looking at this code though:

It looks like we avoid referencing the ID for auto-draft, so it would only affect things after the template part is considered "published". (That said, doesn't that mean that we are creating tons of extra autodrafts??)

(That said, doesn't that mean that we are creating tons of extra autodrafts??)

In the case of template parts in nested folders, yes that seems like thats what it would mean. But if we clean_for_slug the name field in the first query that should prevent it.

It looks like we avoid referencing the ID for auto-draft, so it would only affect things after the template part is considered "published".

Im not exactly sure what you mean here. If it is an auto draft it checks to see if that auto draft's content match the file contents to see if it needs to create a new one, but either way it still returns the auto-drafts ID.

If it is an auto draft it checks to see if that auto draft's content match the file contents to see if it needs to create a new one

Ah, this is the part I was missing, thanks.

But if we clean_for_slug the name field in the first query that should prevent it.

I'm struggling to find a similar PHP function :/ I'm thinking we could search for title instead of name so that we don't have to do any conversion there.

@Addison-Stavlo I added error_log calls locally, and it was creating new autodrafts for nested template parts every time that function was called.

With 93abd13, I confirmed that it no longer does that. We use title now instead of name, since title does not appear to change the format of the slug like name does.

Hmmm...I think I may be misunderstanding something.

Original Steps:

1. delete all existing template and template part CPTs.
2. In an existing block-based theme mapped to your WordPress instance, create a new subdirectory under block-template-parts called template-part-subdir
3. In that subdirectory, create a new file called new-template-part.html. Copy/paste some block markup into that file and make sure you can identify what the content is by changing some paragraph content or something like that.
4. From an existing template (e.g. index or singular), update one of the template parts slugs to say template-part-subdir/new-template-part. (e.g. change the slug from header to essentially the path to the new template part under the subdirectory)
5. Open that template in the site editor and make sure that the template part loads from the subdirectory.

What I did:

1. I ran npx wp-env destroy all
2. I created the block-template-parts/template-part-subdir/ subdirectory for seedlet-blocks
3. I added new-template-part.html to the subdirectory
4. I added distinct content to the new file
5. I enabled seedlet blocks and the site editor
6. I navigated to the site editor and renamed the header to template-part-subdir/new-template-part
7. I created a new template part block and tried to choose the existing template-part-subdir/new-template-part

The template part does not display the distinct content in the new file I made

tried to choose the existing template-part-subdir/new-template-part

I don't think we ever try to find all template parts provided by the theme and then pull them into the site editor. We only ever show template parts from themes which are used by templates that the theme provides. Essentially, when loading the template, we look for all template part blocks in the template, and only then try to find block template part HTML files which match the slugs in the template part blocks. So I'm not sure if it would show up otherwise.

From an existing template (e.g. index or singular), update one of the template parts slugs to say template-part-subdir/new-template-part

If you do this step from the template HTML file before loading it in the site editor, it should work.

I navigated to the site editor and renamed the header to template-part-subdir/new-template-part

I'm not sure if this would work because template-part-subdir/new-template-part is changed to template-part-subdir-new-template-part in cleanForSlug. Since no autodrafts are made for template parts until they are referenced by a template, I'm not sure it would find anything...

I created a new template part block and tried to choose the existing template-part-subdir/new-template-part

Does it show up in the list as an option?

At any rate, I think you're uncovering some more limitations with template part loading. I think they might possibly apply more broadly than just template parts with / in the slug.

I ran npx wp-env destroy all

Also, just a couple tips for this step:

• npx wp-env destroy destroys everything related to the current local instance, no all param needed
• npx wp-env clean all would wipe the databases without cleaning up anything else
• you can delete customized template and template part CPTs from the Appearance > Template or Appearance > Template Part menu in wp-admin :)

If you do this step from the template HTML file before loading it in the site editor, it should work.

Ahhhh I see. I should modify the template part slug in index.html. I tried again and referencing block templates in subdirectories works as expected 🎉

Also, just a couple tips for this step:

• npx wp-env destroy destroys everything related to the current local instance, no all param needed
• npx wp-env clean all would wipe the databases without cleaning up anything else
• you can delete customized template and template part CPTs from the Appearance > Template or Appearance > Template Part > menu in wp-admin :)

Thanks for the tips Noah 🙏

I'll go ahead and merge this. I think there may still be some weird things to work out when it comes to slugs & titles and the difference with cleanForSlug, but those can be done separately. This still fixes the root issue, which is allowing themes to include template parts from subdirectories, which is now working correctly.