Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account
Jump to bottom

Feature/18066 add plugin area to widgets screen #25074

Merged
merged 7 commits into from Sep 11, 2020
Merged

Feature/18066 add plugin area to widgets screen #25074

merged 7 commits into from Sep 11, 2020

Conversation

ryanwelcher
Copy link
Contributor

@ryanwelcher ryanwelcher commented Sep 4, 2020 •
edited

Description

This PR adds the PluginArea to the WidgetAreasBlockEditorProvider component and replaces #18067.

This is the first step for #18068

Closes #18066

How has this been tested?

Tested locally to ensure no visual changes occur.

Screenshots

Types of changes

Introduces the <PluginArea/> component. No visual changes.

Checklist:

  • My code is tested.
  • My code follows the WordPress code style.
  • My code follows the accessibility standards.
  • My code has proper inline documentation.
  • I've included developer documentation if appropriate.
  • I've updated all React Native files affected by any refactorings/renamings in this PR.

@ryanwelcher ryanwelcher mentioned this pull request Sep 4, 2020
Closed
5 tasks
@ryanwelcher ryanwelcher added [Feature] Extensibility The ability to extend blocks or the editing experience [Feature] Widgets Screen The block-based screen that replaced widgets.php. labels Sep 4, 2020
@ryanwelcher ryanwelcher added this to PRs in progress in Block-based Widgets Editor via automation Sep 4, 2020
draganescu
draganescu approved these changes Sep 11, 2020
View reviewed changes
Copy link
Contributor

@draganescu draganescu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a good step forward towards better extensibility of the Widgets screen. Tested locally and nothing breaks with the addition.

@draganescu draganescu merged commit ca167e4 into WordPress:master Sep 11, 2020
Block-based Widgets Editor automation moved this from PRs in progress to Done Sep 11, 2020
@github-actions github-actions bot added this to the Gutenberg 9.0 milestone Sep 11, 2020
This was referenced Mar 18, 2021
Merged
Closed
Closed
Merged
Closed
Merged
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@draganescu draganescu draganescu approved these changes

@youknowriad youknowriad Awaiting requested review from youknowriad

Assignees
No one assigned
Labels
[Feature] Extensibility The ability to extend blocks or the editing experience [Feature] Widgets Screen The block-based screen that replaced widgets.php.
Projects
No open projects
Block-based Widgets Editor
Done
Milestone
Gutenberg 9.0
Development

Successfully merging this pull request may close these issues.

Widgets: Add PluginArea to Layout component.
2 participants
@ryanwelcher @draganescu