Fix cover width regression. #25103
Merged
Fix cover width regression. #25103
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
jasmussen added [Type] Bug 
Size Change: -28 B (0%) Total Size: 1.2 MB
ℹ️ View Unchanged
|
This breaks the cover block styling on the frontend. It looks like this did more than just revert the change in #24523. It removed the entire line, rather than restoring it to what it originally was. This change is causing a width collapse of all cover blocks. |
Thank you @johnstonphilip for pointing that out. I created #26143 to fix it. |
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
This issue seems to have been made more visible by #24523, but did not seem to be the result of it.
Basically, the Cover block has an inner container, called
wp-block-cover__inner-container. This had a max-width ofcalc(100% - 70px). Since that rule was written for the UI that shipped with 5.4, I'm assuming those 70px were to accommodate for the side UI that was present (movers, etc).Since that side UI is no longer needed, that rule can be removed. Which in turn makes the editor consistent with the frontend:
Here's before: